[Bug 35110] New: Authorities editor with JS error when only one tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35110 Bug ID: 35110 Summary: Authorities editor with JS error when only one tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Exactly like Bug 34251 for biblios : When using the an authorities framework with all fields in the same tab, there is thrown a JS error in selectTab( "#tab0XX_panel" ); This is because no nav tabs are build in authorities/authorities.tt as BIG_LOOP has a length(size) of 1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35110 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34251 Assignee|oleonard@myacpl.org |fridolin.somers@biblibre.co | |m Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34251 [Bug 34251] MARC editor with JS error when using fast add framework -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35110 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33524 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33524 [Bug 33524] Use template wrapper for tabs: Authority editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35110 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- ... Maybe selectTab() should be moved to cataloging.js ... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35110 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Also we may have use TT syntax like in tabs build : [% IF BIG_LOOP.size <= 1 %] But JS does the job ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35110 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35110 --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 157477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157477&action=edit Bug 35110: Authorities editor with JS error when only one tab Exactly like Bug 34251 for biblios : When using the an authorities framework with all fields in the same tab, there is thrown a JS error in selectTab( "#tab0XX_panel" ); This is because no nav tabs are build in authorities/authorities.tt as BIG_LOOP has a length(size) of 1 Test plan : 1) Edit an authority framework, for example 'Meeting Name', to set all sufields in tab 0 You may use SQL : UPDATE auth_subfield_structure SET tab=0 WHERE authtypecode='MEETI_NAME' Don't forget to restart memcached 2) Go to 'Authorities' 3) Click on 'New authority' then 'Meeting Name' 4) Check you don't see any JavaScript error 5) Check you can save -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35110 --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 157478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157478&action=edit Bug 35110: (follow-up) Fix comment in addbiblio.tt Change comment in addbiblio.tt since any biblio framework may use only one tab. Also fixes indenting using 4 spaces. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35110 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35110 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157477|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 157554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157554&action=edit Bug 35110: Authorities editor with JS error when only one tab Exactly like Bug 34251 for biblios : When using the an authorities framework with all fields in the same tab, there is thrown a JS error in selectTab( "#tab0XX_panel" ); This is because no nav tabs are build in authorities/authorities.tt as BIG_LOOP has a length(size) of 1 Test plan : 1) Edit an authority framework, for example 'Meeting Name', to set all sufields in tab 0 You may use SQL : UPDATE auth_subfield_structure SET tab=0 WHERE authtypecode='MEETI_NAME' Don't forget to restart memcached 2) Go to 'Authorities' 3) Click on 'New authority' then 'Meeting Name' 4) Check you don't see any JavaScript error 5) Check you can save Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35110 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157478|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 157555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157555&action=edit Bug 35110: (follow-up) Fix comment in addbiblio.tt Change comment in addbiblio.tt since any biblio framework may use only one tab. Also fixes indenting using 4 spaces. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35110 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Issue fixed! 2. Noticed error in the console "downloadable font: Glyph bbox was incorrect" - there is a bug for this already - bug 34973 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35110 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35110 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35110 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157554|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 157566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157566&action=edit Bug 35110: Authorities editor with JS error when only one tab Exactly like Bug 34251 for biblios : When using the an authorities framework with all fields in the same tab, there is thrown a JS error in selectTab( "#tab0XX_panel" ); This is because no nav tabs are build in authorities/authorities.tt as BIG_LOOP has a length(size) of 1 Test plan : 1) Edit an authority framework, for example 'Meeting Name', to set all sufields in tab 0 You may use SQL : UPDATE auth_subfield_structure SET tab=0 WHERE authtypecode='MEETI_NAME' Don't forget to restart memcached 2) Go to 'Authorities' 3) Click on 'New authority' then 'Meeting Name' 4) Check you don't see any JavaScript error 5) Check you can save Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35110 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157555|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 157567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157567&action=edit Bug 35110: (follow-up) Fix comment in addbiblio.tt Change comment in addbiblio.tt since any biblio framework may use only one tab. Also fixes indenting using 4 spaces. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35110 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35110 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35110 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35110 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.05 |23.11.00,23.05.05,22.11.12 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35110 --- Comment #12 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35110 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alejojanin@gmail.com --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- *** Bug 34541 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35110 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org Status|Pushed to oldstable |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35110 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #14 from David Nind <david@davidnind.com> --- This fixes a bug. No changes required to the documentation. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org