https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21999 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21721 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721 [Bug 21721] Update C4::Circulation::AddRenewal to use Koha::Account->add_debit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21999 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21720 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21720 [Bug 21720] Update C4::Circulation::AddIssuingCharge to use Koha::Account->add_debit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21999 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 83216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83216&action=edit Bug 21999: Update Tests to reflect new return value of AddIssue -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21999 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- So.. this is a bit of a 'quick fix'.. the long term we will likely want to deprecate AddIssue and move it into Koha::*.. but, some places already expect the returned value to be a Koha::Checkout so this is the patch I've come up with. Test plan.. the majority of places that call AddIssue do so in VOID context and so this change of return value should not affect them. Most cases where the return value is used were in the tests and those have been updated in the second patch... that just leaves `circ/circulation.pl` where the return is passed into the template (and the Koha::Object should be seamless there). Finally, SIP uses the returned value too but in such a way that the Koha::Checkout being returned instead is also fine (as we only ever look at the date_due field). To Test.. apply patches.. run the full test suit and everything should pass. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21999 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83215|0 |1 is obsolete| | --- Comment #4 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Created attachment 83244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83244&action=edit Bug 21999: Use Koha::Checkout in C4::Circulation::AddIssue Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21999 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre-marc.thibault@inlibr | |o.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21999 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |19.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21999 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83244|0 |1 is obsolete| | Attachment #83245|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 83327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83327&action=edit Bug 21999: Use Koha::Checkout in C4::Circulation::AddIssue Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21999 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 83329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83329&action=edit Bug 21999: FIXMEs are fixed! Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21999 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com QA Contact|testopia@bugs.koha-communit |jonathan.druart@bugs.koha-c |y.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21999 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series -- You are receiving this mail because: You are watching all bug changes.