[Bug 18851] New: use Test::DBIx::Class in 00-load.t breaks packaging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Bug ID: 18851 Summary: use Test::DBIx::Class in 00-load.t breaks packaging Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: mirko@abunchofthings.net QA Contact: testopia@bugs.koha-community.org Bug 18266 introduces a regression for a problem fixed in Bug 15150. Test::DBIx::Class is not mandatory because it is not available in Debian, packaging of Koha is broken because of the use in t/00-load.t. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18266 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18266, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15150 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18266 [Bug 18266] Internal Server Error when paying fine for lost item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 --- Comment #1 from Mirko Tietgen <mirko@abunchofthings.net> --- Bug 18226 introduces a regression for a problem fixed in Bug 15150. Test::DBIx::Class is not mandatory because it is not available in Debian, packaging of Koha is broken because of the use in t/00-load.t. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18266 | Depends on|18266 |18226 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226 [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18266 [Bug 18266] Internal Server Error when paying fine for lost item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |m.de.rooy@rijksmuseum.nl, | |olli-antti.kivilahti@jns.fi | |, tomascohen@gmail.com --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- My bad, I completely forgot that this module was not packaged. So we have a problem here, the way we mocked our DB was not reliable and we fixed it using Test::DBIx::Class. Olli, Tomas, Marcel, any ideas? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Ok, I am on it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64830&action=edit Bug 18851: Database handler must not be created at runtime -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64831&action=edit Bug 18851: Test::DBIx::Class is not needed in 00-load.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64832&action=edit Bug 18851: Tests must be skipped in cardnumber.t if Test::DBIx::Class is not installed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Mirko, could you confirm these patches fix the problem? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- non-dependent tests must be tested with and without Test::DBIx::Class and with and without the DBMS running -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 --- Comment #9 from Mirko Tietgen <mirko@abunchofthings.net> --- Problems with missing Test::DBIx::Class are still present in t/Patron.t t/Search.t t/SuggestionEngine_AuthorityFile.t Additionally there are a lot of tests failing because of missing DB. They should be skipped if DB is not available. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 --- Comment #10 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 64913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64913&action=edit build log: tests Attached file: build log: tests. Problems with Test::DBIx::Class and missing DB -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I do not recreate the DB issues: prove t/Biblio.t t/Biblio2.t t/Biblio.t ... skipped: Need Test::DBIx::Class t/Biblio2.t .. ok All tests successful. Files=2, Tests=2, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.42 cusr 0.18 csys = 0.62 CPU) Result: PASS mysql is stopped and Test::DBIx::Class is not installed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64979&action=edit Bug 18851: Fix 3 other tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I recreated the "Can't connect to MySQL server" errors, but actually they existed before bug 18266, there is nothing new here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 --- Comment #14 from Mirko Tietgen <mirko@abunchofthings.net> --- (In reply to Jonathan Druart from comment #13)
I recreated the "Can't connect to MySQL server" errors, but actually they existed before bug 18266, there is nothing new here.
Thanks. It must have been pushed around the same time then I guess. Last working nightly was June 5. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 --- Comment #15 from Mirko Tietgen <mirko@abunchofthings.net> --- Tests pass with the latest patch, nightly package + patch build works. I still get the DB messages, but they seem to be only warnings then. Thanks! I'll do a signoff when I get near a dev machine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64830|0 |1 is obsolete| | --- Comment #16 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 64990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64990&action=edit Bug 18851: Database handler must not be created at runtime Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64831|0 |1 is obsolete| | --- Comment #17 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 64991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64991&action=edit Bug 18851: Test::DBIx::Class is not needed in 00-load.t Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64832|0 |1 is obsolete| | --- Comment #18 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 64992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64992&action=edit Bug 18851: Tests must be skipped in cardnumber.t if Test::DBIx::Class is not installed Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64979|0 |1 is obsolete| | --- Comment #19 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 64993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64993&action=edit Bug 18851: Fix 3 other tests Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|use Test::DBIx::Class in |use Test::DBIx::Class in |00-load.t breaks packaging |tests breaks packaging -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- These all work for me, however, t/Koha_ExternalContent_OverDrive.t fails for me without a db. Can you test with WebService::ILS::OverDrive::Patron installed and verify? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65199&action=edit Bug 18851: Make OverDrive.T pass if dbms is not running -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- With SQL stopped and no Test::DBIx::Class - all pass With SQL stopped and Test::DBIx::Class: t/Patron.t (Wstat: 65280 Tests: 2 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 11 tests but ran 2. t/SuggestionEngine_AuthorityFile.t (Wstat: 256 Tests: 4 Failed: 1) Failed test: 4 Non-zero exit status: 1 Parse errors: Bad plan. You planned 46 tests but ran 4. t/XSLT.t (Wstat: 65280 Tests: 8 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 9 tests but ran 8. With SQL started and no Test::DBIx::Class - all pass With SQL started and Test::DBIx::Class: t/SuggestionEngine_AuthorityFile.t (Wstat: 256 Tests: 4 Failed: 1) Failed test: 4 Non-zero exit status: 1 Parse errors: Bad plan. You planned 46 tests but ran 4. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64993|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65368&action=edit Bug 18851: Fix few other tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64990|0 |1 is obsolete| | --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 65574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65574&action=edit Bug 18851: Database handler must not be created at runtime Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64991|0 |1 is obsolete| | --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 65575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65575&action=edit Bug 18851: Test::DBIx::Class is not needed in 00-load.t Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64992|0 |1 is obsolete| | --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 65576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65576&action=edit Bug 18851: Tests must be skipped in cardnumber.t if Test::DBIx::Class is not installed Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65199|0 |1 is obsolete| | --- Comment #27 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 65577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65577&action=edit Bug 18851: Make OverDrive.T pass if dbms is not running Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65368|0 |1 is obsolete| | --- Comment #28 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 65578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65578&action=edit Bug 18851: Fix few other tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 65579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65579&action=edit Bug 18851: (QA followup) Test doesn't need sessions on DB As the DB structure is not initialized for sessions, running this tests raise an irrelevant warning. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #30 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I successfully ran all the tests: - With and without a DB server running - With and without Test::DBIx::Class installed Added a tiny followup to avoid irrelevant warnings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #32 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I have a lot of conflicts during rebase on 17.05.x and I'm not sure my test env is well configured to mock DB. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|use Test::DBIx::Class in |Use Test::DBIx::Class in |tests breaks packaging |tests breaks packaging CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #33 from Mirko Tietgen <mirko@abunchofthings.net> --- Fridolin: I suppose you missed that it depends on bug 18226. I could easily apply both to 17.05.x, there is just one test to 'git add'. This would probably fix the failing t/XSLT.t in 17.05.x (with Test::DBiX::Class but without DB, as on the nightly server). Would you reconsider pushing to 17.05.x? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 --- Comment #34 from Mirko Tietgen <mirko@abunchofthings.net> --- Nevermind, it fails a lot more tests afterwards. There is more missing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 --- Comment #35 from Mirko Tietgen <mirko@abunchofthings.net> --- Ok, it is, in this order, 18285 18286 18287 18288 18289 18226 18851 No rebase needed. All tests run fine afterwards (not checked db-dependent) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|REOPENED |RESOLVED --- Comment #36 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- 17.05.x end of life is in septembre so I will keep as it is -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org