[Bug 7697] New: Clean up borrower.textmessaging leftover code
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7697 Priority: P5 - low Change sponsored?: --- Bug ID: 7697 CC: gmcharlt@gmail.com Assignee: koha.sekjal@gmail.com Summary: Clean up borrower.textmessaging leftover code QA Contact: m.de.rooy@rijksmuseum.nl Severity: trivial Classification: Unclassified OS: All Reporter: koha.sekjal@gmail.com Hardware: All Status: NEW Version: rel_3_8 Component: Patrons Product: Koha opac/opac-main.pl and opac/opac-user.pl export a template param 'textmessaging', based on the database field borrower.textmessaging, which does not exist in Koha 3.X. While this is generally harmless, it does add a dependency on C4/Members to opac/opac-main.pl, which goes nowhere and does nothing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7697 --- Comment #1 from Ian Walls <koha.sekjal@gmail.com> --- Created attachment 8147 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8147&action=edit Bug 7697: Remove unused textmessaging parameter from OPAC main/user Removes the textmessaging parameter from opac/opac-main.pl and opac/opac-user.pl, since it's not utilized anywhere in the templates, and is sourced from a field that no longer exists in the borrower table (textmessaging). This also removes a dependency on C4/Members.pm from opac-main.pl To Test: Login to the OPAC, and view both opac-user.pl and opac-main.pl. Both pages should still render properly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7697 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7697 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8147|0 |1 is obsolete| | --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 8149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8149&action=edit Bug 7697: Remove unused textmessaging parameter from OPAC main/user Removes the textmessaging parameter from opac/opac-main.pl and opac/opac-user.pl, since it's not utilized anywhere in the templates, and is sourced from a field that no longer exists in the borrower table (textmessaging). This also removes a dependency on C4/Members.pm from opac-main.pl To Test: Login to the OPAC, and view both opac-user.pl and opac-main.pl. Both pages should still render properly. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7697 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jcamins@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7697 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Looks good to me. Marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7697 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed I also have checked that opac note & patron message are still here, they are -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org