[Bug 21278] New: CANCEL_HOLD_ON_LOST notice contains different variables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21278 Bug ID: 21278 Summary: CANCEL_HOLD_ON_LOST notice contains different variables Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org The sample notice CANCEL_HOLD_ON_LOST contains variables with the syntax [% xxx %] instead of << xxx >>. in installer/data/mysql/en/mandatory/sample_notices.sql -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21278 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Caroline, that's the new TT syntax - it should work. Have you tested? The notice also uses an IF/ELSE construct to display the right reason, this would not be possible without TT (Template Toolkit) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21278 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Katrin, I didn't test it, but I figured it might be confusing to end users if they see some notices have [% xxx %] and other notices have << xxx >>. Either they should all be [% xxx %] or all << xxx >>, not a mix of the two. If it is indeed changing, we have a lot of work to do in the manual and the wiki to change the instructions on how to customize the notices. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21278 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It's a process, I think starting with the new notices now. The account slip notices (payment/waive receipts) in 18.11 will also be TT from the start, as they make calculations and do formatting (look in master). The old ones are supposed to be converted too, maybe this should be a goal for 18.11? Look at the graph view of this bug: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15279 There are 2 examples for converted notices here: https://wiki.koha-community.org/wiki/Notices_and_Slips_Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21278 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- All new notices should use the TT syntax. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org