[Bug 28304] New: C4/Templates::new causes error logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28304 Bug ID: 28304 Summary: C4/Templates::new causes error logs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: michael.hafen@washk12.org QA Contact: testopia@bugs.koha-community.org In C4/Templates::new() there is a call to $self->activethemes(), which I presume is to initialize a class variable. There is a sub in that packaged named activethemes though, which gets called instead, and results in a few lines in the web server error log because of incorrect parameters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28304 Michael Hafen <michael.hafen@washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28304 --- Comment #1 from Michael Hafen <michael.hafen@washk12.org> --- Created attachment 120723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120723&action=edit Proposed fix -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28304 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |michael.hafen@washk12.org Component|Templates |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28304 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28304 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28304 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120723|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 121113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121113&action=edit Bug 28304: Quiet a warning from C4/Templates Change the code in C4/Templates::new() which I presume initialized an instance variable for caching. This call ends up calling a package method instead. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28304 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Resolution|--- |DUPLICATE Status|Signed Off |RESOLVED --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Duplicate of bug 26734? *** This bug has been marked as a duplicate of bug 26734 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28304 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #3)
Duplicate of bug 26734?
*** This bug has been marked as a duplicate of bug 26734 ***
Sorry, caused by bug 26734, but a recent follow-up has been pushed to fix this problem: commit e66d69fa3eaa42f484d47f1fffbf7a91156c3223 Bug 26734: Rename activethemes with availablethemes -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org