[Bug 10012] New: Remove all traces of NoZebraIndexes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10012 Bug ID: 10012 Summary: Remove all traces of NoZebraIndexes Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de CC: gmcharlt@gmail.com Created attachment 17314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17314&action=edit screenshot I found references to NoZebra in 3 places on current master: 1) In our updated 3.6 - 3.12 I still have the NoZebraIndexes show up in the local use preferences tab. Not sure if we can delete this system preference safely on updating existing installations, but it might be nice to do it with some other clean up. 2) The Italian installer files are still referencing NoZebraIndexes: / installer / data / mysql / it-IT / necessari / system_preferences.sql UPDATE systempreferences SET value = '\'title\' => \'200a,200c,200d,200e,225a,225d,225e,225f,225h,225i,225v,500*,501*,503*,510*,512*,513*,514*,515*,516*,517*,518*,519*,520*,530*,531*,532*,540*,541*,545*,604t,610t,605a\',\r\n\'author\' => \'200f,600a,601a,604a,700a,700b,700c,700d,700a,701b,701c,701d,702a,702b,702c,702d,710a,710b,710c,710d,711a,711b,711c,711d,712a,712b,712c,712d\',\r\n\'isbn\' => \'010a\',\r\n\'issn\' => \'011a\',\r\n\'biblionumber => \'0909\',\r\n\'itemtype\' => \'200b\',\r\n\'language\' => \'101a\',\r\n\'publisher\' => \'210c\',\r\n\'date\' => \'210d\',\r\n\'note\' => \r\n\'300a,301a,302a,303a,304a,305a,306az,307a,308a,309a,310a,311a,312a,313a,314a,315a,316a,317a,318a,319a,320a,321a,322a,323a,324a,325a,326a,327a,328a,330a,332a,333a,336a,337a,345a\',\r\n\'Koha-Auth-Number\' => \'6009,6019,6029,6039,6049,6059,6069,6109,7009,7019,7029,7109,7119,7129\',\r\n \'subject\' => \'600*,601*,606*,610*\',\r\n \'dewey\' => \'676a\',\r\n \'homebranch\' => \'995a,995b\',\r\n \'lcn\' => \'995k\'' WHERE variable = 'NoZebraIndexes'; 3) I can also see references to the nozebra indexes in the marc subfield table. For example 245$a. Be careful: After saving the field again, the information disappears (see screenshot). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10012 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2778 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10012 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=2778 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10012 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10012 --- Comment #1 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 25548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25548&action=edit Bug 10012: remove last traces of NoZebra This patch removes the last traces of NoZebra: [1] The DBIC schema class for the nozebra table [2] References to the NoZebra and NoZebraIndexes sysprefs in the Italian SQL scripts. [3] Deleting the NoZebraIndexes syspref if it's still present. To test: [1] Verify that after applying the patch and running the DB upgrade, that "NoZebraIndexes" is no longer to be found in the systempreferences table. [2] Verify that "nozebra" is not referenced anywhere in the source code except for the database update scripts. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10012 --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 25549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25549&action=edit Bug 10012: remove last traces of NoZebra This patch removes the last traces of NoZebra: [1] The DBIC schema class for the nozebra table [2] References to the NoZebra and NoZebraIndexes sysprefs in the Italian SQL scripts. [3] Deleting the NoZebraIndexes syspref if it's still present. To test: [1] Verify that after applying the patch and running the DB upgrade, that "NoZebraIndexes" is no longer to be found in the systempreferences table. [2] Verify that "nozebra" is not referenced anywhere in the source code except for the database update scripts. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10012 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25548|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10012 wajasu <matted-34813@mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25549|0 |1 is obsolete| | CC| |matted-34813@mypacks.net --- Comment #3 from wajasu <matted-34813@mypacks.net> --- Created attachment 25680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25680&action=edit [SIGNED-OFF] Bug 10012: remove last traces of NoZebra Applied patch and recursively grepped for NoZebraIndexes in all the files. These shown were acceptable. SIGNING OFF. 2:17:52 {bug10012 %} ~/prj/kohaclone$ find . -name "*.*" -exec grep -Hn "NoZebraIndexes" {} \; grep: .: Is a directory ./installer/data/mysql/update22to30.pl:538: variable => 'NoZebraIndexes', ./installer/data/mysql/updatedatabase.pl:2105: $dbh->do("UPDATE `systempreferences` SET type='Textarea', options='70|10', explanation='Enter a specific hash for NoZebra indexes. Enter : \\\'indexname\\\' => \\\'100a,245a,500*\\\',\\\'index2\\\' => \\\'...\\\'' WHERE variable='NoZebraIndexes'"); ./installer/data/mysql/updatedatabase.pl:8018: DELETE FROM systempreferences WHERE variable = 'NoZebraIndexes' grep: ./.git: Is a directory Binary file ./.git/objects/pack/pack-253b6c1a887ecc2ba955195950cc2997cd46ae40.pack matches ./misc/release_notes/release_notes_30002.txt:297:Bug 2868: fixing typo in NoZebraIndexes setting in sysprefs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10012 wajasu <matted-34813@mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10012 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Assignee|koha-bugs@lists.koha-commun |gmc@esilibrary.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10012 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17314|0 |1 is obsolete| | --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Comment on attachment 17314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17314 screenshot Obsoleting a picture of MARC subfield structure admin for 245 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10012 --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 26175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26175&action=edit Bug 10012: remove last traces of NoZebra This patch removes the last traces of NoZebra: [1] The DBIC schema class for the nozebra table [2] References to the NoZebra and NoZebraIndexes sysprefs in the Italian SQL scripts. [3] Deleting the NoZebraIndexes syspref if it's still present. To test: [1] Verify that after applying the patch and running the DB upgrade, that "NoZebraIndexes" is no longer to be found in the systempreferences table. [2] Verify that "nozebra" is not referenced anywhere in the source code except for the database update scripts. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: wajasu <matted-34813@mypacks.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10012 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10012 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10012 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25680|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10012 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10012 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.07 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org