[Bug 32122] New: Wrong permissions check on item circulation alerts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32122 Bug ID: 32122 Summary: Wrong permissions check on item circulation alerts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Bug 14391 added granular permissions for the administration module, however, there was a mismatch in the check on item circulation alerts and the new permission -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32122 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32122 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 143370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143370&action=edit Bug 32122: Correct permissions check on item circulation alerts This patch changes the check from 'item_circ_alerts' to 'manage_item_circ_alerts' To test: 1 - Give an account catalogue and manage_item_circ_alerts permissions 2 - Log in to staff client iwht this account 3 - Browse to Admin->Item circulation alerts 4 - Error, you do not have permission to view this page 5 - Apply patch 6 - Restart all 7 - Browse to page agian, success! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32122 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14391 Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391 [Bug 14391] Granular permissions for the administration module -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32122 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Straight to QA, minor and easy fix -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32122 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32122 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143370|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32122 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143372&action=edit Bug 32122: Correct permissions check on item circulation alerts This patch changes the check from 'item_circ_alerts' to 'manage_item_circ_alerts' To test: 1 - Give an account catalogue and manage_item_circ_alerts permissions 2 - Log in to staff client iwht this account 3 - Browse to Admin->Item circulation alerts 4 - Error, you do not have permission to view this page 5 - Apply patch 6 - Restart all 7 - Browse to page agian, success! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32122 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32122 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org