[Bug 30648] New: Title is lost in Holds History when biblio is deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Bug ID: 30648 Summary: Title is lost in Holds History when biblio is deleted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The patron hold history page shows "No title" for old holds on records that have since been deleted. We should get the title from deletedbibios if possible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25260 CC| |jonathan.druart+koha@gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Impossible, we lost the link. We need bug 25260. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have confirmed it. In old_reserves the biblionumber is set to NULL when the bibliographic record is deleted. I know that merging the tables is the ultimate solution, but is there another solution we could think of? Maybe we could not cascade on delete? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- In the meantime I think we need an update to the holds history page in the OPAC to exclude deleted titles. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Title is lost in Holds |Title is lost in holds |History when biblio is |history when biblio is |deleted |deleted -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Michael Adamyk <madamyk@ckls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madamyk@ckls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36345 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36345 [Bug 36345] Deleting related things causes data loss for old_reserves -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172687&action=edit Bug 30648: Add deleted_biblionumber column for reserves -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172688&action=edit Bug 30648: DO NOT PUSH - Schema update -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172689&action=edit Bug 30648: Record deleted_biblionumber in holds This patch ensures the deleted biblionumber is recorded in current and previous holds before the record is deleted To test: 1 - Place and fill a few holds on a biblio, completing checkout to patron 2 - Place a few holds on the biblio and do not fulfill them 3 - Delete the items from the biblio via the DB (otherwise you cannot delete last item when there are holds) DELETE FROM items WHERE biblionumber={biblionumber} 4 - Delete the biblio 5 - Check the DB and confirm the deleted_biblionumber column has been filled SELECT reserve_id,deleted_biblionumber,biblionumber FROM old_reserves WHERE deleted_biblionumber = {biblionumber}; 6 - Sign off! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 --- Comment #7 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172690&action=edit Bug 30648: Unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 --- Comment #8 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172691&action=edit Bug 30648: Add new field to REST API Maybe we just undef it since ti will always be null except for old_hold obecjts and we don't have that route yet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 --- Comment #9 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172692&action=edit Bug 30648: Tidy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Do we abandon bug 25260 then? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #10)
Do we abandon bug 25260 then?
I don't think we need to: keeping the deleted biblionumber is not the same problem as merging old_reserves and reserves. It would still be needed with the merge. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172687|0 |1 is obsolete| | --- Comment #12 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 173340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173340&action=edit Bug 30648: Add deleted_biblionumber column for reserves Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172688|0 |1 is obsolete| | --- Comment #13 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 173341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173341&action=edit Bug 30648: DO NOT PUSH - Schema update Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172689|0 |1 is obsolete| | --- Comment #14 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 173342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173342&action=edit Bug 30648: Record deleted_biblionumber in holds This patch ensures the deleted biblionumber is recorded in current and previous holds before the record is deleted To test: 1 - Place and fill a few holds on a biblio, completing checkout to patron 2 - Place a few holds on the biblio and do not fulfill them 3 - Delete the items from the biblio via the DB (otherwise you cannot delete last item when there are holds) DELETE FROM items WHERE biblionumber={biblionumber} 4 - Delete the biblio 5 - Check the DB and confirm the deleted_biblionumber column has been filled SELECT reserve_id,deleted_biblionumber,biblionumber FROM old_reserves WHERE deleted_biblionumber = {biblionumber}; 6 - Sign off! Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172690|0 |1 is obsolete| | --- Comment #15 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 173343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173343&action=edit Bug 30648: Unit tests Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172691|0 |1 is obsolete| | --- Comment #16 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 173344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173344&action=edit Bug 30648: Add new field to REST API Maybe we just undef it since ti will always be null except for old_hold obecjts and we don't have that route yet Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172692|0 |1 is obsolete| | --- Comment #17 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 173345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173345&action=edit Bug 30648: Tidy Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |anneli.osterman@koha-suomi. | |fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173340|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173491&action=edit Bug 30648: Add deleted_biblionumber column for reserves Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173341|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173492&action=edit Bug 30648: DO NOT PUSH - Schema update Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173342|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173493&action=edit Bug 30648: Record deleted_biblionumber in holds This patch ensures the deleted biblionumber is recorded in current and previous holds before the record is deleted To test: 1 - Place and fill a few holds on a biblio, completing checkout to patron 2 - Place a few holds on the biblio and do not fulfill them 3 - Delete the items from the biblio via the DB (otherwise you cannot delete last item when there are holds) DELETE FROM items WHERE biblionumber={biblionumber} 4 - Delete the biblio 5 - Check the DB and confirm the deleted_biblionumber column has been filled SELECT reserve_id,deleted_biblionumber,biblionumber FROM old_reserves WHERE deleted_biblionumber = {biblionumber}; 6 - Sign off! Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173343|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173494&action=edit Bug 30648: Unit tests Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173344|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173495&action=edit Bug 30648: Add new field to REST API Maybe we just undef it since ti will always be null except for old_hold obecjts and we don't have that route yet Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173345|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173496&action=edit Bug 30648: Tidy Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Title is lost in holds |Title is lost in holds |history when biblio is |history when bibliographic |deleted |record is deleted --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Small stuff: 1) Database update * Please use say_success -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- But overall: happy to see this fix :) Do we have a bug for issues and old_issues already and circulation history? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #27 from Jonathan Druart <jonathan.druart@gmail.com> --- API tests broken by this: POST /api/v1/holds [{"message":"Expected integer - got null.","path":"\/body\/deleted_biblio_id"}] t/db_dependent/api/v1/biblios.t t/db_dependent/api/v1/patrons_holds.t t/db_dependent/api/v1/holds.t Koha_Main/3078 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #27)
API tests broken by this:
POST /api/v1/holds [{"message":"Expected integer - got null.","path":"\/body\/deleted_biblio_id"}]
t/db_dependent/api/v1/biblios.t t/db_dependent/api/v1/patrons_holds.t t/db_dependent/api/v1/holds.t
Koha_Main/3078
Joubu is always a step ahead of me, I was still typing this out. Please fix urgently! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 --- Comment #29 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173611&action=edit Bug 30648: deleted_biblio_id can be null -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 --- Comment #30 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #29)
Created attachment 173611 [details] [review] Bug 30648: deleted_biblio_id can be null
t/db_dependent/api/v1/biblios.t still failing after this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 --- Comment #31 from Jonathan Druart <jonathan.druart@gmail.com> --- Tests are missing for Koha/Biblio.pm:sub old_holds { -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'll grab the first follow-up here for the next push already. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Suspecting this is related here:
prove t/db_dependent/api/v1/holds.t t/db_dependent/api/v1/holds.t .. 1/14 No reserves HOLD_CANCELLATION letter transported by email at /kohadevbox/koha/C4/Letters.pm line 610. t/db_dependent/api/v1/holds.t .. 12/14 # Looks like you planned 37 tests but ran 3. t/db_dependent/api/v1/holds.t .. 13/14 # Failed test 'PUT /holds/{hold_id}/pickup_location tests' # at t/db_dependent/api/v1/holds.t line 1470. Can't locate object method "branchcode" via package "euRljh" (perhaps you forgot to load "euRljh"?) at t/db_dependent/api/v1/holds.t line 1377. # Looks like your test exited with 11 just after 13. t/db_dependent/api/v1/holds.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 2/14 subtests
There is a comment on bug 30661 that might help fix: (In reply to Johanna Räisä from comment #30)
I didn't get that HOLD_CANCELLATION error after I pulled main repo. The subtest "PUT /holds/{hold_id}/pickup_location tests" fails in holds.t
There are some interesting branchcode fetching in "PUT /holds/{hold_id}/pickup_location tests" at least: $hold->discard_changes->branchcode->branchcode If those second branchcode values are removed the tests pass in that subtest.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We got a fix for this as follow-up on bug 38273 now! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 --- Comment #35 from Jonathan Druart <jonathan.druart@gmail.com> --- DB revs: say_success statements must be inside the if ! column_exists blocks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38395 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38395 [Bug 38395] Title is not displayed in hold history when biblio is deleted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #36 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I see a commit in main that are not part of this bug report. What am I missing? 9c2ec5798b9f1062b15433554c33e9089460c2cf Bug 30648: (QA follow-up) Terminology: reserve => hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass (lukeg) from comment #36)
I see a commit in main that are not part of this bug report. What am I missing?
9c2ec5798b9f1062b15433554c33e9089460c2cf Bug 30648: (QA follow-up) Terminology: reserve => hold
I didn't always attach follow-ups to the bug reports assuming RMaints would cherry-pick via git anyway. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.06 released in| | --- Comment #38 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- BAckported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #39 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #25)
But overall: happy to see this fix :)
Do we have a bug for issues and old_issues already and circulation history?
I have the same question. Whould be great to have consistency between holds history and issues history. Although old_issue has itemnumber and not biblionumber. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 --- Comment #40 from Fridolin Somers <fridolin.somers@biblibre.com> --- I'm not sure about backporting to 23.11.x for stablity I first wait for Bug 38395 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 --- Comment #41 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Noting for future readers that these patches got koha to retain the biblionumber of the deleted record but did not make koha use that retained number to display anything. See bug 38395 for that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #42 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #43 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to Fridolin Somers from comment #39)
(In reply to Katrin Fischer from comment #25)
But overall: happy to see this fix :)
Do we have a bug for issues and old_issues already and circulation history?
I have the same question. Whould be great to have consistency between holds history and issues history. Although old_issue has itemnumber and not biblionumber.
Bug 40704 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #44 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to Andrew Fuerste-Henry from comment #41)
Noting for future readers that these patches got koha to retain the biblionumber of the deleted record but did not make koha use that retained number to display anything. See bug 38395 for that.
Thanks Andrew for this information! Since it changes nothing in the interface and/or usability, there is nothing to change in the manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33153 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org