[Bug 38127] New: Missing column headings in 'Add user' pop-up modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38127 Bug ID: 38127 Summary: Missing column headings in 'Add user' pop-up modal Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org In the 'Add user' pop-up modal, the column headings in the results are missing. To get there (with ktd data): 1. Go to Acquisitions 2. Click 'Search' to find 'My vendor' 3. Click 'My basket' 4. Click 'Add to basket' 5. Click 'From a new (empty) record' 6. Click 'Add user' 7. Search for 'alford' (for example) --> Note that there aren't any column headings in the results Compare with: 1. Go to Tools > Patron card creator 2. Click 'New' > 'Card batch' 3. Click 'Add patron(s)' 4. Search for 'alford' (for example) --> Note that there are column headings in this pop-up I get that they are different modals (Add user vs Add patrons), but I just wanted to highlight the column headings. I found this while documenting Bug 35329, but I'm not sure if it's related directly to that one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38127 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35329 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 [Bug 35329] Move patron searches to a modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38127 Bug 38127 depends on bug 35329, which changed state. Bug 35329 Summary: Move patron searches to a modal https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38127 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38127 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38127 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 182561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182561&action=edit Bug 38127: Missing column headings in 'Add user' pop-up modal This patch modifies the template for adding to a basket from a new (empty) record in order to make the "Add user" patron search results correct. The patron search results table headers must be defined in the template before they are used. To test, apply the patch and go to Acquisitions. - Search for a vendor. - Add or create a basket for that vendor. - Click "Add to basket" and select "From a new (empty) record." - In the "New order" form, under the "Patrons" heading, click "Add user" - Search for patrons to add. - In the patron search results, each column should have a heading: Card, Name, Category, Library. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38127 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38127 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182561|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 182562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182562&action=edit Bug 38127: Missing column headings in 'Add user' pop-up modal This patch modifies the template for adding to a basket from a new (empty) record in order to make the "Add user" patron search results correct. The patron search results table headers must be defined in the template before they are used. To test, apply the patch and go to Acquisitions. - Search for a vendor. - Add or create a basket for that vendor. - Click "Add to basket" and select "From a new (empty) record." - In the "New order" form, under the "Patrons" heading, click "Add user" - Search for patrons to add. - In the patron search results, each column should have a heading: Card, Name, Category, Library. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38127 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the "Add user" release notes| |pop-up window when adding a | |user to a new order in | |acquisitions. The table now | |shows the column headings, | |such as card, name, | |category, and library. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38127 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182562|0 |1 is obsolete| | --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 182770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182770&action=edit Bug 38127: Missing column headings in 'Add user' pop-up modal This patch modifies the template for adding to a basket from a new (empty) record in order to make the "Add user" patron search results correct. The patron search results table headers must be defined in the template before they are used. To test, apply the patch and go to Acquisitions. - Search for a vendor. - Add or create a basket for that vendor. - Click "Add to basket" and select "From a new (empty) record." - In the "New order" form, under the "Patrons" heading, click "Add user" - Search for patrons to add. - In the patron search results, each column should have a heading: Card, Name, Category, Library. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38127 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38127 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38127 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38127 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|25.11.00 |25.11.00,25.05.01 released in| | Status|Pushed to main |Pushed to stable --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- I see in 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38127 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|25.11.00,25.05.01 |25.11.00,25.05.01,24.11.06 released in| | --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38127 --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x for 25.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38127 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #8 from Jesse Maseto <jesse@bywatersolutions.com> --- This will be pushed to 24.05.x for 24.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38127 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldoldstable |Needs documenting --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org