[Bug 31000] New: Use of uninitialized value $record_type in string eq
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000 Bug ID: 31000 Summary: Use of uninitialized value $record_type in string eq Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Tools Assignee: slavashishkin@gmail.com Reporter: slavashishkin@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000 --- Comment #1 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 136388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136388&action=edit Bug 31000: HOTFIX. Warn removal: param record_type can be undef Use of uninitialized value $record_type in string eq at .../tools/export.pl line 43. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136388|0 |1 is obsolete| | --- Comment #2 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 136389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136389&action=edit Bug 31000: HOTFIX. Warn removal: param record_type can be undef Uninitialized value warning on /tools/export.pl when $record_type is undef Use of uninitialized value $record_type in string eq at /home/vagrant/kohaclone/tools/export.pl line 43. This patch fixes it by working when $record_type is Undef. The functionality still remains the same but warning doesn't flood error log. To reproduce: 1. Go to export data tool page (/tools/export.pl). 2. Check the error log and find the upper mentioned warning, check the timestamp to ensure that it was added when you loaded the page. 3. Apply the patch. 4. Load the page again, ensure that the same warning doesn't get added to the log file again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25790 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Slava, should this be 'needs sign-off'? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #4 from Slava Shishkin <slavashishkin@gmail.com> --- Hi Katrin, yep, my bad. It should this be 'needs sign-off'. Thanks :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136389|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 136557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136557&action=edit Bug 31000: HOTFIX. Warn removal: param record_type can be undef Uninitialized value warning on /tools/export.pl when $record_type is undef Use of uninitialized value $record_type in string eq at /home/vagrant/kohaclone/tools/export.pl line 43. This patch fixes it by working when $record_type is Undef. The functionality still remains the same but warning doesn't flood error log. To reproduce: 1. Go to export data tool page (/tools/export.pl). 2. Check the error log and find the upper mentioned warning, check the timestamp to ensure that it was added when you loaded the page. 3. Apply the patch. 4. Load the page again, ensure that the same warning doesn't get added to the log file again. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the cause of an release notes| |error message that appears | |in the system logs every | |time that Tools > Catalog > | |Export data | |(/cgi-bin/koha/tools/export | |.pl) is accessed. The error | |message was "AH01215: Use | |of uninitialized value | |$record_type in string eq | |at /koh | |adevbox/koha/tools/export.p | |l line 43.: | |/kohadevbox/koha/tools/expo | |rt.pl,...". CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- Testing notes (using koha-testing-docker): - The error message appears in this log file: /var/log/koha/kohadev/intranet-error.log -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136557|0 |1 is obsolete| | --- Comment #7 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 136568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136568&action=edit Bug 31000: HOTFIX. Warn removal: param record_type can be undef Uninitialized value warning on /tools/export.pl when $record_type is undef Use of uninitialized value $record_type in string eq at /home/vagrant/kohaclone/tools/export.pl line 43. This warning in koha-testing-docker appears in: /var/log/koha/kohadev/intranet-error.log This patch fixes it by working when $record_type is Undef. The functionality still remains the same but warning doesn't flood error log. To reproduce: 1. Go to export data tool page (/tools/export.pl). 2. Check the error log and find the upper mentioned warning, check the timestamp to ensure that it was added when you loaded the page. 3. Apply the patch. 4. Load the page again, ensure that the same warning doesn't get added to the log file again. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000 --- Comment #8 from Slava Shishkin <slavashishkin@gmail.com> --- David, thanks for the note. I added it to the patch description. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000 --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 137459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137459&action=edit Bug 31000: Warn removal: param record_type can be undef Uninitialized value warning on /tools/export.pl when $record_type is undef Use of uninitialized value $record_type in string eq at /home/vagrant/kohaclone/tools/export.pl line 43. This warning in koha-testing-docker appears in: /var/log/koha/kohadev/intranet-error.log This patch fixes it by working when $record_type is Undef. The functionality still remains the same but warning doesn't flood error log. To reproduce: 1. Go to export data tool page (/tools/export.pl). 2. Check the error log and find the upper mentioned warning, check the timestamp to ensure that it was added when you loaded the page. 3. Apply the patch. 4. Load the page again, ensure that the same warning doesn't get added to the log file again. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Attachment #136568|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Version(s)| |This fixes the cause of an released in| |error message that appears | |in the system logs every | |time that Tools > Catalog > | |Export data | |(/cgi-bin/koha/tools/export | |.pl) is accessed. The error | |message was "AH01215: Use | |of uninitialized value | |$record_type in string eq | |at /koh | |adevbox/koha/tools/export.p | |l line 43.: | |/kohadevbox/koha/tools/expo | |rt.pl,...". QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Removed "HOTFIX" from commit message. qa script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Version(s)|This fixes the cause of an | released in|error message that appears | |in the system logs every | |time that Tools > Catalog > | |Export data | |(/cgi-bin/koha/tools/export | |.pl) is accessed. The error | |message was "AH01215: Use | |of uninitialized value | |$record_type in string eq | |at /koh | |adevbox/koha/tools/export.p | |l line 43.: | |/kohadevbox/koha/tools/expo | |rt.pl,...". | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000 --- Comment #11 from Slava Shishkin <slavashishkin@gmail.com> --- Thanks, Victor! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes the cause of an |This fixes the cause of an release notes|error message that appears |error message that appears |in the system logs every |in the system logs every |time that Tools > Catalog > |time that Tools > Catalog > |Export data |Export data |(/cgi-bin/koha/tools/export |(/cgi-bin/koha/tools/export |.pl) is accessed. The error |.pl) is accessed. The error |message was "AH01215: Use |message was "AH01215: Use |of uninitialized value |of uninitialized value |$record_type in string eq |$record_type in string eq |at /koh |at |adevbox/koha/tools/export.p |/kohadevbox/koha/tools/expo |l line 43.: |rt.pl line 43.: |/kohadevbox/koha/tools/expo |/kohadevbox/koha/tools/expo |rt.pl,...". |rt.pl,...". -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org