https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38489 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187931|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 187932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187932&action=edit Bug 41020: Add ability to delete files to Koha::File::Transport and derived classes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #4 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 187934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187934&action=edit Bug 41020: Update schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187932|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 187935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187935&action=edit Bug 41020: Add ability to delete files to Koha::File::Transport and derived classes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187933|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 187937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187937&action=edit Bug 41020: Add ability to use file transports for marc ordering accounts FTP and SFTP server management was added to Koha in bug 39190. This feature should be made available to the marc order accounts feature so external processes are not needed to downloading the marc order files. Test Plan: 1) Run updatedatabase.pl 2) Restart all the things! 3) Create one or more file transports 4) Attach those transports to one or more MARC order accounts 5) Run marc_order_accounts.tt, note the files are transferred from the remove server to the "Download directory" of the MARC order account 6) Add another file to the remote server 7) Run script with "--rr dl" 8) Note the remote file has ".dl" append to the filename 9) Remove the .dl file extension from the remote file 10) Run script with "--dr" 11) Note the remote file is deleted -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187936|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 187939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187939&action=edit Bug 41020: Add ability to delete files to Koha::File::Transport and derived classes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187937|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 187941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187941&action=edit Bug 41020: Add ability to use file transports for marc ordering accounts FTP and SFTP server management was added to Koha in bug 39190. This feature should be made available to the marc order accounts feature so external processes are not needed to downloading the marc order files. Test Plan: 1) Run updatedatabase.pl 2) Restart all the things! 3) Create one or more file transports 4) Attach those transports to one or more MARC order accounts 5) Run marc_order_accounts.tt, note the files are transferred from the remove server to the "Download directory" of the MARC order account 6) Add another file to the remote server 7) Run script with "--rr dl" 8) Note the remote file has ".dl" append to the filename 9) Remove the .dl file extension from the remote file 10) Run script with "--dr" 11) Note the remote file is deleted -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #14 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 188012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188012&action=edit Bug 41020: Add ability to use file transports for marc ordering accounts FTP and SFTP server management was added to Koha in bug 39190. This feature should be made available to the marc order accounts feature so external processes are not needed to downloading the marc order files. Test Plan: 1) Run updatedatabase.pl 2) Restart all the things! 3) Create one or more file transports 4) Attach those transports to one or more MARC order accounts 5) Run marc_order_accounts.tt, note the files are transferred from the remove server to the "Download directory" of the MARC order account 6) Add another file to the remote server 7) Run script with "--rr dl" 8) Note the remote file has ".dl" append to the filename 9) Remove the .dl file extension from the remote file 10) Run script with "--dr" 11) Note the remote file is deleted Signed-off-by: John Doe <you@example.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #16 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 188014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188014&action=edit Bug 41020: Add ability to use file transports for marc ordering accounts FTP and SFTP server management was added to Koha in bug 39190. This feature should be made available to the marc order accounts feature so external processes are not needed to downloading the marc order files. Test Plan: 1) Run updatedatabase.pl 2) Restart all the things! 3) Create one or more file transports 4) Attach those transports to one or more MARC order accounts 5) Run marc_order_accounts.tt, note the files are transferred from the remove server to the "Download directory" of the MARC order account 6) Add another file to the remote server 7) Run script with "--rr dl" 8) Note the remote file has ".dl" append to the filename 9) Remove the .dl file extension from the remote file 10) Run script with "--dr" 11) Note the remote file is deleted Signed-off-by: John Doe <you@example.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #18 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 188016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188016&action=edit Bug 41020: Update FTP.pm _abort_operation prototype to match SFTP.pm Signed-off-by: John Doe <you@example.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #20 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 188018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188018&action=edit Bug 41020: Update schema files [DO NOT PUSH] Signed-off-by: John Doe <you@example.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187940|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187942|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188013|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188015|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #22 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 188030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188030&action=edit Bug 41020: Add ability to delete files to Koha::File::Transport and derived classes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188016|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 188032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188032&action=edit Bug 41020: Update FTP.pm _abort_operation prototype to match SFTP.pm Signed-off-by: John Doe <you@example.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188018|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 188034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188034&action=edit Bug 41020: Update schema files [DO NOT PUSH] Signed-off-by: John Doe <you@example.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #27 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188146&action=edit Bug 41020: Add delete_file() method to file transport classes This patch adds the ability to delete files from remote servers through the file transport API. This is needed for the MARC ordering feature to clean up processed files from FTP/SFTP servers. Changes: - Added abstract delete_file() method to Koha::File::Transport base class - Implemented delete_file() in Koha::File::Transport::FTP using Net::FTP->delete() - Implemented delete_file() in Koha::File::Transport::SFTP using Net::SFTP::Foreign->remove() - Implemented delete_file() in Koha::File::Transport::Local using unlink() - All implementations follow the standard message/error handling pattern - Updated polymorphic tests to verify delete_file() capability The delete_file() method: - Takes a filename as parameter (relative to current directory) - Returns true on success, undef on failure - Adds appropriate success/error messages to the transport message queue - Follows the same pattern as existing methods (download_file, rename_file) Test plan: 1. prove t/db_dependent/Koha/File/Transports.t 2. Verify all transport types support delete_file() 3. Test with MARC ordering cronjob using --dr flag (added in main patch) Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188033|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188148&action=edit Bug 41020: Add ability to use file transports for marc ordering accounts FTP and SFTP server management was added to Koha in bug 39190. This feature should be made available to the marc order accounts feature so external processes are not needed to downloading the marc order files. Test Plan: 1) Run updatedatabase.pl 2) Restart all the things! 3) Create one or more file transports 4) Attach those transports to one or more MARC order accounts 5) Run marc_order_accounts.tt, note the files are transferred from the remove server to the "Download directory" of the MARC order account 6) Add another file to the remote server 7) Run script with "--rr dl" 8) Note the remote file has ".dl" append to the filename 9) Remove the .dl file extension from the remote file 10) Run script with "--dr" 11) Note the remote file is deleted Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #31 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188150&action=edit Bug 41020: (follow-up) Modernize code to use Koha objects and relationship accessors This follow-up improves the code to better follow Koha best practices: 1. Added file_transport() relationship accessor to Koha::MarcOrderAccount - Returns the correct polymorphic subclass (SFTP, FTP, or Local) - Respects prefetched relationships to avoid N+1 queries - Follows the same pattern as vendor() and budget() accessors 2. Updated admin/marc_order_accounts.pl to use Koha::File::Transports - Replaced direct DBIx::Class schema access with Koha objects - Removed unused $schema variable 3. Updated misc/cronjobs/marc_ordering_process.pl - Changed manual transport lookup to use the new relationship accessor - Cleaner code that can benefit from prefetching 4. Added unit tests (t/db_dependent/Koha/MarcOrderAccount.t) - Tests for all relationship accessors (vendor, budget, file_transport) - Verifies polymorphism works correctly for all transport types - Includes test demonstrating that prefetched relationships don't trigger additional database queries Test plan: 1. prove t/db_dependent/Koha/MarcOrderAccount.t 2. Verify all tests pass 3. Run marc_ordering_process.pl cronjob and verify it still works Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188032|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188146|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188153&action=edit Bug 41020: Add delete_file() method to file transport classes This patch adds the ability to delete files from remote servers through the file transport API. This is needed for the MARC ordering feature to clean up processed files from FTP/SFTP servers. Changes: - Added abstract delete_file() method to Koha::File::Transport base class - Implemented delete_file() in Koha::File::Transport::FTP using Net::FTP->delete() - Implemented delete_file() in Koha::File::Transport::SFTP using Net::SFTP::Foreign->remove() - Implemented delete_file() in Koha::File::Transport::Local using unlink() - All implementations follow the standard message/error handling pattern - Updated polymorphic tests to verify delete_file() capability The delete_file() method: - Takes a filename as parameter (relative to current directory) - Returns true on success, undef on failure - Adds appropriate success/error messages to the transport message queue - Follows the same pattern as existing methods (download_file, rename_file) Test plan: 1. prove t/db_dependent/Koha/File/Transports.t 2. Verify all transport types support delete_file() 3. Test with MARC ordering cronjob using --dr flag (added in main patch) Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188148|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188155&action=edit Bug 41020: Add ability to use file transports for marc ordering accounts FTP and SFTP server management was added to Koha in bug 39190. This feature should be made available to the marc order accounts feature so external processes are not needed to downloading the marc order files. Test Plan: 1) Run updatedatabase.pl 2) Restart all the things! 3) Create one or more file transports 4) Attach those transports to one or more MARC order accounts 5) Run marc_order_accounts.tt, note the files are transferred from the remove server to the "Download directory" of the MARC order account 6) Add another file to the remote server 7) Run script with "--rr dl" 8) Note the remote file has ".dl" append to the filename 9) Remove the .dl file extension from the remote file 10) Run script with "--dr" 11) Note the remote file is deleted Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188150|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188157&action=edit Bug 41020: (follow-up) Modernize code to use Koha objects and relationship accessors This follow-up improves the code to better follow Koha best practices: 1. Added file_transport() relationship accessor to Koha::MarcOrderAccount - Returns the correct polymorphic subclass (SFTP, FTP, or Local) - Respects prefetched relationships to avoid N+1 queries - Follows the same pattern as vendor() and budget() accessors 2. Updated admin/marc_order_accounts.pl to use Koha::File::Transports - Replaced direct DBIx::Class schema access with Koha objects - Removed unused $schema variable 3. Updated misc/cronjobs/marc_ordering_process.pl - Changed manual transport lookup to use the new relationship accessor - Cleaner code that can benefit from prefetching 4. Added unit tests (t/db_dependent/Koha/MarcOrderAccount.t) - Tests for all relationship accessors (vendor, budget, file_transport) - Verifies polymorphism works correctly for all transport types - Includes test demonstrating that prefetched relationships don't trigger additional database queries Test plan: 1. prove t/db_dependent/Koha/MarcOrderAccount.t 2. Verify all tests pass 3. Run marc_ordering_process.pl cronjob and verify it still works Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability to use file |Add ability to use file |transports for marc |transports for MARC |ordering accounts |ordering accounts -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #38 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 195487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195487&action=edit Bug 41020: (QA follow-up) Use say_success Patch from commit f6b3971 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195488|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #41 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 195493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195493&action=edit Bug 41020: (QA follow-up) Check permission, fix EDI => Marc order account Patch from commit 520e904 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188153|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188155|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188157|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195493|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #43 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 195511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195511&action=edit Bug 41020: Standardize _abort_operation() signature in FTP transport This patch updates Koha::File::Transport::FTP::_abort_operation() to accept an optional $path parameter, matching the signature used in Koha::File::Transport::SFTP. This improves error reporting by including the path/file that caused the operation to fail in the error message payload. Previously, the FTP implementation only included the error detail and message, making it harder to debug which file or directory caused the problem. Changes: - Updated _abort_operation($operation) to _abort_operation($operation, $path) - Updated change_directory() call to pass $remote_directory to _abort_operation - Added path to error payload, using either the passed path or pwd() as fallback This standardization ensures consistent error reporting across all transport implementations and makes debugging transport issues easier. Test plan: 1. Verify FTP transport operations still work correctly 2. Check that error messages now include the path that failed 3. Confirm no regressions in existing FTP functionality Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #45 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 195513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195513&action=edit Bug 41020: Update schema files [DO NOT PUSH] Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #47 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 195515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195515&action=edit Bug 41020: (QA follow-up) Use say_success Patch from commit 2ce7cac -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #49 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 195517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195517&action=edit Bug 41020: (QA follow-up) Fix FTP crash and guard remote ops with --confirm _abort_operation() crashed when both $path and $self->{connection} were undef (e.g. on a failed Net::FTP->new call), because the fallback expression called ->pwd on undef. Remote file transport operations (connect, download, delete/rename on remote) were not guarded by the --confirm flag, causing them to run in dry-run mode. All transport operations now require --confirm. Error/ failure messages from the transport block now also respect --verbose. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #51 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 195519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195519&action=edit Bug 41020: (QA follow-up) Fix POD errors in marc_ordering_process.pl - Fix unbalanced bracket in SYNOPSIS: [--rr|--rename-remote ext] - Fix item name typo: rename-remove => rename-remote, -rr => --rr - Update DESCRIPTION to mention local/FTP/SFTP transports, fix typo 'bilbios' => 'bibliographic records' -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #53 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 195521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195521&action=edit Bug 41020: (QA follow-up) Fix same _abort_operation crash in SFTP transport Same fix as applied to FTP: guard the ->cwd fallback with a connection check so that a missing $path argument doesn't crash when $connection is undef. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195511|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195513|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195515|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195517|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195519|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195521|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #55 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 195527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195527&action=edit Bug 41020: Standardize _abort_operation() signature in FTP transport This patch updates Koha::File::Transport::FTP::_abort_operation() to accept an optional $path parameter, matching the signature used in Koha::File::Transport::SFTP. This improves error reporting by including the path/file that caused the operation to fail in the error message payload. Previously, the FTP implementation only included the error detail and message, making it harder to debug which file or directory caused the problem. Changes: - Updated _abort_operation($operation) to _abort_operation($operation, $path) - Updated change_directory() call to pass $remote_directory to _abort_operation - Added path to error payload, using either the passed path or pwd() as fallback This standardization ensures consistent error reporting across all transport implementations and makes debugging transport issues easier. Test plan: 1. Verify FTP transport operations still work correctly 2. Check that error messages now include the path that failed 3. Confirm no regressions in existing FTP functionality Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #57 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 195529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195529&action=edit Bug 41020: Update schema files [DO NOT PUSH] Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #59 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 195531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195531&action=edit Bug 41020: (QA follow-up) Use say_success Patch from commit 2ce7cac -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #61 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 195533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195533&action=edit Bug 41020: (QA follow-up) Fix FTP crash and guard remote ops with --confirm _abort_operation() crashed when both $path and $self->{connection} were undef (e.g. on a failed Net::FTP->new call), because the fallback expression called ->pwd on undef. Remote file transport operations (connect, download, delete/rename on remote) were not guarded by the --confirm flag, causing them to run in dry-run mode. All transport operations now require --confirm. Error/ failure messages from the transport block now also respect --verbose. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #63 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 195535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195535&action=edit Bug 41020: (QA follow-up) Fix POD errors in marc_ordering_process.pl - Fix unbalanced bracket in SYNOPSIS: [--rr|--rename-remote ext] - Fix item name typo: rename-remove => rename-remote, -rr => --rr - Update DESCRIPTION to mention local/FTP/SFTP transports, fix typo 'bilbios' => 'bibliographic records' -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #65 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 195537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195537&action=edit Bug 41020: (QA follow-up) Fix same _abort_operation crash in SFTP transport Same fix as applied to FTP: guard the ->cwd fallback with a connection check so that a missing $path argument doesn't crash when $connection is undef. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195527|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195529|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195531|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195533|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195535|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195537|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #67 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 199180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199180&action=edit Bug 41020: Standardize _abort_operation() signature in FTP transport This patch updates Koha::File::Transport::FTP::_abort_operation() to accept an optional $path parameter, matching the signature used in Koha::File::Transport::SFTP. This improves error reporting by including the path/file that caused the operation to fail in the error message payload. Previously, the FTP implementation only included the error detail and message, making it harder to debug which file or directory caused the problem. Changes: - Updated _abort_operation($operation) to _abort_operation($operation, $path) - Updated change_directory() call to pass $remote_directory to _abort_operation - Added path to error payload, using either the passed path or pwd() as fallback This standardization ensures consistent error reporting across all transport implementations and makes debugging transport issues easier. Test plan: 1. Verify FTP transport operations still work correctly 2. Check that error messages now include the path that failed 3. Confirm no regressions in existing FTP functionality Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #69 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 199182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199182&action=edit Bug 41020: Update schema files [DO NOT PUSH] Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #71 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 199184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199184&action=edit Bug 41020: (QA follow-up) Use say_success Patch from commit 0d22fca -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #73 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 199186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199186&action=edit Bug 41020: (QA follow-up) Fix FTP crash and guard remote ops with --confirm _abort_operation() crashed when both $path and $self->{connection} were undef (e.g. on a failed Net::FTP->new call), because the fallback expression called ->pwd on undef. Remote file transport operations (connect, download, delete/rename on remote) were not guarded by the --confirm flag, causing them to run in dry-run mode. All transport operations now require --confirm. Error/ failure messages from the transport block now also respect --verbose. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #75 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 199188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199188&action=edit Bug 41020: (QA follow-up) Fix POD errors in marc_ordering_process.pl - Fix unbalanced bracket in SYNOPSIS: [--rr|--rename-remote ext] - Fix item name typo: rename-remove => rename-remote, -rr => --rr - Update DESCRIPTION to mention local/FTP/SFTP transports, fix typo 'bilbios' => 'bibliographic records' -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #77 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 199190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199190&action=edit Bug 41020: (QA follow-up) Fix same _abort_operation crash in SFTP transport Same fix as applied to FTP: guard the ->cwd fallback with a connection check so that a missing $path argument doesn't crash when $connection is undef. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199179|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199181|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199183|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199185|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199187|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199189|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #79 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 200222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200222&action=edit Bug 41020: Add delete_file() method to file transport classes This patch adds the ability to delete files from remote servers through the file transport API. This is needed for the MARC ordering feature to clean up processed files from FTP/SFTP servers. Changes: - Added abstract delete_file() method to Koha::File::Transport base class - Implemented delete_file() in Koha::File::Transport::FTP using Net::FTP->delete() - Implemented delete_file() in Koha::File::Transport::SFTP using Net::SFTP::Foreign->remove() - Implemented delete_file() in Koha::File::Transport::Local using unlink() - All implementations follow the standard message/error handling pattern - Updated polymorphic tests to verify delete_file() capability The delete_file() method: - Takes a filename as parameter (relative to current directory) - Returns true on success, undef on failure - Adds appropriate success/error messages to the transport message queue - Follows the same pattern as existing methods (download_file, rename_file) Test plan: 1. prove t/db_dependent/Koha/File/Transports.t 2. Verify all transport types support delete_file() 3. Test with MARC ordering cronjob using --dr flag (added in main patch) Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #81 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 200224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200224&action=edit Bug 41020: Add ability to use file transports for marc ordering accounts FTP and SFTP server management was added to Koha in bug 39190. This feature should be made available to the marc order accounts feature so external processes are not needed to downloading the marc order files. Test Plan: 1) Run updatedatabase.pl 2) Restart all the things! 3) Create one or more file transports 4) Attach those transports to one or more MARC order accounts 5) Run marc_order_accounts.tt, note the files are transferred from the remove server to the "Download directory" of the MARC order account 6) Add another file to the remote server 7) Run script with "--rr dl" 8) Note the remote file has ".dl" append to the filename 9) Remove the .dl file extension from the remote file 10) Run script with "--dr" 11) Note the remote file is deleted Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #83 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 200226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200226&action=edit Bug 41020: (follow-up) Modernize code to use Koha objects and relationship accessors This follow-up improves the code to better follow Koha best practices: 1. Added file_transport() relationship accessor to Koha::MarcOrderAccount - Returns the correct polymorphic subclass (SFTP, FTP, or Local) - Respects prefetched relationships to avoid N+1 queries - Follows the same pattern as vendor() and budget() accessors 2. Updated admin/marc_order_accounts.pl to use Koha::File::Transports - Replaced direct DBIx::Class schema access with Koha objects - Removed unused $schema variable 3. Updated misc/cronjobs/marc_ordering_process.pl - Changed manual transport lookup to use the new relationship accessor - Cleaner code that can benefit from prefetching 4. Added unit tests (t/db_dependent/Koha/MarcOrderAccount.t) - Tests for all relationship accessors (vendor, budget, file_transport) - Verifies polymorphism works correctly for all transport types - Includes test demonstrating that prefetched relationships don't trigger additional database queries Test plan: 1. prove t/db_dependent/Koha/MarcOrderAccount.t 2. Verify all tests pass 3. Run marc_ordering_process.pl cronjob and verify it still works Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #85 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 200228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200228&action=edit Bug 41020: (QA follow-up) Check permission, fix EDI => Marc order account Patch from commit c0f0e76 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #87 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 200230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200230&action=edit Bug 41020: (QA follow-up) Fix kohastructure.sql for file_transport_id column Add missing explicit KEY index for file_transport_id, consistent with the style used for vendor_edi_accounts. Add missing COMMENT annotation for the new column, consistent with all other columns in the table. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #89 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 200232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200232&action=edit Bug 41020: (QA follow-up) Call object_class() as a class method object_class(), _polymorphic_field() and _polymorphic_map() use no instance state, so there is no need to instantiate Koha::File::Transports just to call object_class(). Call it directly as a class method. Also update the pod to mention Local transport alongside SFTP/FTP. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200222|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200224|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200226|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200228|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200230|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200232|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #91 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 200249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200249&action=edit Bug 41020: Add delete_file() method to file transport classes This patch adds the ability to delete files from remote servers through the file transport API. This is needed for the MARC ordering feature to clean up processed files from FTP/SFTP servers. Changes: - Added abstract delete_file() method to Koha::File::Transport base class - Implemented delete_file() in Koha::File::Transport::FTP using Net::FTP->delete() - Implemented delete_file() in Koha::File::Transport::SFTP using Net::SFTP::Foreign->remove() - Implemented delete_file() in Koha::File::Transport::Local using unlink() - All implementations follow the standard message/error handling pattern - Updated polymorphic tests to verify delete_file() capability The delete_file() method: - Takes a filename as parameter (relative to current directory) - Returns true on success, undef on failure - Adds appropriate success/error messages to the transport message queue - Follows the same pattern as existing methods (download_file, rename_file) Test plan: 1. prove t/db_dependent/Koha/File/Transports.t 2. Verify all transport types support delete_file() 3. Test with MARC ordering cronjob using --dr flag (added in main patch) Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #93 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 200251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200251&action=edit Bug 41020: Add ability to use file transports for marc ordering accounts FTP and SFTP server management was added to Koha in bug 39190. This feature should be made available to the marc order accounts feature so external processes are not needed to downloading the marc order files. Test Plan: 1) Run updatedatabase.pl 2) Restart all the things! 3) Create one or more file transports 4) Attach those transports to one or more MARC order accounts 5) Run marc_order_accounts.tt, note the files are transferred from the remove server to the "Download directory" of the MARC order account 6) Add another file to the remote server 7) Run script with "--rr dl" 8) Note the remote file has ".dl" append to the filename 9) Remove the .dl file extension from the remote file 10) Run script with "--dr" 11) Note the remote file is deleted Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #95 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 200253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200253&action=edit Bug 41020: (follow-up) Modernize code to use Koha objects and relationship accessors This follow-up improves the code to better follow Koha best practices: 1. Added file_transport() relationship accessor to Koha::MarcOrderAccount - Returns the correct polymorphic subclass (SFTP, FTP, or Local) - Respects prefetched relationships to avoid N+1 queries - Follows the same pattern as vendor() and budget() accessors 2. Updated admin/marc_order_accounts.pl to use Koha::File::Transports - Replaced direct DBIx::Class schema access with Koha objects - Removed unused $schema variable 3. Updated misc/cronjobs/marc_ordering_process.pl - Changed manual transport lookup to use the new relationship accessor - Cleaner code that can benefit from prefetching 4. Added unit tests (t/db_dependent/Koha/MarcOrderAccount.t) - Tests for all relationship accessors (vendor, budget, file_transport) - Verifies polymorphism works correctly for all transport types - Includes test demonstrating that prefetched relationships don't trigger additional database queries Test plan: 1. prove t/db_dependent/Koha/MarcOrderAccount.t 2. Verify all tests pass 3. Run marc_ordering_process.pl cronjob and verify it still works Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #97 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 200255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200255&action=edit Bug 41020: (QA follow-up) Check permission, fix EDI => Marc order account Patch from commit 3a38c8e -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #99 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 200257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200257&action=edit Bug 41020: (QA follow-up) Fix kohastructure.sql for file_transport_id column Add missing explicit KEY index for file_transport_id, consistent with the style used for vendor_edi_accounts. Add missing COMMENT annotation for the new column, consistent with all other columns in the table. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #101 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 200259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200259&action=edit Bug 41020: (QA follow-up) Call object_class() as a class method object_class(), _polymorphic_field() and _polymorphic_map() use no instance state, so there is no need to instantiate Koha::File::Transports just to call object_class(). Call it directly as a class method. Also update the pod to mention Local transport alongside SFTP/FTP. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #103 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Fixed some John Doe author lines! No other changes to the patches. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #104 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 200273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200273&action=edit Bug 41020: Add delete_file() method to file transport classes This patch adds the ability to delete files from remote servers through the file transport API. This is needed for the MARC ordering feature to clean up processed files from FTP/SFTP servers. Changes: - Added abstract delete_file() method to Koha::File::Transport base class - Implemented delete_file() in Koha::File::Transport::FTP using Net::FTP->delete() - Implemented delete_file() in Koha::File::Transport::SFTP using Net::SFTP::Foreign->remove() - Implemented delete_file() in Koha::File::Transport::Local using unlink() - All implementations follow the standard message/error handling pattern - Updated polymorphic tests to verify delete_file() capability The delete_file() method: - Takes a filename as parameter (relative to current directory) - Returns true on success, undef on failure - Adds appropriate success/error messages to the transport message queue - Follows the same pattern as existing methods (download_file, rename_file) Test plan: 1. prove t/db_dependent/Koha/File/Transports.t 2. Verify all transport types support delete_file() 3. Test with MARC ordering cronjob using --dr flag (added in main patch) Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #106 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 200275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200275&action=edit Bug 41020: Add ability to use file transports for marc ordering accounts FTP and SFTP server management was added to Koha in bug 39190. This feature should be made available to the marc order accounts feature so external processes are not needed to downloading the marc order files. Test Plan: 1) Run updatedatabase.pl 2) Restart all the things! 3) Create one or more file transports 4) Attach those transports to one or more MARC order accounts 5) Run marc_order_accounts.tt, note the files are transferred from the remove server to the "Download directory" of the MARC order account 6) Add another file to the remote server 7) Run script with "--rr dl" 8) Note the remote file has ".dl" append to the filename 9) Remove the .dl file extension from the remote file 10) Run script with "--dr" 11) Note the remote file is deleted Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #108 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 200277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200277&action=edit Bug 41020: (follow-up) Modernize code to use Koha objects and relationship accessors This follow-up improves the code to better follow Koha best practices: 1. Added file_transport() relationship accessor to Koha::MarcOrderAccount - Returns the correct polymorphic subclass (SFTP, FTP, or Local) - Respects prefetched relationships to avoid N+1 queries - Follows the same pattern as vendor() and budget() accessors 2. Updated admin/marc_order_accounts.pl to use Koha::File::Transports - Replaced direct DBIx::Class schema access with Koha objects - Removed unused $schema variable 3. Updated misc/cronjobs/marc_ordering_process.pl - Changed manual transport lookup to use the new relationship accessor - Cleaner code that can benefit from prefetching 4. Added unit tests (t/db_dependent/Koha/MarcOrderAccount.t) - Tests for all relationship accessors (vendor, budget, file_transport) - Verifies polymorphism works correctly for all transport types - Includes test demonstrating that prefetched relationships don't trigger additional database queries Test plan: 1. prove t/db_dependent/Koha/MarcOrderAccount.t 2. Verify all tests pass 3. Run marc_ordering_process.pl cronjob and verify it still works Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #110 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 200281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200281&action=edit Bug 41020: (QA follow-up) Check permission, fix EDI => Marc order account -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #112 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 200283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200283&action=edit Bug 41020: (QA follow-up) Fix kohastructure.sql for file_transport_id column Add missing explicit KEY index for file_transport_id, consistent with the style used for vendor_edi_accounts. Add missing COMMENT annotation for the new column, consistent with all other columns in the table. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #114 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 200285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200285&action=edit Bug 41020: (QA follow-up) Call object_class() as a class method object_class(), _polymorphic_field() and _polymorphic_map() use no instance state, so there is no need to instantiate Koha::File::Transports just to call object_class(). Call it directly as a class method. Also update the pod to mention Local transport alongside SFTP/FTP. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 --- Comment #116 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 200287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200287&action=edit Bug 41020: (QA follow-up) Fix error handling in transport and cronjob - Guard object_class() result in Koha::MarcOrderAccount::file_transport() to avoid crashing on undef if the transport type is unrecognised - Check return value of rename_file() and delete_file() in the cronjob transport block so failures are reported rather than silently ignored - Drop 'if $verbose' guard on the download-failure message so transport errors are always visible in --confirm cron runs - Include the actual path and $! in the opendir die message to aid debugging of misconfigured download directories -- You are receiving this mail because: You are watching all bug changes.