http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10125 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7500 Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10125 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10125 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 19381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19381&action=edit Bug 10125 - Babeltheque star image must use sprite When I removed images from the OPAC in favor of sprites I didn't take into account the display of star ratings from Babeltheque. This patch copies the star ratings display from Koha's own ratings display, though it is not dependent on JavaScript. I'm sure testing would be easy for someone with access to the Babeltheque service, but I do not. I temporarily modified the template to set some variables for testing purposes: [% SET SEARCH_RESULT.score_int = 3 %] [% SET SEARCH_RESULT.score_avg = 3 % [% SET SEARCH_RESULT.num_scores = 87 %] This enabled the display of the ratings, allowing me to confirm that stars display correctly. Ratings should work with and without OpacStarRatings enabled. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10125 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19381|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 19451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19451&action=edit Bug 10125 - Babeltheque star image must use sprite When I removed images from the OPAC in favor of sprites I didn't take into account the display of star ratings from Babeltheque. This patch copies the star ratings display from Koha's own ratings display, though it is not dependent on JavaScript. I'm sure testing would be easy for someone with access to the Babeltheque service, but I do not. I temporarily modified the template to set some variables for testing purposes: [% SET SEARCH_RESULT.score_int = 3 %] [% SET SEARCH_RESULT.score_avg = 3 % [% SET SEARCH_RESULT.num_scores = 87 %] This enabled the display of the ratings, allowing me to confirm that stars display correctly. Ratings should work with and without OpacStarRatings enabled. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> I also fudged the template to test, so QA would need to be done with someone with Babeltheque access -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10125 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comment: This patch supposes that the Babeltheque ratings depends on OpacStarRatings. It is false. I will provide a followup. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10125 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 19468 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19468&action=edit Bug 10125: Babeltheque does not depend on OpacStarRatings. We have to load star ratings js and css file if Babeltheque is enabled and OpacStarRatings is disabled. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10125 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks Owen and Jonathan! -- You are receiving this mail because: You are watching all bug changes.