[Bug 20564] New: Error 500 displays when uploading patron images with a zipped file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 Bug ID: 20564 Summary: Error 500 displays when uploading patron images with a zipped file Change sponsored?: --- Product: Koha Version: 17.11 Hardware: PC OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: lucy.vaux-harvey@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org When uploading a zipped file of patron images an Error 500 message displays on screen at cgi-bin/koha/tools/picture-upload.pl. The error displays regardless of whether the upload was successful or not and means that the user does not see the expected confirmation message. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Lucy, Which exact version of Koha are you using? Do you have access to the logs on the server? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 --- Comment #2 from Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> --- Version 17.11.03 and I do have access to server logs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Which error related to this problem do you see in the logs? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 sunil <koha.sunil007@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.sunil007@gmail.com --- Comment #4 from sunil <koha.sunil007@gmail.com> --- Similar error faced by me and some other users also in past, See: https://lists.katipo.co.nz/public/koha/2017-July/048523.html I think this error comes after a security update of apache web server: https://serverfault.com/questions/853103/500-internal-server-ah02429-respons... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Lucy, which version of Apache are you using? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 --- Comment #6 from Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> --- Hi Jonathan, thanks for taking a look. I've re-tested but can't reproduce the error on the 17.11.03 site. However, I do still get the error for another site where this was reported: Version 16.11.03 Apache/2.4.10 (Debian) Error logged as: [Tue May 08 11:46:42.647237 2018] [http:error] [pid 21812:tid 140624423646976] [client 2.25.8.236:60806] AH02429: Response header name ' inflating' contains invalid characters, aborting request, referer: https://bcol-staff.koha-ptfs.co.uk/cgi-bin/koha/tools/picture-upload.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 Eugene Espinoza <eugenegf@yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eugenegf@yahoo.com --- Comment #7 from Eugene Espinoza <eugenegf@yahoo.com> --- Hi all! Getting also the same error when batch uploading patron images. However, when I enabled plack in the server, the images were uploaded successfully. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 Indranil Das Gupta <indradg@l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg@l2c2.co.in --- Comment #8 from Indranil Das Gupta <indradg@l2c2.co.in> --- Confirming that the problem persists on a package installed 17.11.05 (non-plack) with Apache 2.4.10. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Then install plack :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #9)
Then install plack :)
The script in question does not run under plack. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- The issue seems to be the call to system(): tools/upload-cover-image.pl: 107 unless ( system( "unzip", $filename, '-d', $dirname ) == 0 ) { 108 $error = 'UZIPFAIL'; 109 } This prints the reults to STDOUT, that is where the ' inflating' that upsets apache comes from -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 76807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76807&action=edit Bug 20564: Don't use system to unzip files To test: 1 - Setup a zip file for patron images and cover images 2 - Test each tool 3 - Get a '500 error' after upload (note images do upload and attach) 4 - Apply patch 5 - Restart all the things 6 - Test agtain, uploads should complete and results display -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 --- Comment #13 from Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> --- I've tried testing this patch on one of the sandboxes but can't access the Upload patron images tool at http://pro.user05-koha.sandbox.biblibre.eu/cgi-bin/koha/tools/picture-upload... Software error is: Global symbol "$filename" requires explicit package name (did you forget to declare "my $filename"?) at /home/koha/src/tools/picture-upload.pl line 118. Execution of /home/koha/src/tools/picture-upload.pl aborted due to compilation errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #14 from M. Tompsett <mtompset@hotmail.com> --- Useful documentation link for creating the zip file to test with: http://manual.koha-community.org/3.2/en/uploadpatronimages.html https://koha-community.org/manual/18.05/en/html/tools.html?highlight=batch%2... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 Saiful Amin <saiful@semanticconsulting.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |saiful@semanticconsulting.c | |om --- Comment #15 from Saiful Amin <saiful@semanticconsulting.com> --- (In reply to Nick Clemens from comment #12)
Created attachment 76807 [details] [review] Bug 20564: Don't use system to unzip files
To test: 1 - Setup a zip file for patron images and cover images 2 - Test each tool 3 - Get a '500 error' after upload (note images do upload and attach) 4 - Apply patch 5 - Restart all the things 6 - Test agtain, uploads should complete and results display
This is great patch, except for a typo. It worked only after I changed this line in tools/picture-upload.pl [17.11.5]: qx/unzip $filename -d $dirname/; with this: qx/unzip $tempfile -d $dirname/; The patch can be modified accordingly before it can be signed off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76807|0 |1 is obsolete| | --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77725&action=edit Bug 20564: Don't use system to unzip files To test: 1 - Setup a zip file for patron images and cover images 2 - Test each tool 3 - Get a '500 error' after upload (note images do upload and attach) 4 - Apply patch 5 - Restart all the things 6 - Test agtain, uploads should complete and results display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Saiful Amin from comment #15)
This is great patch, except for a typo. Oh, ha ha, whoops
Silly copy paste error Patch updated, thank you -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77725|0 |1 is obsolete| | --- Comment #18 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 79068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79068&action=edit Bug 20564: Don't use system to unzip files To test: 1 - Setup a zip file for patron images and cover images 2 - Test each tool 3 - Get a '500 error' after upload (note images do upload and attach) 4 - Apply patch 5 - Restart all the things 6 - Test agtain, uploads should complete and results display Signed-off-by: George Williams <george@nekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #19 from M. Tompsett <mtompset@hotmail.com> --- Changing to signed off, since it didn't get marked as such, even though it is clear that it was. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79068|0 |1 is obsolete| | --- Comment #20 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79072&action=edit Bug 20564: Don't use system to unzip files To test: 1 - Setup a zip file for patron images and cover images 2 - Test each tool 3 - Get a '500 error' after upload (note images do upload and attach) 4 - Apply patch 5 - Restart all the things 6 - Test agtain, uploads should complete and results display Signed-off-by: George Williams <george@nekls.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | Version|17.11 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Stable |RESOLVED --- Comment #23 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 Indranil Das Gupta <indradg@l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |harjinder.nagi@serosoft.in --- Comment #24 from Indranil Das Gupta <indradg@l2c2.co.in> --- *** Bug 21744 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org