http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala@gmail.com --- Comment #1 from Joonas Kylmälä <j.kylmala@gmail.com> --- I agree with you! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763 --- Comment #2 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 45790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45790&action=edit Bug 14763: Calculate and display patron age This patch uses the GetAge function from C4::Members to calculate the patron's age and display it. To test: 1) Go to patron Details page (ie http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51) 2) Confirm that 'Age:' is showing under the Date of Birth and is correct according to DOB (ie if DOB: 30/11/1996, Age: 19 years) 3) Edit date of birth to be a month later (ie from 30 November to 30 December) so that, as of the date you are testing, the patron has not had their birthday yet 4) Confirm that Age changes to be one year younger 5) Edit date of birth to be a different year 6) Confirm that Age changes accordingly -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15400 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763 --- Comment #4 from Marc Véron <veron@veron.ch> --- Testing for today (13/01/2016) Date of birth: 12/01/2000 Expecting: 16 years old Display: 16 years Date of birth: 13/01/2000 Expecting: 16 years old Display: 16 years Date of birth: 14/01/2000 Expecting: 15 years old Display: 15 years BTW: Applied on top of this Bug 15206 - Show patron's age when filling date of birth in memberentry.pl, works fine, no conflicts. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763 --- Comment #7 from Aleisha Amohia <aleishaamohia@hotmail.com> --- (In reply to Jonathan Druart from comment #6)

Doesn't it make more sense to display it like: Date of birth: dd/mm/yyyy (xx years) ?

Patch to come -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46570|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 46626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46626&action=edit Bug 14763: Calculate and display patron age To test: 1) Go to patron Details page (ie http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51) 2) Confirm that '(x years)' is showing next to the Date of Birth and is correct according to DOB (ie if DOB: 30/11/1996, Age: 19 years) 3) Edit date of birth to be a month later (ie from 30 November to 30 December) so that, as of the date you are testing, the patron has not had their birthday yet 4) Confirm that age changes to be one year younger 5) Edit date of birth to be a different year 6) Confirm that age changes accordingly -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- That's exactly what I was writing(In reply to Barry Cannon from comment #10)

If a patron has no date of birth set the display is "Age: 2016 years", which doesn't look right. Maybe set a string of "unset" or "no DOB" if there isn't a date of birth on the patron record?

Are you sure? Nothing is displayed for me if there is no date of birth set. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763 --- Comment #12 from Barry Cannon <bc@interleaf.ie> --- Strange, I can't recreate that problem now. I had removed this branch (and I observed the problem there) and re-based and applied it again. Sure enough, there is no problem now. Sorry! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46645|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46647&action=edit Bug 14763: Calculate and display patron age To test: 1) Go to patron Details page (ie http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51) 2) Confirm that '(x years)' is showing next to the Date of Birth and is correct according to DOB (ie if DOB: 30/11/1996, Age: 19 years) 3) Edit date of birth to be a month later (ie from 30 November to 30 December) so that, as of the date you are testing, the patron has not had their birthday yet 4) Confirm that age changes to be one year younger 5) Edit date of birth to be a different year 6) Confirm that age changes accordingly Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.