[Bug 32101] New: Add padding to floating toolbars
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101 Bug ID: 32101 Summary: Add padding to floating toolbars Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 30952 Created attachment 143145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143145&action=edit Patron entry form floating toolbar In several cases floating toolbars have no padding, making the layout seem awkward. See attached screenshot. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 143147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143147&action=edit Bug 32101: Add padding to floating toolbars This patch makes a slight change to the CSS controling the appearance of floating toolbars. In some cases the lack of padding around the toolbar elements made it look awkward. To test, apply the patch and rebuild the staff interface CSS. View various pages to confirm that the toolbar looks correct when you scroll down and the toolbar "sticks" to the top of the browser viewport. For example: - Patrons -> Search results - Patrons -> Add/edit patron - Catalog -> Advanced search form - Administration -> Preferences - Authorities -> Add/edit authority - Cataloging -> Add/edit MARC record - Catalog -> Item search form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143147|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 143150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143150&action=edit Bug 32101: Add padding to floating toolbars This patch makes a slight change to the CSS controling the appearance of floating toolbars. In some cases the lack of padding around the toolbar elements made it look awkward. To test, apply the patch and rebuild the staff interface CSS. View various pages to confirm that the toolbar looks correct when you scroll down and the toolbar "sticks" to the top of the browser viewport. For example: - Patrons -> Search results - Patrons -> Add/edit patron - Catalog -> Advanced search form - Administration -> Preferences - Authorities -> Add/edit authority - Cataloging -> Add/edit MARC record - Catalog -> Item search form Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Thanks Owen, I've noticed this but neglected to file a bug. Glad to see it fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** Bug 31944 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Better but still misaligned IMO. https://snipboard.io/XE7LgI.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143150|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143609&action=edit Bug 32101: Add padding to floating toolbars This patch makes a slight change to the CSS controling the appearance of floating toolbars. In some cases the lack of padding around the toolbar elements made it look awkward. To test, apply the patch and rebuild the staff interface CSS. View various pages to confirm that the toolbar looks correct when you scroll down and the toolbar "sticks" to the top of the browser viewport. For example: - Patrons -> Search results - Patrons -> Add/edit patron - Catalog -> Advanced search form - Administration -> Preferences - Authorities -> Add/edit authority - Cataloging -> Add/edit MARC record - Catalog -> Item search form Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32101 Bug 32101 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org