[Bug 13969] New: Testing C4::Review
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Bug ID: 13969 Summary: Testing C4::Review Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Test Suite Assignee: julian.fiol@biblibre.com Reporter: julian.fiol@biblibre.com QA Contact: gmcharlt@gmail.com Testing C4::Review in t/db_dependent/Review.t Adding a pod for every sub TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/Review.t -- All 117 tests should run successfully without any error or warning TEST PLAN OPTIONAL ------------------ Go check bug 13899 and see that coverage is 100% for this module. Coverage BEFORE this patch : Statement : 21,9% Branch : 0,0% Condition : 0,0% Subroutine : 33,3% Pod : 33,3% Coverage AFTER this patch : Statement : 100,0% Branch : 100,0% Condition : N/A Subroutine : 100,0% Pod : 100,0% -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Julian FIOL <julian.fiol@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 --- Comment #1 from Julian FIOL <julian.fiol@biblibre.com> --- Created attachment 37615 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37615&action=edit Bug 13969 : Testing C4::Review Testing C4::Review in t/db_dependent/Review.t Adding a pod for every sub TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/Review.t -- All 117 tests should run successfully without any error or warning TEST PLAN OPTIONAL ------------------ Go check bug 13899 and see that coverage is 100% for this module. Coverage BEFORE this patch : Statement : 21,9% Branch : 0,0% Condition : 0,0% Subroutine : 33,3% Pod : 33,3% Coverage AFTER this patch : Statement : 100,0% Branch : 100,0% Condition : N/A Subroutine : 100,0% Pod : 100,0% -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Julian FIOL <julian.fiol@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Julian FIOL <julian.fiol@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37615|0 |1 is obsolete| | --- Comment #2 from Julian FIOL <julian.fiol@biblibre.com> --- Created attachment 37618 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37618&action=edit Bug 13969 : Testing C4::Review Testing C4::Review in t/db_dependent/Review.t Adding a pod for every sub TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/Review.t -- All 117 tests should run successfully without any error or warning TEST PLAN OPTIONAL ------------------ Go check bug 13899 and see that coverage is 100% for this module. Coverage BEFORE this patch : Statement : 21,9% Branch : 0,0% Condition : 0,0% Subroutine : 33,3% Pod : 33,3% Coverage AFTER this patch : Statement : 100,0% Branch : 100,0% Condition : N/A Subroutine : 100,0% Pod : 100,0% -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Status|Needs Signoff |Failed QA --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Julian, 1/ I would suggest you to replace $sth = $dbh->prepare($query); $sth->execute($biblionumber1, $status); $count = $sth->fetchrow_array; with a call to $dbh->selectrow_array 2/ use perltidy on new file. 3/ use the qa script to catch the trailing spaces -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 --- Comment #4 from Julian FIOL <julian.fiol@biblibre.com> --- Created attachment 37819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37819&action=edit Bug 13969 : Replace calls to $sth->fetchrow* with a call to $dbh->selectrow* and Cleaning files 1. Replace all calls to $sth->fetchrow_array with a call to $dbh->selectrow_array 2. Cleaning Review.t file with perltiny 3. Cleaning Review.t && Review.pl files with koha-qa tool -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Julian FIOL <julian.fiol@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37819|0 |1 is obsolete| | --- Comment #5 from Julian FIOL <julian.fiol@biblibre.com> --- Created attachment 37820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37820&action=edit Bug 13969 : Replace calls to $sth->fetchrow* with a call to $dbh->selectrow* and Cleaning files 1. Replace all calls to $sth->fetchrow_array with a call to $dbh->selectrow_array 2. Cleaning Review.t file with perltiny 3. Cleaning Review.t && Review.pl files with koha-qa tool -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Julian FIOL <julian.fiol@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37618|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 38897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38897&action=edit [SIGNED-OFF] Bug 13969 : Testing C4::Review Testing C4::Review in t/db_dependent/Review.t Adding a pod for every sub TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/Review.t -- All 117 tests should run successfully without any error or warning TEST PLAN OPTIONAL ------------------ Go check bug 13899 and see that coverage is 100% for this module. Coverage BEFORE this patch : Statement : 21,9% Branch : 0,0% Condition : 0,0% Subroutine : 33,3% Pod : 33,3% Coverage AFTER this patch : Statement : 100,0% Branch : 100,0% Condition : N/A Subroutine : 100,0% Pod : 100,0% Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> All tests run -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37820|0 |1 is obsolete| | --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 38898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38898&action=edit [SIGNED-OFF] Bug 13969 : Replace calls to $sth->fetchrow* with a call to $dbh->selectrow* and Cleaning files 1. Replace all calls to $sth->fetchrow_array with a call to $dbh->selectrow_array 2. Cleaning Review.t file with perltiny 3. Cleaning Review.t && Review.pl files with koha-qa tool Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38897|0 |1 is obsolete| | Attachment #38898|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38982&action=edit Bug 13969 : Replace calls to $sth->fetchrow* with a call to $dbh->selectrow* and Cleaning files 1. Replace all calls to $sth->fetchrow_array with a call to $dbh->selectrow_array 2. Cleaning Review.t file with perltiny 3. Cleaning Review.t && Review.pl files with koha-qa tool Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38983&action=edit Bug 13969 : Testing C4::Review Testing C4::Review in t/db_dependent/Review.t Adding a pod for every sub TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/Review.t -- All 117 tests should run successfully without any error or warning TEST PLAN OPTIONAL ------------------ Go check bug 13899 and see that coverage is 100% for this module. Coverage BEFORE this patch : Statement : 21,9% Branch : 0,0% Condition : 0,0% Subroutine : 33,3% Pod : 33,3% Coverage AFTER this patch : Statement : 100,0% Branch : 100,0% Condition : N/A Subroutine : 100,0% Pod : 100,0% Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> All tests run -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38984&action=edit Bug 13969 [QA Followup] - Delete issues before borrowers -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38982|0 |1 is obsolete| | Attachment #38983|0 |1 is obsolete| | Attachment #38984|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38985 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38985&action=edit Bug 13969 : Testing C4::Review Testing C4::Review in t/db_dependent/Review.t Adding a pod for every sub TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/Review.t -- All 117 tests should run successfully without any error or warning TEST PLAN OPTIONAL ------------------ Go check bug 13899 and see that coverage is 100% for this module. Coverage BEFORE this patch : Statement : 21,9% Branch : 0,0% Condition : 0,0% Subroutine : 33,3% Pod : 33,3% Coverage AFTER this patch : Statement : 100,0% Branch : 100,0% Condition : N/A Subroutine : 100,0% Pod : 100,0% Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> All tests run -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38986 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38986&action=edit Bug 13969 : Replace calls to $sth->fetchrow* with a call to $dbh->selectrow* and Cleaning files 1. Replace all calls to $sth->fetchrow_array with a call to $dbh->selectrow_array 2. Cleaning Review.t file with perltiny 3. Cleaning Review.t && Review.pl files with koha-qa tool Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38987 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38987&action=edit Bug 13969 [QA Followup] - Delete issues before borrowers -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38985|0 |1 is obsolete| | Attachment #38986|0 |1 is obsolete| | Attachment #38987|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38988&action=edit [PASSED QA] Bug 13969 : Testing C4::Review Testing C4::Review in t/db_dependent/Review.t Adding a pod for every sub TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/Review.t -- All 117 tests should run successfully without any error or warning TEST PLAN OPTIONAL ------------------ Go check bug 13899 and see that coverage is 100% for this module. Coverage BEFORE this patch : Statement : 21,9% Branch : 0,0% Condition : 0,0% Subroutine : 33,3% Pod : 33,3% Coverage AFTER this patch : Statement : 100,0% Branch : 100,0% Condition : N/A Subroutine : 100,0% Pod : 100,0% Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> All tests run Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38989&action=edit [PASSED QA] Bug 13969 : Replace calls to $sth->fetchrow* with a call to $dbh->selectrow* and Cleaning files 1. Replace all calls to $sth->fetchrow_array with a call to $dbh->selectrow_array 2. Cleaning Review.t file with perltiny 3. Cleaning Review.t && Review.pl files with koha-qa tool Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No koha-qa errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38990&action=edit [PASSED QA] Bug 13969 [QA Followup] - Delete issues before borrowers Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Julian! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org