[Bug 11755] New: Argument 'booksellerid' not properly handled in orderreceive.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11755 Bug ID: 11755 Summary: Argument 'booksellerid' not properly handled in orderreceive.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: abl@biblos.pk.edu.pl QA Contact: testopia@bugs.koha-community.org In orderreceive.pl, argument 'booksellerid' passed to the template is always empty (= because we don't have booksellerid field in order records); subsequently, finishreceive.pl script is also not getting this parameter (and it relies on it to do some possibly important work). This has the following consequences: 1) link to vendor in the breadcrumbs on the receiving page is not working 2) this code block (introduced by Bug 5335 - More granular VAT) if ( $bookseller->{listincgst} ) { if ( not $bookseller->{invoiceincgst} ) { $order->{rrp} = $order->{rrp} * ( 1 + $order->{gstrate} ); $order->{ecost} = $order->{ecost} * ( 1 + $order->{gstrate} ); $order->{unitprice} = $order->{unitprice} * ( 1 + $order->{gstrate} ); } } else { if ( $bookseller->{invoiceincgst} ) { $order->{rrp} = $order->{rrp} / ( 1 + $order->{gstrate} ); $order->{ecost} = $order->{ecost} / ( 1 + $order->{gstrate} ); $order->{unitprice} = $order->{unitprice} / ( 1 + $order->{gstrate} ); } } } in finishreceive.pl never runs 3) in the received item records, booksellerid (952 $e) field is not updated with the correct value by ModItem(), it always becomes '' after receiving. Regarding 2), I'm not quite sure it is neceserilly the bad thing ;). But it (partially) explains to me why tax calculations in Koha are occasionally working seemingly weird (at least for some less usual invoiceincgst & listincgst settings in vendor record). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11755 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11755 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25834&action=edit Bug 11755: SearchOrders does not return booksellerid The SearchOrders routine should return the booksellerid. Booksellerid was returned before bug 10723. Quick test plan: Go on orderreceive.pl and verify that the vendor link is correct. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11755 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11755 --- Comment #2 from Jacek Ablewicz <abl@biblos.pk.edu.pl> --- (In reply to Jonathan Druart from comment #1)
Created attachment 25834 [details] [review] Bug 11755: SearchOrders does not return booksellerid
The SearchOrders routine should return the booksellerid.
Booksellerid was returned before bug 10723.
Patch does resolve all the issues mentioned; I'm a little worried about an impact it will have on issue 2), though.. Situation regarding tax recalculation code in finishreceive.pl seems to be somehow like that: - in 3.10 & 3.12 branches, this code block was, and still is working like intended, - it got broken in 3.14 and up (since bug 10723) resulting in price values in all newly received orders being inconsistently saved in the database (at least for those cases where listincgst xor invoiceincgst != 1) ? As a side effect, some bug reports currently sitting in the queue which regard various problems with tax calculations in Koha will probably need to be retested / reevaluated. Still, IMO pushing this patch first (and ASAP) will be a huge change in the right direction. I wonder if there may be some way to retroactively correct wrongly calculated price values which may already got stored in aqorders table, for those people using 3.14 right now in production environment? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11755 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10613 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11755 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10613 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11755 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25834|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25885&action=edit Bug 11755: SearchOrders does not return booksellerid The SearchOrders routine should return the booksellerid. Booksellerid was returned before bug 10723. Quick test plan: Go on orderreceive.pl and verify that the vendor link is correct. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11755 --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 25894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25894&action=edit [Signed-off] Bug 11755: SearchOrders does not return booksellerid The SearchOrders routine should return the booksellerid. Booksellerid was returned before bug 10723. Quick test plan: Go on orderreceive.pl and verify that the vendor link is correct. Followed test plan. Vendor link is now correct. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11755 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25885|0 |1 is obsolete| | CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11755 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11755 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |brendan@bywatersolutions.co | |m --- Comment #5 from Brendan Gallagher <brendan@bywatersolutions.com> --- Jonathan - tests failed. There are a lot of new additions to the Acquisitions.t Besides that - the patch does do what it advertize - so once tests past :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11755 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26078&action=edit Bug 11755: SearchOrders does not return booksellerid The SearchOrders routine should return the booksellerid. Booksellerid was returned before bug 10723. Quick test plan: Go on orderreceive.pl and verify that the vendor link is correct. Followed test plan. Vendor link is now correct. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11755 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Last patch rebased. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11755 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25894|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11755 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26078|0 |1 is obsolete| | --- Comment #8 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 26121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26121&action=edit Bug 11755: SearchOrders does not return booksellerid The SearchOrders routine should return the booksellerid. Booksellerid was returned before bug 10723. Quick test plan: Go on orderreceive.pl and verify that the vendor link is correct. Followed test plan. Vendor link is now correct. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11755 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11755 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11755 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m Patch complexity|--- |Trivial patch --- Comment #10 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.07 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org