http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11018 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11018 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21883&action=edit Bug 11018 - Add order from a reverted file Weird behavior: When an import is undone into catalog, the status is set to "reverted". But if you open the add orders from iso2709, the status is automatically set to "imported" and does not appear in the list. So it is not possible to import a reverted batch. Test plan: - verify you reproduce the weird behavior - apply this patch - import a file and the batch into the catalog - verify (in the your mysql/MariaDB cli) the status is "imported" - verify it does not appears in the add orders from iso2809 page - undo the import - verify (in the your mysql/MariaDB cli) the status is "reverted" - verify it appears in the add orders from iso2809 page and the status is always "reverted" - finish the order -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11018 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Pierre Angot <tredok.pierre@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11018 --- Comment #4 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 24166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24166&action=edit Bug 11018 - Add order from a reverted file Weird behavior: When an import is undone into catalog, the status is set to "reverted". But if you open the add orders from iso2709, the status is automatically set to "imported" and does not appear in the list. So it is not possible to import a reverted batch. Test plan: - verify you reproduce the weird behavior - apply this patch - import a file and the batch into the catalog - verify (in the your mysql/MariaDB cli) the status is "imported" - verify it does not appears in the add orders from iso2809 page - undo the import - verify (in the your mysql/MariaDB cli) the status is "reverted" - verify it appears in the add orders from iso2809 page and the status is always "reverted" - finish the order Signed-off-by: Pierre Angot <tredok.pierre@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11018 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11018 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Passed QA, but I think it prudent to ask the question "Is there any reason we shouldn't allow orders from reverted batches?" I can't imagine a reason not to, but I'm not very imaginative ; ) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11018 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Katrin Fischer from comment #8)

I think it makes sense to me not to allow it. Hm, can't really explain it beyond that reverted to indicate "unwanted" to me.

I can see why it sounds odd, but on the other hand, a reverted batch is still a staged batch -- it just /used/ to be imported. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11018 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #11 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patch pushed to 3.14.x, will be in 3.14.5 -- You are receiving this mail because: You are watching all bug changes.