https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31144 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 137651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137651&action=edit Bug 31144: When modifying an order we should not load the vendor default discount After placing an order in a basket with a discount of "0" if you attempt to modify we will load the vendor default discount, this can lead to accidentally applying a discount when modifying other order parts To test: 0 - Have a vendor with a discount set 1 - Add an order to a basket 2 - While adding, set discount to 0 3 - Add order - prices are calculated ocrrectly 4 - Modify order 5 - Note discount is populated with vendor discount 6 - Cancel 7 - Apply patch 8 - Modify order 9 - Discount remains at 0 10 - Repeat with a vendor with no discount set 11 - Placing order not specifiying discount it remains blank 12 - Modifying order discount remains blank 13 - Modify order and set discount 14 - Confirm it is retained on modifcation -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31144 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137651|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 137652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137652&action=edit Bug 31144: When modifying an order we should not load the vendor default discount After placing an order in a basket with a discount of "0" if you attempt to modify we will load the vendor default discount, this can lead to accidentally applying a discount when modifying other order parts To test: 0 - Have a vendor with a discount set 1 - Add an order to a basket 2 - While adding, set discount to 0 3 - Add order - prices are calculated ocrrectly 4 - Modify order 5 - Note discount is populated with vendor discount 6 - Cancel 7 - Apply patch 8 - Modify order 9 - Discount remains at 0 10 - Repeat with a vendor with no discount set 11 - Placing order not specifiying discount it remains blank 12 - Modifying order discount remains blank 13 - Modify order and set discount 14 - Confirm it is retained on modifcation Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31144 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137652|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137770&action=edit Bug 31144: When modifying an order we should not load the vendor default discount After placing an order in a basket with a discount of "0" if you attempt to modify we will load the vendor default discount, this can lead to accidentally applying a discount when modifying other order parts To test: 0 - Have a vendor with a discount set 1 - Add an order to a basket 2 - While adding, set discount to 0 3 - Add order - prices are calculated ocrrectly 4 - Modify order 5 - Note discount is populated with vendor discount 6 - Cancel 7 - Apply patch 8 - Modify order 9 - Discount remains at 0 10 - Repeat with a vendor with no discount set 11 - Placing order not specifiying discount it remains blank 12 - Modifying order discount remains blank 13 - Modify order and set discount 14 - Confirm it is retained on modifcation Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31144 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31144 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31144 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 Status|Pushed to stable |Pushed to oldstable CC| |arthur.suzuki@biblibre.com --- Comment #7 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31144 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose@inlibr | |o.com Resolution|--- |FIXED --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- This is a bug fix, nothing to document that I can see. -- You are receiving this mail because: You are watching all bug changes.