[Bug 16822] New: koha-common init.d script should run koha-plack without quiet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16822 Bug ID: 16822 Summary: koha-common init.d script should run koha-plack without quiet Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt@gmail.com Reporter: liz@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz We should alert during installation, restart, or upgrade for all daemon services stopping and starting. For example, stopping and starting the SIP server alerts during the apt install process. We expect (and sometimes depend on) things like Apache and MySQL(MariaDB) telling us when they are restarting during upgrades, I think we should treat our daemons the same way. All this really means is making the init.d run koha-plack without --quiet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16822 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16822 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 53720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53720&action=edit Bug 16822: Make koha-common call koha-plack without --quiet This patch removes the --quiet option switch in koha-common.init so problem information is not hidden for sysadmin users. To test: - Have plack enabled for a koha instance: $ sudo koha-plack --enable kohadev $ sudo koha-plack --start kohadev - Run: $ cd kohaclone $ debian/koha-common.init {start|stop|restart} => SUCCESS: No behaviour change - Disable the 'cgi' apache module: $ sudo a2dismod cgi - Run: $ debian/koha-common.init {start|stop|restart} => FAIL: No warning is shown - Apply the patch - Run: $ debian/koha-common.init {start|stop|restart} => SUCCESS: Warnings show up - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16822 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Assignee|gmcharlt@gmail.com |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16822 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16822 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53720|0 |1 is obsolete| | --- Comment #2 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 55389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55389&action=edit Bug 16822: Make koha-common call koha-plack without --quiet This patch removes the --quiet option switch in koha-common.init so problem information is not hidden for sysadmin users. To test: - Have plack enabled for a koha instance: $ sudo koha-plack --enable kohadev $ sudo koha-plack --start kohadev - Run: $ cd kohaclone $ debian/koha-common.init {start|stop|restart} => SUCCESS: No behaviour change - Disable the 'cgi' apache module: $ sudo a2dismod cgi - Run: $ debian/koha-common.init {start|stop|restart} => FAIL: No warning is shown - Apply the patch - Run: $ debian/koha-common.init {start|stop|restart} => SUCCESS: Warnings show up - Sign off :-D Signed-off-by: Liz Rea <liz@catalyst.net.nz> Perfect thanks :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16822 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16822 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55389|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 55395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55395&action=edit Bug 16822: Make koha-common call koha-plack without --quiet This patch removes the --quiet option switch in koha-common.init so problem information is not hidden for sysadmin users. To test: - Have plack enabled for a koha instance: $ sudo koha-plack --enable kohadev $ sudo koha-plack --start kohadev - Run: $ cd kohaclone $ debian/koha-common.init {start|stop|restart} => SUCCESS: No behaviour change - Disable the 'cgi' apache module: $ sudo a2dismod cgi - Run: $ debian/koha-common.init {start|stop|restart} => FAIL: No warning is shown - Apply the patch - Run: $ debian/koha-common.init {start|stop|restart} => SUCCESS: Warnings show up - Sign off :-D Signed-off-by: Liz Rea <liz@catalyst.net.nz> Perfect thanks :) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16822 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16822 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16822 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Status|Pushed to Master |Pushed to Stable --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.04. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16822 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x, will be in 3.22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org