[Bug 22802] New: When ordering form a staged file, if funds are populated per item order level fund should not be required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 Bug ID: 22802 Summary: When ordering form a staged file, if funds are populated per item order level fund should not be required Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- To recreate: 1 - Set MarcItemFieldsToOder: homebranch: 975$a holdingbranch: 975$b itype: 975$y nonpublic_note: 975$x public_note: 975$z loc: 975$c ccode: 970$c notforloan: 975$7 uri: 975$u copyno: 975$n quantity: 975$q budget_code: 975$h price: 975$g replacementprice: 975$p 2 - Create a MARC record with a 975 like: =975 \\$aCPL$bCPL$g27.99$oONORDER$q1$p22.39$7-1$yBK$hBUDGET_CODE 3 - Ensure budget code, itype, and branches are valid values for your system 4 - In a basket with create items so to 'on ordering' add the file above 5 - Try to add the order 6 - Order level fund is required -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22734 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22734 [Bug 22734] Fund not marked as mandatory when ordering from a staged file -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This is not trivial at all and I have no idea how to fix it easily before the release. I would opt to revert bug 22734 if no fix is provided here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 89744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89744&action=edit Bug 22802: Check item funds, order funds, and default funds when ordering from a file This patch tries to centralise the logic of order funds requirements into a single routine. If propogates defaults down into items/order as necessary, it also prevents unsetting lower values if a default is set. To test: 1 - Populate 'MarcItemFieldsToOrder' 2 - Add to a basket from a file 3 - Use a file containing some item records with funds defined or not 4 - Confirm if all items have funds defined, you can order 5 - Confirm that setting the default for an order populates items and you can order 6 - Confirm that setting the default for all orders populates items if present/ order if not 7 - Confirm that if defaults are set the lower levels cannot be unset 8 - Try various settings and confirm all work as expected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, oleonard@myacpl.org Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 89745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89745&action=edit Orders to test with, using default funds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com | |, kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20830 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 [Bug 20830] Make sure a fund is selected when ordering from staged file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89744|0 |1 is obsolete| | --- Comment #4 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 89791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89791&action=edit Bug 22802: Check item funds, order funds, and default funds when ordering from a file This patch tries to centralise the logic of order funds requirements into a single routine. If propogates defaults down into items/order as necessary, it also prevents unsetting lower values if a default is set. To test: 1 - Populate 'MarcItemFieldsToOrder' 2 - Add to a basket from a file 3 - Use a file containing some item records with funds defined or not 4 - Confirm if all items have funds defined, you can order 5 - Confirm that setting the default for an order populates items and you can order 6 - Confirm that setting the default for all orders populates items if present/ order if not 7 - Confirm that if defaults are set the lower levels cannot be unset 8 - Try various settings and confirm all work as expected Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 Martha Fuerst <mfuerst@hmcpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mfuerst@hmcpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89791|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 90035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90035&action=edit Bug 22802: Check item funds, order funds, and default funds when ordering from a file This patch tries to centralise the logic of order funds requirements into a single routine. If propogates defaults down into items/order as necessary, it also prevents unsetting lower values if a default is set. To test: 1 - Populate 'MarcItemFieldsToOrder' 2 - Add to a basket from a file 3 - Use a file containing some item records with funds defined or not 4 - Confirm if all items have funds defined, you can order 5 - Confirm that setting the default for an order populates items and you can order 6 - Confirm that setting the default for all orders populates items if present/ order if not 7 - Confirm that if defaults are set the lower levels cannot be unset 8 - Try various settings and confirm all work as expected Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Not the cleanest implementation ever, but it does work well and is sufficiently commented to understand.. It would be nice to see some selenium tests in a followup next cycle. PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|When ordering form a staged |When ordering from a staged |file, if funds are |file, if funds are |populated per item order |populated per item order |level fund should not be |level fund should not be |required |required -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm not entirely sure if we need a port of this or not for 18.11.x series, but I don't feel confident I can deliver on in time to 18.11.06 I'm afraid.. deferring to next rmaint (sorry Frido) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #8)
I'm not entirely sure if we need a port of this or not for 18.11.x series, but I don't feel confident I can deliver on in time to 18.11.06 I'm afraid.. deferring to next rmaint (sorry Frido)
The two easiest paths here I think are: 1 - Back 22743 and apply this on top - that gets things in line with master 2 - revert 20830 - this removes the problematic code that causes this -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Something wrong from this patch:
Add orders from MARC file "show inactive funds" is not checked expand the order div to see the details You see Fund: Select a fund (will use default if set) Check "show inactive funds" You see Select a fund (will populate orders/items if set) Uncheck "show inactive funds" You see Select a fund (will populate orders/items if set)
I have no idea what it means but it's not consistent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33939 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33939 [Bug 33939] javascript needs to distinguish between order budgets and default budgets when adding to staged file form a basket -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org