[Bug 43769] New: existing_holds table search/filter by pickup library is broken on request.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 Bug ID: 43769 Summary: existing_holds table search/filter by pickup library is broken on request.tt Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Target Milestone: --- To recreate: 1. Make a branch with a code 'TEST' and name 'Sparkly Unicorn Land' 2. Place some holds, more than 2, on a record. Make the pickup location for one be 'Sparkly Unicorn Land'. 3. On Use the dT search to search the existing holds table on request.tt 4. Search by 'TEST' - the hold appears 5. Search by 'Sparkly' - the hold appears 6. Search by 'Unicorn' - the hold does not appear -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 Michael Adamyk <michael.adamyk@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael.adamyk@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 --- Comment #1 from Michael Adamyk <michael.adamyk@bywatersolutions.com> --- It looks like the search for branch name is "starts with" rather than "contains." In previous versions of Koha (25.05 and earlier) searching by the second word in a branch name works, but not in the versions after. It didn't work at all in 25.11, and in 26.05 after bug 42915 it only works as a "starts with" search -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 Michael Adamyk <michael.adamyk@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42915 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915 [Bug 42915] Filtering Holds table by patron name or pickup library is broken -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 207632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207632&action=edit Bug 43769: Allow searching of pickup library name in existing holds table To test: 1. Make a branch with a code 'TEST' and name 'Sparkly Unicorn Land' 2. Place some holds, more than 2, on a record. Make the pickup location for one be 'Sparkly Unicorn Land'. 3. On Use the dT search to search the existing holds table on request.tt 4. Search by 'TEST' - the hold appears 5. Search by 'Sparkly' - the hold appears 6. Search by 'Unicorn' - the hold does not appear 7. APPLY PATCH 8. Do the searching again, this time steps 4, 5, and 6 should all return the row -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207632|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 --- Comment #3 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 207633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207633&action=edit Bug 43769: Allow searching of pickup library name in existing holds table To test: 1. Make a branch with a code 'TEST' and name 'Sparkly Unicorn Land' 2. Place some holds, more than 2, on a record. Make the pickup location for one be 'Sparkly Unicorn Land'. 3. On Use the dT search to search the existing holds table on request.tt 4. Search by 'TEST' - the hold appears 5. Search by 'Sparkly' - the hold appears 6. Search by 'Unicorn' - the hold does not appear 7. APPLY PATCH 8. Do the searching again, this time steps 4, 5, and 6 should all return the row Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- `datatype: "coded_value:library",` This is supposed to be the correct way to search on code and description. I think we should try to fix datatables.js (again) if the behaviour is not the expected one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #4)
`datatype: "coded_value:library",`
This is supposed to be the correct way to search on code and description. I think we should try to fix datatables.js (again) if the behaviour is not the expected one.
Fair, I was hoping for a small/easy fix but you're right. This happens in other datatables as well. Just test in the holdings table. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org