[Bug 43769] New: existing_holds table search/filter by pickup library is broken on request.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 Bug ID: 43769 Summary: existing_holds table search/filter by pickup library is broken on request.tt Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Target Milestone: --- To recreate: 1. Make a branch with a code 'TEST' and name 'Sparkly Unicorn Land' 2. Place some holds, more than 2, on a record. Make the pickup location for one be 'Sparkly Unicorn Land'. 3. On Use the dT search to search the existing holds table on request.tt 4. Search by 'TEST' - the hold appears 5. Search by 'Sparkly' - the hold appears 6. Search by 'Unicorn' - the hold does not appear -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 Michael Adamyk <michael.adamyk@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael.adamyk@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 --- Comment #1 from Michael Adamyk <michael.adamyk@bywatersolutions.com> --- It looks like the search for branch name is "starts with" rather than "contains." In previous versions of Koha (25.05 and earlier) searching by the second word in a branch name works, but not in the versions after. It didn't work at all in 25.11, and in 26.05 after bug 42915 it only works as a "starts with" search -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 Michael Adamyk <michael.adamyk@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42915 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915 [Bug 42915] Filtering Holds table by patron name or pickup library is broken -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 207632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207632&action=edit Bug 43769: Allow searching of pickup library name in existing holds table To test: 1. Make a branch with a code 'TEST' and name 'Sparkly Unicorn Land' 2. Place some holds, more than 2, on a record. Make the pickup location for one be 'Sparkly Unicorn Land'. 3. On Use the dT search to search the existing holds table on request.tt 4. Search by 'TEST' - the hold appears 5. Search by 'Sparkly' - the hold appears 6. Search by 'Unicorn' - the hold does not appear 7. APPLY PATCH 8. Do the searching again, this time steps 4, 5, and 6 should all return the row -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207632|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 --- Comment #3 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 207633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207633&action=edit Bug 43769: Allow searching of pickup library name in existing holds table To test: 1. Make a branch with a code 'TEST' and name 'Sparkly Unicorn Land' 2. Place some holds, more than 2, on a record. Make the pickup location for one be 'Sparkly Unicorn Land'. 3. On Use the dT search to search the existing holds table on request.tt 4. Search by 'TEST' - the hold appears 5. Search by 'Sparkly' - the hold appears 6. Search by 'Unicorn' - the hold does not appear 7. APPLY PATCH 8. Do the searching again, this time steps 4, 5, and 6 should all return the row Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- `datatype: "coded_value:library",` This is supposed to be the correct way to search on code and description. I think we should try to fix datatables.js (again) if the behaviour is not the expected one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #4)
`datatype: "coded_value:library",`
This is supposed to be the correct way to search on code and description. I think we should try to fix datatables.js (again) if the behaviour is not the expected one.
Fair, I was hoping for a small/easy fix but you're right. This happens in other datatables as well. Just test in the holdings table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Assignee|lucas@bywatersolutions.com |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207633|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 207704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207704&action=edit Bug 43769: Allow searching on partial library name in global table search The coded value datatype only searched on decriptions for the global search, always using "starts with". To test: 1. Make a branch with a code 'TEST' and name 'Sparkly Unicorn Land' 2. Place some holds, more than 2, on a record. Make the pickup location for one be 'Sparkly Unicorn Land'. 3. On Use the dT search to search the existing holds table on request.tt 4. Search by 'TEST' - the hold appears 5. Search by 'Sparkly' - the hold appears 6. Search by 'Unicorn' - the hold does not appear 7. APPLY PATCH 8. Do the searching again, this time steps 4, 5, and 6 should all return the row -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 207705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207705&action=edit Bug 43769: (follow-up) Keep searching on the code when a description matches Searching 'test' matched the description 'Institut Protestant de Théologie' and only searched on its code (IPT), the library with the code 'TEST' was not found anymore. If the search could match a code as well, keep the like on the code next to the codes found using the description. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 207706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207706&action=edit Bug 43769: (follow-up) Add Cypress tests for coded_value search Use the existing holds table of reserve/request.pl, its pickup library column is a coded_value:library. Cover searching on the code, on the description (not only its beginning, case insensitive), with no matching description and with regex metacharacters, and check the generated query. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Pfiou that was a tricky one, I had to call Claude to the rescue. Luckily this is a well test covered area! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 Frédéric Demians <f.demians@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |f.demians@tamil.fr --- Comment #10 from Frédéric Demians <f.demians@tamil.fr> --- It work! Searching on a part of the library name now filters the existing holds table. Searching "test" finds both TEST and the library whose name contains "test". But the Cypress tests fail on my box: 20 passing, 3 failing. Library ZQA is named "Sparkly Unicorn Land" but the tests search for "Shimmering", "Pegasus" and "shimmering PEGASUS meadow". Is it just a typo in the tests? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207706|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 207840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207840&action=edit Bug 43769: (follow-up) Add Cypress tests for coded_value search Use the existing holds table of reserve/request.pl, its pickup library column is a coded_value:library. Cover searching on the code, on the description (not only its beginning, case insensitive), with no matching description and with regex metacharacters, and check the generated query. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Frédéric Demians from comment #10)
But the Cypress tests fail on my box: 20 passing, 3 failing. Library ZQA is named "Sparkly Unicorn Land" but the tests search for "Shimmering", "Pegasus" and "shimmering PEGASUS meadow". Is it just a typo in the tests?
Yes, sorry, last minute change broke the tests! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 --- Comment #13 from Frédéric Demians <f.demians@tamil.fr> --- Thanks Jonathan. With the new Cypress tests: - without patch: the 4 new test fail - with patch: 23 tests pass The manual test plan asks to create a library TEST named "Sparkly Unicorn Land", and the Cypress tests create library ZQA with the same name. It create an issue when following exactly the test plan. But resetting the database between test plan steps solves it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 Frédéric Demians <f.demians@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 Frédéric Demians <f.demians@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207704|0 |1 is obsolete| | Attachment #207705|0 |1 is obsolete| | Attachment #207840|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 --- Comment #14 from Frédéric Demians <f.demians@tamil.fr> --- Created attachment 207875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207875&action=edit Bug 43769: Allow searching on partial library name in global table search The coded value datatype only searched on decriptions for the global search, always using "starts with". To test: 1. Make a branch with a code 'TEST' and name 'Sparkly Unicorn Land' 2. Place some holds, more than 2, on a record. Make the pickup location for one be 'Sparkly Unicorn Land'. 3. On Use the dT search to search the existing holds table on request.tt 4. Search by 'TEST' - the hold appears 5. Search by 'Sparkly' - the hold appears 6. Search by 'Unicorn' - the hold does not appear 7. APPLY PATCH 8. Do the searching again, this time steps 4, 5, and 6 should all return the row Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 --- Comment #15 from Frédéric Demians <f.demians@tamil.fr> --- Created attachment 207876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207876&action=edit Bug 43769: (follow-up) Keep searching on the code when a description matches Searching 'test' matched the description 'Institut Protestant de Théologie' and only searched on its code (IPT), the library with the code 'TEST' was not found anymore. If the search could match a code as well, keep the like on the code next to the codes found using the description. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 --- Comment #16 from Frédéric Demians <f.demians@tamil.fr> --- Created attachment 207877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207877&action=edit Bug 43769: (follow-up) Add Cypress tests for coded_value search Use the existing holds table of reserve/request.pl, its pickup library column is a coded_value:library. Cover searching on the code, on the description (not only its beginning, case insensitive), with no matching description and with regex metacharacters, and check the generated query. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207875|0 |1 is obsolete| | Attachment #207876|0 |1 is obsolete| | Attachment #207877|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 --- Comment #17 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 208556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208556&action=edit Bug 43769: Allow searching on partial library name in global table search The coded value datatype only searched on decriptions for the global search, always using "starts with". To test: 1. Make a branch with a code 'TEST' and name 'Sparkly Unicorn Land' 2. Place some holds, more than 2, on a record. Make the pickup location for one be 'Sparkly Unicorn Land'. 3. On Use the dT search to search the existing holds table on request.tt 4. Search by 'TEST' - the hold appears 5. Search by 'Sparkly' - the hold appears 6. Search by 'Unicorn' - the hold does not appear 7. APPLY PATCH 8. Do the searching again, this time steps 4, 5, and 6 should all return the row Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 --- Comment #18 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 208557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208557&action=edit Bug 43769: (follow-up) Keep searching on the code when a description matches Searching 'test' matched the description 'Institut Protestant de Théologie' and only searched on its code (IPT), the library with the code 'TEST' was not found anymore. If the search could match a code as well, keep the like on the code next to the codes found using the description. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 --- Comment #19 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 208558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208558&action=edit Bug 43769: (follow-up) Add Cypress tests for coded_value search Use the existing holds table of reserve/request.pl, its pickup library column is a coded_value:library. Cover searching on the code, on the description (not only its beginning, case insensitive), with no matching description and with regex metacharacters, and check the generated query. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Fixes a problem with release notes| |DataTables searching where | |partial matches could not | |be searched for. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | --- Comment #20 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Pushed to main for 26.11 with consent from Pedro whilst he's on annual leave -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43769 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org