[Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #33 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Marc Véron from comment #32)
Updating database did not work because /installer/data/mysql/atomicupdate/bug14874- addDefaultPatronSearchFieldspreference should be: /installer/data/mysql/atomicupdate/bug14874- addDefaultPatronSearchFieldspreference.sql
Will fix
After fixing - It does not work with name + partial date (e.g. meier 12.01)
Nope and I don't think it should. We only convert date to SQL format if it is a full date - guessing on partial dates would be tricky and likely not work. Should work with '12 01' so each part of date can be searched as its own term
- I can trigger an 'Internal Server Error' by selecting "Date of birth" as search field and searching for an invalid date (e.g. 12.01 instead of 12.01.1995) This is true on master: 67 if ( $searchfieldstype eq "dateofbirth" ) { 68 $searchmember = output_pref({dt => dt_from_string($searchmember), dateformat => 'iso', dateonly => 1}); 69 }
We don't catch any errors or validate data - likely we should use datepicker in this scenario - file a bug please
- E.g. with zipcode added to syspref, I can find a patron by zipcode using searchfields = standard, however I can not select zipcode as search field. Would be nice to have (in a separate bug/enhancement based on this bug).
Hmm..the only problem is determining if we want all patron fields listed, or only the 'useful' ones - file a bug though and see opinions -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org