[Bug 5028] New: catmaintain.pl doesn't exist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5028 Summary: catmaintain.pl doesn't exist Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Staff Client AssignedTo: chris@bigballofwax.co.nz ReportedBy: oleonard@myacpl.org QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Estimated Hours: 0.0 A couple of the templates include links to catamaintain.pl: opac-detail.tmpl and detail.tmpl. From detail.tmpl: <!-- TMPL_IF NAME="type" --> <td><a href="/cgi-bin/koha/maint/catmaintain.pl?type=fixitemtype&bi=<!-- TMPL_VAR NAME="biblioitemnumber" -->&item=<!-- TMPL_VAR NAME="itemtype" -->">Fix Itemtype</a></td> <!-- /TMPL_IF --> I'm assuming "type" never evaluates as true, because as far as I can tell this link never shows up. If it did it would point to a nonexistent file. There is no maint/catmaintain.pl. Is it safe to remove catmaintain.tmpl and the links to catmaintain.pl? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5028 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Component|Staff Client |Templates AssignedTo|chris@bigballofwax.co.nz |oleonard@myacpl.org Summary|catmaintain.pl doesn't |Remove references to |exist |catmaintain.pl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5028 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-08-23 18:59:49 UTC --- Created attachment 5109 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5109 Proposed fix catmaintain.pl doesn't exist anymore. References to it in the templates should be removed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5028 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5028 stephane.delaune@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephane.delaune@biblibre.c | |om Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5028 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Signed Off |Passed QA --- Comment #2 from Ian Walls <ian.walls@bywatersolutions.com> 2011-09-02 11:49:34 UTC --- maint/catmaintain.pl no longer exists (deleted Sept 6 2006, commit ID 7e52a5665), so there is no need to reference it anymore. Template only change, easy to read, marking as Passed QA. Please check koha-tmpl/intranet-tmpl/prog/en/includes/error-top.inc for an additional reference to this deleted file. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5028 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> 2011-09-02 13:30:49 UTC --- I'm hoping error-top.inc will go away with the approval of Bug 6768. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5028 --- Comment #4 from Ian Walls <ian.walls@bywatersolutions.com> 2011-09-02 13:52:36 UTC --- Bug 6768 has been passed, so the remaining reference to catmaintain.pl will be removed with it's committal. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5028 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-03 08:48:35 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5028 --- Comment #6 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-10-26 18:02:36 UTC --- The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5028 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org