https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16937 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16937 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |hector.hecaxmmx@gmail.com --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Hi Owen Sorry but patch doesn't apply Applying: Bug 16937 - Remove "onclick" from the manage staged MARC records template fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 16937 - Remove "onclick" from the manage staged MARC records template -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16937 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53478|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 53509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53509&action=edit Bug 16937 - Remove "onclick" from the manage staged MARC records template This patch revises the manage staged MARC records template, removing "onclick" attributes from the markup and defining those events in the script. To test, apply the patch and go to Tools -> Manage staged MARC records. - If necessary, stage a MARC file for import. - Click the name of the staged file and then the "Import this batch into the catalog" button. The batch should be correctly imported. - Return to the list of staged MARC files. - Click the name of an imported file and then the "Undo import into catalog" button. The import should be reverted. - Return to the list of staged MARC files. - Click the "Clean" button for any record. Confirm that the batch is cleaned. - For any cleaned record, click the "Delete" button. The batch should be deleted. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16937 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53509|0 |1 is obsolete| | --- Comment #5 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 53529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53529&action=edit [SIGNED-OFF]Bug 16937: Remove "onclick" from the manage staged MARC records template This patch revises the manage staged MARC records template, removing "onclick" attributes from the markup and defining those events in the script. To test, apply the patch and go to Tools -> Manage staged MARC records. - If necessary, stage a MARC file for import. - Click the name of the staged file and then the "Import this batch into the catalog" button. The batch should be correctly imported. - Return to the list of staged MARC files. - Click the name of an imported file and then the "Undo import into catalog" button. The import should be reverted. - Return to the list of staged MARC files. - Click the "Clean" button for any record. Confirm that the batch is cleaned. - For any cleaned record, click the "Delete" button. The batch should be deleted. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16937 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I always get "Clear all reservoir records staged in this batch? This cannot be undone." even if I click on "Delete". -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16937 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53529|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 53646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53646&action=edit [SIGNED-OFF] Bug 16937 [Revised] Remove "onclick" from the manage staged MARC records template This patch revises the manage staged MARC records template, removing "onclick" attributes from the markup and defining those events in the script. To test, apply the patch and go to Tools -> Manage staged MARC records. - If necessary, stage a MARC file for import. - Click the name of the staged file and then the "Import this batch into the catalog" button. The batch should be correctly imported. - Return to the list of staged MARC files. - Click the name of an imported file and then the "Undo import into catalog" button. The import should be reverted. - Return to the list of staged MARC files. - Click the "Clean" button for any record. Confirm that the batch is cleaned. - For any cleaned record, click the "Delete" button. The batch should be deleted. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised QA revision: Corrected class name so that "delete" button triggers the correct warning. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16937 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53646|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53702&action=edit Bug 16937 [Revised] Remove "onclick" from the manage staged MARC records template This patch revises the manage staged MARC records template, removing "onclick" attributes from the markup and defining those events in the script. To test, apply the patch and go to Tools -> Manage staged MARC records. - If necessary, stage a MARC file for import. - Click the name of the staged file and then the "Import this batch into the catalog" button. The batch should be correctly imported. - Return to the list of staged MARC files. - Click the name of an imported file and then the "Undo import into catalog" button. The import should be reverted. - Return to the list of staged MARC files. - Click the "Clean" button for any record. Confirm that the batch is cleaned. - For any cleaned record, click the "Delete" button. The batch should be deleted. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised QA revision: Corrected class name so that "delete" button triggers the correct warning. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16937 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |frederic@tamil.fr --- Comment #10 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.04. -- You are receiving this mail because: You are watching all bug changes.