[Bug 16861] New: Translatability: Fix separated "abow" in circulation.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 Bug ID: 16861 Summary: Translatability: Fix separated "abow" in circulation.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: hector.hecaxmmx@gmail.com QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Depends on: 16810 This patch propose to fix this two entries in PO files: #: intranet-tmpl/prog/en/modules/circ/circulation.tt:797 #, c-format msgid ". See highlighted items " msgstr ". Véase los ítems resaltados " #: intranet-tmpl/prog/en/modules/circ/circulation.tt:797 #, c-format msgid "below" msgstr "debajo" Also add some Font Awesome Icons to circulation interface. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16810 [Bug 16810] Fines note not showing on checkout -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Translatability: Fix |Translatability: Fix |separated "abow" in |separated "below" in |circulation.tt |circulation.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 --- Comment #1 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 53142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53142&action=edit Bug 16861: Translatability: Fix separated "below" in circulation.tt This patch propose to fix this two entries in PO files: "See highlighted items" and "below" Also add some Font Awesome Icons To test: -Go to a patron how has overdues -See the link "See highlighted items below" with a hand down icon -Look the new plus icon to "Add a new message" to the patron. -Add a few messages and notice about the trash icon in "Delete" links -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org, | |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53142|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 53143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53143&action=edit Bug 16861: Translatability: Fix separated "below" in circulation.tt This patch propose to fix this two entries in PO files: "See highlighted items" and "below" Also add some Font Awesome Icons To test: -Apply patch 16810 on top and this patch -Go to a patron who has overdues in checkout tab -See the link "See highlighted items below" with a hand down icon -Look the new plus icon to "Add a new message" to the patron. -Add a few messages and notice about the trash icon in "Delete" links -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53143|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 53150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53150&action=edit Bug 16861: Translatability: Fix separated "below" in circulation.tt This patch propose to fix this two entries in PO files: "See highlighted items" and "below" Also add some Font Awesome Icons To test: -Apply patch 16810 on top and this patch -Go to a patron who has overdues -See the link "See highlighted items below" with a hand down icon -Look the new plus icon to "Add a new message" to the patron. -Add a few messages and notice about the trash icon in "Delete" links Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53150|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53170&action=edit Bug 16861: Translatability: Fix separated "below" in circulation.tt This patch propose to fix this two entries in PO files: "See highlighted items" and "below" Also add some Font Awesome Icons To test: -Apply patch 16810 on top and this patch -Go to a patron who has overdues -See the link "See highlighted items below" with a hand down icon -Look the new plus icon to "Add a new message" to the patron. -Add a few messages and notice about the trash icon in "Delete" links Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Héctor, I have asked Owen (on #koha) if he agrees on the fa-hand-o-down icon and he does not :) Could you please remove it? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53150|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53170|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 --- Comment #6 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 53193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53193&action=edit Bug 16861: (followup)Translatability: remove fa-hand-o-down icon Remove fa-hand-o-down icon accoring with QA comment 5 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion Severity|enhancement |minor --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am ok with the new sentence, but I have a general question about the buttons vs icons: Example 1: Make payment and Pay all fines are buttons: Fees & Charges: Patron has outstanding fees & charges of 0,01. Make payment Pay all fines Example 2: Delete and Add a new message are Links with icons: 06/01/2016 Midway "WAAH" [Delete] Add a new message Should we not pick one or the other? Owen, could you take a look? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- We don't have a firm rule for this, though it's something we should consider for the interface guidelines. In general I like to use a link when it's part of a block of text like this. I don't think it's an issue which should hold up this patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53150|0 |1 is obsolete| | Attachment #53193|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 53757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53757&action=edit [PASSED QA] Bug 16861: Translatability: Fix separated "below" in circulation.tt This patch propose to fix this two entries in PO files: "See highlighted items" and "below" Also add some Font Awesome Icons To test: -Apply patch 16810 on top and this patch -Go to a patron who has overdues -See the link "See highlighted items below" with a hand down icon -Look the new plus icon to "Add a new message" to the patron. -Add a few messages and notice about the trash icon in "Delete" links Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 53758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53758&action=edit [PASSED QA] Bug 16861: (followup)Translatability: remove fa-hand-o-down icon Remove fa-hand-o-down icon accoring with QA comment 5 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16861 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #11 from Brendan Gallagher <brendan@bywatersolutions.com> --- pushed to master - Should be in the November 2016 release. Thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org