http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2010-10-31 21:06:54 UTC --- Created attachment 2726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2726 more basic unit tests to C4 modules -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2010-11-02 18:00:35 UTC --- Actually, I plan to remove the dependency of Cache::Memcached::Fast, it isn't being used by anything in Koha, and there is no immediate plans to make it be. I will create another bug for that and remove it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #6 from Chris Nighswonger <cnighswonger@foundations.edu> 2010-11-18 03:15:04 UTC --- This bug has a patch presently committed to HEAD and 3.2.x. Please take the appropriate action to update the status of this bug. Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger@foundations.ed | |u --- Comment #8 from Chris Nighswonger <cnighswonger@foundations.edu> 2010-11-30 13:49:17 UTC --- This bug has a fix which was committed to the 3.2.x branch and released in 3.2.1. Please take time to update the status of this bug and mark it RESOLVED FIXED so that it may be closed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #10 from Maxime Pelletier <pelletiermaxime@gmail.com> 2011-09-20 22:08:37 UTC --- Created attachment 5485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5485 fix whitespace in the test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-21 03:38:06 UTC --- perl t/db_dependent/Record.t 1..10 ok 1 - use C4::Record; ok 2 - error works DBD::mysql::db do failed: Unknown or incorrect time zone: 'Pacific/Auckland' at C4/Context.pm line 700, <DATA> line 496. ok 3 - testing marc2xml ok 4 - testing marc2xml ok 5 - testing xml2marc ok 6 - testing marc2dcxml ok 7 - testing marcQualified not ok 8 - testing marc2mosxml # Failed test 'testing marc2mosxml' # at t/db_dependent/Record.t line 85. # got: '<?xml version="1.0" encoding="UTF-8"?> # <mods xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://www.loc.gov/mods/v3" version="3.1" xsi:schemaLocation="http://www.loc.gov/mods/v3 http://www.loc.gov/standards/mods/v3/mods-3-1.xsd"> # <typeOfResource/> # <originInfo> # <issuance/> # </originInfo> # <recordInfo/> # </mods> # ' # expected: '<?xml version="1.0" encoding="UTF-8"?> # <mods xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://www.loc.gov/mods/v3" version="3.1" xsi:schemaLocation="http://www.loc.gov/mods/v3 http://www.loc.gov/standards/mods/v3/mods-3-1.xsd"> # <typeOfResource/> # <originInfo> # <issuance/> # </originInfo> # <recordInfo/> # </mods> # ' ok 9 - testing bibtex ok 10 - Html umlauts # Looks like you failed 1 test of 10 If i revert the patch, the test passes -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #15 from Chris Hall <chrish@catalyst.net.nz> 2011-11-22 00:29:14 UTC --- Created attachment 6373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6373 Adds missing case for boolean unit tests, adds in actual unit tests for barkertaylor Hopefully this will bump boolean's conditional coverage up to 100% and should also improve the coverage of BarkerTaylor's significantly. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2716|0 |1 is obsolete| | Attachment #2726|0 |1 is obsolete| | Attachment #6373|0 |1 is obsolete| | --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-04 06:54:01 UTC --- Created attachment 6560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6560 Bug 5327: Unit tests for C4/Exteral/BakerTaylor.pm Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6237|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-04 07:12:07 UTC --- Created attachment 6562 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6562 [SIGNED-OFF] Bug 5327 : Adding more unit tests Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> New tests run without problems. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |paul.poulain@biblibre.com --- Comment #20 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-06 18:43:30 UTC --- Chris-es, I tried to apply those patches on the branch 5327, but one of them does not apply anymore: Bug 5327: Unit tests for C4/Exteral/BakerTaylor.pm Apply? [yn] y Applying: Bug 5327: Unit tests for C4/Exteral/BakerTaylor.pm fatal: sha1 information is lacking or useless (t/Boolean.t). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 5327: Unit tests for C4/Exteral/BakerTaylor.pm When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/Bug-5327-Unit-tests-for-C4ExteralBakerTaylorpm-gQ0UGT.patch Could you rebase against the 5327 branch and update the patch please ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|pelletiermaxime@gmail.com | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #23 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-06 19:10:47 UTC --- Paul you will want to merge master into your 5327 branch, then apply them. That branch is old so will be out of date with master. We don't base patches against the branches, but against master. So if a branch is old, it needs to be brought up to date, don't rebase though, a simple merge will bring it up to master level. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6613|0 |1 is obsolete| | --- Comment #25 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-06 20:20:19 UTC --- Created attachment 6614 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6614 Bug 5327 : Fixing unit test for SQLHelper.pm -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Needs Signoff --- Comment #27 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-06 21:20:27 UTC --- 2 more requiring sign off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6620|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #30 from Liz Rea <wizzyrea@gmail.com> 2011-12-06 21:51:07 UTC --- Created attachment 6621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6621 Bug 5327 : Fixing unit test for SQLHelper.pm Signed-off-by: Liz Rea <wizzyrea@gmail.com> Confirm that all SQLHelper tests pass. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6614|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6560|0 |1 is obsolete| | --- Comment #33 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-07 15:39:38 UTC --- Comment on attachment 6560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6560 Bug 5327: Unit tests for C4/Exteral/BakerTaylor.pm This patch pushed today -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6563|0 |1 is obsolete| | --- Comment #35 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-07 15:40:28 UTC --- Comment on attachment 6563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6563 [SIGNED-OFF] Bug 5327 : Complete coverage for BackgroundJob.pm This patch pushed today -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6621|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #38 from Chris Hall <chrish@catalyst.net.nz> 2011-12-07 20:37:23 UTC --- Created attachment 6643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6643 Patch to increase boolean.t coverage I think my previous patch to Boolean.t got lost in the works, I forgot to change the count so ChrisC corrected it for me in his patch, but my patch wasnt applied, so the number of tests was invalid, Paul decreased the counter so the test would pass. Attached is patch to correct Boolean.t (both the missing case and the count). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6650|0 |1 is obsolete| | --- Comment #40 from Liz Rea <wizzyrea@gmail.com> 2011-12-08 01:18:06 UTC --- Comment on attachment 6650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6650 Bug 5327 - fixing t/db_dependent/Record.t to not fail because of whitespace. keke, ChrisC did this exact same thing *and I even signed off on it.* This attachment is hereby invalid. ;) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #42 from Duncan <duncan@catalyst.net.nz> 2011-12-08 01:49:21 UTC --- Created attachment 6655 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6655 Unit test for SIP/Sip/Checksum.pm -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #44 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-08 21:12:08 UTC --- (In reply to comment #36)

Comment on attachment 6621 [details] Bug 5327 : Fixing unit test for SQLHelper.pm

This patch pushed today, HOWEVER:

Chris, could you explain why you removed the SearchInTable tests and replace it by nothing ? I see it fixes the test, but why are those 2 tests irrelevant now ?

Because the SearchInTable function has changed, it does OR, not AND, those tests will never ever pass -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #47 from Chris Hall <chrish@catalyst.net.nz> 2011-12-08 22:06:52 UTC --- Created attachment 6682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6682 Patch removes unneeded self=shift from TTParser::unshift_token While Duncan was creating unit tests for TTParser I found an unneeded 'my $self=shift' within TTParser::unshift_token, however ::peep_token and ::next_token do not take a $self argument. No client code uses this so it shouldn't break anything. ~Chris -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Duncan <duncan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |duncan@catalyst.net.nz --- Comment #49 from Duncan <duncan@catalyst.net.nz> 2011-12-08 22:34:28 UTC --- (In reply to comment #48)

Created attachment 6683 [details] Added test coverage for TTParser

Meant to add this on the attachment, this test relies on the patch submitted by Chris in comment 47. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #51 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-13 07:04:57 UTC --- Created attachment 6727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6727 [SIGNED-OFF] Added unit tests for Sip Checksum.pm http://bugs.koha-community.org/show_bug.cgi?id=5327 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Test passes. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #53 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-13 07:05:22 UTC --- Created attachment 6729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6729 [SIGNED-OFF] Added unit tests for Scrubber http://bugs.koha-community.org/show_bug.cgi?id=5327 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Test passes. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #55 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-13 07:05:38 UTC --- Created attachment 6731 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6731 [SIGNED-OFF] Added coverage to unit test for TTParser http://bugs.koha-community.org/show_bug.cgi?id=5327 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Test passes. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6726|0 |1 is obsolete| | --- Comment #56 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-13 07:09:08 UTC --- Created attachment 6732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6732 [SIGNED-OFF] Added missing reference case to Boolean.t and corrected count http://bugs.koha-community.org/show_bug.cgi?id=5327 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Test passes. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Duncan <duncan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6795|0 |1 is obsolete| | --- Comment #59 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-15 06:21:04 UTC --- Created attachment 6805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6805 [SINGED-OFF] Bug 5327: Added unit test for C4/SIP/ILS/Transaction/RenewAll.pm http://bugs.koha-community.org/show_bug.cgi?id=5327 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Test requires a database installed using the sample data. All tests pass. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off --- Comment #61 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-15 06:25:35 UTC --- Changing to signed-off as there are a lot of patches here that are ready for QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6728|0 |1 is obsolete| | --- Comment #63 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-15 12:47:12 UTC --- Comment on attachment 6728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6728 [SIGNED-OFF] Added unit test for AuthoritiesMarc/UNIMARC.pm patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6730|0 |1 is obsolete| | --- Comment #65 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-15 12:48:04 UTC --- Comment on attachment 6730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6730 [SIGNED-OFF] Bug 5327: Patch removes unneeded self=shift from TTParser::unshift_token patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6732|0 |1 is obsolete| | --- Comment #67 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-15 12:54:47 UTC --- Comment on attachment 6732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6732 [SIGNED-OFF] Added missing reference case to Boolean.t and corrected count patch pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6730|1 |0 is obsolete| | --- Comment #69 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-15 15:13:20 UTC --- Comment on attachment 6730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6730 [SIGNED-OFF] Bug 5327: Patch removes unneeded self=shift from TTParser::unshift_token unobsoleting this patch because I'll revert it Why did I miss the patch break the tests ? I don't know. But here it is: prove xt/author/translatable-templates.t xt/author/translatable-templates.t .. 1/2 # Failed test 'opac templates are translatable' # at xt/author/translatable-templates.t line 54. # Can't locate object method "type" via package "C4::TTParser" at TmplTokenizer.pm line 324, <INPUT> line 1. # # tmpl_process3.pl: ERROR: Text extraction failed: ./xgettext.pl: Ioctl() inappropré pour un périphérique # # tmpl_process3.pl: ERROR: Will not run msgmerge # xt/author/translatable-templates.t .. 2/2 # Failed test 'intranet templates are translatable' # at xt/author/translatable-templates.t line 54. # Can't locate object method "type" via package "C4::TTParser" at TmplTokenizer.pm line 324, <INPUT> line 1. # # tmpl_process3.pl: ERROR: Text extraction failed: ./xgettext.pl: Ioctl() inappropré pour un périphérique # # tmpl_process3.pl: ERROR: Will not run msgmerge # # Looks like you failed 2 tests of 2. xt/author/translatable-templates.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/2 subtests Test Summary Report ------------------- xt/author/translatable-templates.t (Wstat: 512 Tests: 2 Failed: 2) Failed tests: 1-2 Non-zero exit status: 2 after reverting this patch, prove is OK -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #71 from Duncan <duncan@catalyst.net.nz> 2011-12-15 19:49:40 UTC --- Created attachment 6819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6819 Corrected findbin path for SIP_ILS bug 5327 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #73 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-16 06:02:28 UTC --- Created attachment 6827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6827 [SIGNED-OFF] Bug 5327: Moving SIP_ILS.t to db_dependent http://bugs.koha-community.org/show_bug.cgi?id=5327 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #75 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-16 06:03:30 UTC --- The last 3 patches for the SIP tests go together (attachments 6826-6828) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6834|0 |1 is obsolete| | --- Comment #77 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-16 14:44:58 UTC --- Comment on attachment 6834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6834 Bug 5327: Added unit test for C4/SIP/ILS/Transaction/RenewAll.pm QA comment for SIP_ILS patches: prove t/db_dependent/SIP_ILS.t t/db_dependent/SIP_ILS.t .. Subroutine new redefined at /home/paul/koha.dev/koha-community//C4/SIP/ILS.pm line 44. Subroutine find_patron redefined at /home/paul/koha.dev/koha-community//C4/SIP/ILS.pm line 55. Subroutine find_item redefined at /home/paul/koha.dev/koha-community//C4/SIP/ILS.pm line 61. Subroutine institution redefined at /home/paul/koha.dev/koha-community//C4/SIP/ILS.pm line 67. Subroutine institution_id redefined at /home/paul/koha.dev/koha-community//C4/SIP/ILS.pm line 72. Subroutine supports redefined at /home/paul/koha.dev/koha-community//C4/SIP/ILS.pm line 77. Subroutine check_inst_id redefined at /home/paul/koha.dev/koha-community//C4/SIP/ILS.pm line 82. Subroutine to_bool redefined at /home/paul/koha.dev/koha-community//C4/SIP/ILS.pm line 90. Subroutine checkout_ok redefined at /home/paul/koha.dev/koha-community//C4/SIP/ILS.pm line 99. Subroutine checkin_ok redefined at /home/paul/koha.dev/koha-community//C4/SIP/ILS.pm line 104. Subroutine status_update_ok redefined at /home/paul/koha.dev/koha-community//C4/SIP/ILS.pm line 109. Subroutine offline_ok redefined at /home/paul/koha.dev/koha-community//C4/SIP/ILS.pm line 114. Subroutine checkout redefined at /home/paul/koha.dev/koha-community//C4/SIP/ILS.pm line 128. Subroutine checkin redefined at /home/paul/koha.dev/koha-community//C4/SIP/ILS.pm line 174. Subroutine end_patron_session redefined at /home/paul/koha.dev/koha-community//C4/SIP/ILS.pm line 210. Subroutine pay_fee redefined at /home/paul/koha.dev/koha-community//C4/SIP/ILS.pm line 217. Subroutine add_hold redefined at /home/paul/koha.dev/koha-community//C4/SIP/ILS.pm line 238. Subroutine cancel_hold redefined at /home/paul/koha.dev/koha-community//C4/SIP/ILS.pm line 282. Subroutine alter_hold redefined at /home/paul/koha.dev/koha-community//C4/SIP/ILS.pm line 337. Subroutine renew redefined at /home/paul/koha.dev/koha-community//C4/SIP/ILS.pm line 382. Subroutine renew_all redefined at /home/paul/koha.dev/koha-community//C4/SIP/ILS.pm line 447. t/db_dependent/SIP_ILS.t .. ok All tests successful. The 2 follow-ups are really small, i've squashed them into 1 single commit passed QA patch pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #79 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-16 17:32:22 UTC --- unless i'm mistaking, the 2 attached patches are failed QA. updating bug status. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Sam Sanders <sam-sanders@live.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sam-sanders@live.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Connor Dewar <connor.dewar@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |connor.dewar@gmail.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Connor Dewar <connor.dewar@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff AssignedTo|gmcharlt@gmail.com |connor.dewar@gmail.com --- Comment #83 from Connor Dewar <connor.dewar@gmail.com> 2012-01-17 01:34:30 UTC --- Created attachment 7182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7182 added unit tests for C4/ClassSortRoutine/Dewey.pm -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7179|0 |1 is obsolete| | --- Comment #85 from Chris Cormack <chris@bigballofwax.co.nz> 2012-01-17 01:40:31 UTC --- Created attachment 7184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7184 Bug 5327 added unit tests for C4/Utils Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #87 from Chris Cormack <chris@bigballofwax.co.nz> 2012-01-17 01:44:17 UTC --- Created attachment 7186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7186 bug 5327 add tests for C4/ClassSortRoutine/LCC.pm Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #89 from Chris Cormack <chris@bigballofwax.co.nz> 2012-01-17 01:46:11 UTC --- Created attachment 7188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7188 bug 5327 add tests for C4/ClassSortRoutine/LCC.pm Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7182|0 |1 is obsolete| | --- Comment #91 from Chris Cormack <chris@bigballofwax.co.nz> 2012-01-17 01:49:37 UTC --- Created attachment 7190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7190 [SIGNED-OFF] Bug 5327 Added unit tests for C4/ClassSortRoutine/Dewey.pm Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Sam Sanders <sam-sanders@live.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff AssignedTo|connor.dewar@gmail.com |sam-sanders@live.com --- Comment #92 from Sam Sanders <sam-sanders@live.com> 2012-01-17 02:41:22 UTC --- Created attachment 7191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7191 tests for C4/BackgroundJob.pm -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7192|0 |1 is obsolete| | --- Comment #94 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-01-17 06:52:27 UTC --- Created attachment 7194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7194 [SIGNED-OFF] Bug 5327 Added unit tests for C4/Reports.pm Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> perl t/Reports.t b/t/Reports.t All tests complete successfully. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #97 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-17 14:20:20 UTC --- Comment on attachment 7185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7185 Bug 5327 added unit tests for C4/ClassSortRoutine/Generic QA comment: no comment, this one is OK -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #99 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-17 14:25:18 UTC --- Comment on attachment 7190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7190 [SIGNED-OFF] Bug 5327 Added unit tests for C4/ClassSortRoutine/Dewey.pm QA comment = this one is OK -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #101 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-17 14:27:57 UTC --- Comment on attachment 7195 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7195 [SIGNED-OFF] bug 5327 add tests for C4/BackgroundJob.pm QA comment: this one is OK -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7185|0 |1 is obsolete| | --- Comment #103 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-17 14:32:36 UTC --- Comment on attachment 7185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7185 Bug 5327 added unit tests for C4/ClassSortRoutine/Generic patch pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7194|0 |1 is obsolete| | --- Comment #105 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-17 14:33:10 UTC --- Comment on attachment 7194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7194 [SIGNED-OFF] Bug 5327 Added unit tests for C4/Reports.pm patch pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #107 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-17 14:34:59 UTC --- everything pushable has been pushed. The 4 attachements not pushed are failing QA for instance. Please submit an updated patch for LCC.pm & we will see if it's needed to push something for Utils, if Utils is deprecated, then please open a bug to request his removal ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #109 from Sam Sanders <sam-sanders@live.com> 2012-01-17 22:52:19 UTC --- Created attachment 7206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7206 Added unit tests for C4/Koha.pm -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Sam Sanders <sam-sanders@live.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|connor.dewar@gmail.com |sam-sanders@live.com --- Comment #111 from Sam Sanders <sam-sanders@live.com> 2012-01-18 02:41:38 UTC --- Created attachment 7209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7209 Added unit tests for C4/Ris -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Kate Henderson <kate.h@paradise.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|reason.koan@gmail.com |kate.h@paradise.net.nz --- Comment #113 from Kate Henderson <kate.h@paradise.net.nz> 2012-01-18 22:30:50 UTC --- Created attachment 7221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7221 Added unit tests for C4/Search/PazPar2.pm -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Kate Henderson <kate.h@paradise.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kate.h@paradise.net.nz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Bart Jorgensen <bart.tj@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bart.tj@gmail.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Jorgia <jorgia_m_kelsey@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jorgia_m_kelsey@hotmail.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #117 from Sam Sanders <sam-sanders@live.com> 2012-01-19 01:20:18 UTC --- Created attachment 7225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7225 Added unit tests for C4/Languages.pm -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Kate Henderson <kate.h@paradise.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|reason.koan@gmail.com |kate.h@paradise.net.nz --- Comment #119 from Kate Henderson <kate.h@paradise.net.nz> 2012-01-19 01:34:51 UTC --- Created attachment 7227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7227 Added unit tests for C4/Scheduler.pm -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7224|0 |1 is obsolete| | --- Comment #121 from Chris Hall <chrish@catalyst.net.nz> 2012-01-19 03:38:31 UTC --- Created attachment 7229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7229 Signed off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7229|0 |1 is obsolete| | --- Comment #123 from Chris Hall <chrish@catalyst.net.nz> 2012-01-19 03:42:44 UTC --- Created attachment 7231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7231 [SIGNED-OFF] added unit tests for C4/Labels.pm Forgot to set description properly, oops. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7223|0 |1 is obsolete| | --- Comment #125 from Chris Hall <chrish@catalyst.net.nz> 2012-01-19 03:52:07 UTC --- Created attachment 7233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7233 [SIGNED-OFF] added unit test for C4/Barcodes/PrinterConfig.pm -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7226|0 |1 is obsolete| | --- Comment #127 from Chris Hall <chrish@catalyst.net.nz> 2012-01-19 03:58:15 UTC --- Created attachment 7235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7235 [SIGNED-OFF] Added unit tests for C4/Creators/PDF.pm -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7227|0 |1 is obsolete| | --- Comment #129 from Chris Hall <chrish@catalyst.net.nz> 2012-01-19 04:05:25 UTC --- Created attachment 7237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7237 [SIGNED-OFF] Added unit tests for C4/Scheduler.pm -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7221|0 |1 is obsolete| | --- Comment #131 from Chris Hall <chrish@catalyst.net.nz> 2012-01-19 04:07:40 UTC --- Created attachment 7239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7239 [SIGNED-OFF] Added unit tests for C4/Search/PazPar2.pm -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7208|0 |1 is obsolete| | --- Comment #133 from Chris Hall <chrish@catalyst.net.nz> 2012-01-19 04:11:22 UTC --- Created attachment 7241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7241 [SIGNED-OFF] added unit tests for C4/SIP/ILS/Transaction/Renew.pm -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7206|0 |1 is obsolete| | --- Comment #136 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-31 16:14:24 UTC --- Comment on attachment 7206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7206 Added unit tests for C4/Koha.pm QA Comment : this patch depends on what is in the database +is(C4::Koha::GetSupportName('BK'),"Books", 'testing support name'); +is(C4::Koha::GetSupportName(''),undef, 'testing support name'); It should be in t/db_dependant. and not in t/ marking obsolete as it fails QA 2 possible fixes: * remove db_dependant from those tests & create another one in t/db_dependant * move everything to t/db_dependant -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7231|0 |1 is obsolete| | --- Comment #138 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-31 16:31:10 UTC --- Comment on attachment 7231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7231 [SIGNED-OFF] added unit tests for C4/Labels.pm this patch has been pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7233|0 |1 is obsolete| | --- Comment #140 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-31 16:31:55 UTC --- Comment on attachment 7233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7233 [SIGNED-OFF] added unit test for C4/Barcodes/PrinterConfig.pm this patch has been pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7235|0 |1 is obsolete| | --- Comment #142 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-31 16:33:45 UTC --- Comment on attachment 7235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7235 [SIGNED-OFF] Added unit tests for C4/Creators/PDF.pm this patch has been pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7237|0 |1 is obsolete| | --- Comment #144 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-31 16:34:19 UTC --- Comment on attachment 7237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7237 [SIGNED-OFF] Added unit tests for C4/Scheduler.pm this patch has been pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7239|0 |1 is obsolete| | --- Comment #146 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-31 16:35:26 UTC --- Comment on attachment 7239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7239 [SIGNED-OFF] Added unit tests for C4/Search/PazPar2.pm this patch has been pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7241|0 |1 is obsolete| | --- Comment #148 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-31 16:35:53 UTC --- Comment on attachment 7241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7241 [SIGNED-OFF] added unit tests for C4/SIP/ILS/Transaction/Renew.pm this patch has been pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7206|1 |0 is obsolete| | --- Comment #150 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-31 16:37:59 UTC --- Comment on attachment 7206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7206 Added unit tests for C4/Koha.pm changing my mind about "obsolete" = it's much easier to keep all pending patches not obsolete ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7400|0 |1 is obsolete| | --- Comment #152 from Robin Sheat <robin@catalyst.net.nz> 2012-02-01 00:41:47 UTC --- Created attachment 7402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7402 Merge remote-tracking branch 'origin/new/bug_5327' Signed-off-by: Chris Hall <chrish@catalyst.net.nz> Signed-off-by: Chris Hall <chrish@catalyst.net.nz> Signed-off-by: Chris Hall <chrish@catalyst.net.nz> Signed-off-by: Chris Hall <chrish@catalyst.net.nz> http://bugs.koha-community.org/show_bug.cgi?id=5327 Signed-off-by: Chris Hall <chrish@catalyst.net.nz> Signed-off-by: Chris Hall <chrish@catalyst.net.nz> Signed-off-by: Chris Hall <chrish@catalyst.net.nz> Signed-off-by: Chris Hall <chrish@catalyst.net.nz> Signed-off-by: Chris Hall <chrish@catalyst.net.nz> Signed-off-by: Chris Hall <chrish@catalyst.net.nz> Signed-off-by: Chris Hall <chrish@catalyst.net.nz> Signed-off-by: Chris Hall <chrish@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #154 from Robin Sheat <robin@catalyst.net.nz> 2012-02-01 00:43:37 UTC --- Created attachment 7403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7403 Bug 5327: Shifting a db dependent test to the right place Signed-off-by: Robin Sheat <robin@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Version|rel_3_4 |rel_3_6 --- Comment #156 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-01 16:37:30 UTC --- Robin / chris_c = I understood db_dependant directory as where we should put tests that work only if the database need something specific to work. A script that run subs using the database but does not depend on what is should be in t/ that's why I've pushed Csv and Reports, and am not sure the 2 patches moving them submitted yesterday are applicable. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7403|0 |1 is obsolete| | --- Comment #158 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-01 17:15:56 UTC --- Comment on attachment 7403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7403 Bug 5327: Shifting a db dependent test to the right place patch pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #160 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-03 14:47:38 UTC --- The 3 attachments not pushed are failing QA,so marking this bug failed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Severity|enhancement |major --- Comment #162 from Chris Cormack <chris@bigballofwax.co.nz> 2012-02-10 22:11:25 UTC --- New patch needs signoff and will stop the failing tests on jenkins -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6731|0 |1 is obsolete| | --- Comment #164 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-02-12 19:45:54 UTC --- Created attachment 7593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7593 Added coverage to unit test for TTParser http://bugs.koha-community.org/show_bug.cgi?id=5327 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Test passes. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jcamins@cpbibliography.com --- Comment #166 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-02-12 19:47:17 UTC --- The test for C4/Koha did not work for me, but I tested and signed off on the other three. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #168 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-13 14:15:53 UTC --- removing signed-off status, the 3 remaining patches should not be applied -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7592|0 |1 is obsolete| | --- Comment #170 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-15 09:51:08 UTC --- Comment on attachment 7592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7592 Bug 5327: Patch removes unneeded self=shift from TTParser::unshift_token This patch has been pushed, after discussion with Jared: I missed that those 2 patches had been updated and now work, so my comment 168 was wrong for them. C4/Koha.pm still un-needed though -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7593|1 |0 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #172 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 9897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9897&action=edit Bug 5327 : Fix for XISBN test, thingisbn is now handing back different results -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9897|0 |1 is obsolete| | --- Comment #173 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 9897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9897 Bug 5327 : Fix for XISBN test, thingisbn is now handing back different results This patch has been pushed, should please jenkins (seems librarything changes the returned results, making the test fail) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |robin@catalyst.net.nz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #176 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Last patch was signed off. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10656|0 |1 is obsolete| | --- Comment #178 from Mason James <mtj@kohaaloha.com> --- Created attachment 10659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10659&action=edit Bug 5327 - Unit tests required for all C4 modules renamed: Koha.t -> db_dependent/Koha.t Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Duncan <duncan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|duncan@catalyst.net.nz | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #181 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #180)

Created attachment 10660 [details] Added coverage to unit test for TTParser

http://bugs.koha-community.org/show_bug.cgi?id=5327 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Test passes.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>

Passing QA on this, test passed OK $ prove -v xt/tt_valid.t xt/tt_valid.t .. 1..2 ok 1 - TT syntax: not using TT directive within HTML tag ok 2 - Token received same as original put on stack ok All tests successful. Files=1, Tests=2, 3 wallclock secs ( 0.02 usr 0.01 sys + 2.68 cusr 0.03 csys = 2.74 CPU) Result: PASS -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10659|0 |1 is obsolete| | --- Comment #183 from Mason James <mtj@kohaaloha.com> --- Created attachment 10661 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10661&action=edit added date and ISBN tests to Koha.t modified: Koha.t $ prove -v ./Koha.t 1..5 ok 1 - use C4::Koha; ok 2 - use C4::Members; 1..6 ok 1 - Insert data in database ok 2 - GetAuthorisedValueByCode ok 3 - GetKohaImageurlFromAuthorisedValues ok 4 - lost and paid works ok 5 - Child area works ok 6 - Withdrawn works ok 3 - Authorized Values Tests 1..4 ok 1 - C4::Koha->can('GetDailyQuote') ok 2 - Got a quote based on id. ok 3 - Got a random quote. ok 4 - Got a quote based on today's date. ok 4 - Daily Quotes Test 1..7 ok 1 - slashifyDate ok 2 - xml_escape() returns empty string on undef input ok 3 - xml_escape() works as expected ok 4 - ... and does not change input in place ok 5 - _isbn_cleanup removes hyphens ok 6 - _isbn_cleanup removes parenthetical ok 7 - _isbn_cleanup converts ISBN-13 to ISBN-10 ok 5 - Date and ISBN tests ok All tests successful. Files=1, Tests=5, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.48 cusr 0.06 csys = 0.57 CPU) Result: PASS -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10660|0 |1 is obsolete| | --- Comment #185 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 10660 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10660 Added coverage to unit test for TTParser This patch pushed -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED --- Comment #187 from Paul Poulain <paul.poulain@biblibre.com> --- May I suggest that we close this bug an open a new one = 186 comments, 96 attachments, it could become hard to follow -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #189 from Chris Cormack <chris@bigballofwax.co.nz> --- Im not pushing the patch for Koha.t to stable, it should be in db_dependent It will break installing otherwise. Please push a follow up so I can push them both -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10660|0 |1 is obsolete| | --- Comment #191 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 10660 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10660 Added coverage to unit test for TTParser This patch pushed -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.