[Bug 40245] New: Support option to display firstname in memberresultst
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 Bug ID: 40245 Summary: Support option to display firstname in memberresultst Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: Chip.Halvorsen@WestlakeLibrary.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Circulation staff would find it very useful to see firstname in addition to preferred_name in the patron search results table (memberresultst). Currently at 24.11+, only the preferred name is displayed. One way to handle this might be to add firstname as a line at between address and email address. SMITH, KAT 123 MAIN ST. ANYTOWN, STATE/PROVINCE POSTCODE Firstname: KATELYNN Email: X@Y.Z Or we might want to put the firstname in parenthesis. SMITH, KAT (Firstname: KATELYNN) 123 MAIN ST. ANYTOWN, STATE/PROVINCE POSTCODE Email: X@Y.Z Having the firstname appear somewhere would help disambiguate similar patron names in the search results. Even better would be logic that only displayed the Firstname when it differs from the Preferred_name. This should be made optional. Some libraries might not want firstname to appear here, to avoid accidentally deadnaming a patron. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 Chip Halvorsen <Chip.Halvorsen@WestlakeLibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Chip.Halvorsen@WestlakeLibr | |ary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cj.lynce@westlakelibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |cj.lynce@westlakelibrary.or |ity.org |g Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 --- Comment #1 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Created attachment 184501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184501&action=edit Bug 40245: Add new system preference ShowFirstIfDifferentThanPreferred Adds a new system preference ShowFirstIfDifferentThanPreferred to allow a patron's firstname to be shown in search results when different than their preferred name. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 --- Comment #2 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Created attachment 184502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184502&action=edit Bug 40245: Show firstname in patron search results when different than preferred_name This patch shows the patron's firstname in search results and autosuggestions when thier preferred_name is different than their first name. Requires that sysprep ShowFirstIfDifferentThanPreferred is enabled. When disabled, only the preferred name shows in results. Test plan: 0. Apply patches and login to the staff interface. 1. Edit a patron to give a different preferred name than first. 2. Return to home page and search for the patron in the quick-search bar. 3. Verify patron shows up in autosuggest list, showing preferred name only. 4. Verify patron shows up in regular list (member.pl) with preferred name showing only. 5. Change syspref ShowFirstIfDifferentThanPreferred to "Show" and save. 6. Return to home page and search for the patron in the quick-search bar. 7. Verify patron shows up in autosuggest list, showing preferred name, and firstname in brackets. 8. Verify patron shows up in regular list (member.pl) with preferred name, and firstname in brackets. Sponsored-by: Westlake Porter Public Library <https://westlakelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #3 from CJ Lynce <cj.lynce@westlakelibrary.org> --- *** Bug 40484 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 Cheryl <clackman@fargolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman@fargolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184502|0 |1 is obsolete| | --- Comment #4 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 184637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184637&action=edit Bug 40245: Show firstname in patron search results when different than preferred_name This patch shows the patron's firstname in search results and autosuggestions when thier preferred_name is different than their first name. Requires that sysprep ShowFirstIfDifferentThanPreferred is enabled. When disabled, only the preferred name shows in results. Test plan: 0. Apply patches and login to the staff interface. 1. Edit a patron to give a different preferred name than first. 2. Return to home page and search for the patron in the quick-search bar. 3. Verify patron shows up in autosuggest list, showing preferred name only. 4. Verify patron shows up in regular list (member.pl) with preferred name showing only. 5. Change syspref ShowFirstIfDifferentThanPreferred to "Show" and save. 6. Return to home page and search for the patron in the quick-search bar. 7. Verify patron shows up in autosuggest list, showing preferred name, and firstname in brackets. 8. Verify patron shows up in regular list (member.pl) with preferred name, and firstname in brackets. Sponsored-by: Westlake Porter Public Library <https://westlakelibrary.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184501|0 |1 is obsolete| | --- Comment #5 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 184638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184638&action=edit Bug 40245: Add new system preference ShowFirstIfDifferentThanPreferred Adds a new system preference ShowFirstIfDifferentThanPreferred to allow a patron's firstname to be shown in search results when different than their preferred name. Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184637|0 |1 is obsolete| | --- Comment #6 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 184639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184639&action=edit Bug 40245: Show firstname in patron search results when different than preferred_name This patch shows the patron's firstname in search results and autosuggestions when thier preferred_name is different than their first name. Requires that sysprep ShowFirstIfDifferentThanPreferred is enabled. When disabled, only the preferred name shows in results. Test plan: 0. Apply patches and login to the staff interface. 1. Edit a patron to give a different preferred name than first. 2. Return to home page and search for the patron in the quick-search bar. 3. Verify patron shows up in autosuggest list, showing preferred name only. 4. Verify patron shows up in regular list (member.pl) with preferred name showing only. 5. Change syspref ShowFirstIfDifferentThanPreferred to "Show" and save. 6. Return to home page and search for the patron in the quick-search bar. 7. Verify patron shows up in autosuggest list, showing preferred name, and firstname in brackets. 8. Verify patron shows up in regular list (member.pl) with preferred name, and firstname in brackets. Sponsored-by: Westlake Porter Public Library <https://westlakelibrary.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Thanks, CJ! This looks nice and works as advertised! Testing notes: - After applying patch, run updatedatabase and clear browser cache -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184639|0 |1 is obsolete| | --- Comment #8 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 185601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185601&action=edit Bug 40245: Show firstname in patron search results when different than preferred_name This patch shows the patron's firstname in search results and autosuggestions when thier preferred_name is different than their first name. Requires that sysprep ShowFirstIfDifferentThanPreferred is enabled. When disabled, only the preferred name shows in results. Test plan: 0. Apply patches and login to the staff interface. 1. Edit a patron to give a different preferred name than first. 2. Return to home page and search for the patron in the quick-search bar. 3. Verify patron shows up in autosuggest list, showing preferred name only. 4. Verify patron shows up in regular list (member.pl) with preferred name showing only. 5. Change syspref ShowFirstIfDifferentThanPreferred to "Show" and save. 6. Return to home page and search for the patron in the quick-search bar. 7. Verify patron shows up in autosuggest list, showing preferred name, and firstname in brackets. 8. Verify patron shows up in regular list (member.pl) with preferred name, and firstname in brackets. Sponsored-by: Westlake Porter Public Library <https://westlakelibrary.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Chip <chip.halvorsen@westlakelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 --- Comment #9 from Chip Halvorsen <Chip.Halvorsen@WestlakeLibrary.org> --- Tested and everything works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184638|0 |1 is obsolete| | --- Comment #10 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 185602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185602&action=edit Bug 40245: Add new system preference ShowFirstIfDifferentThanPreferred Adds a new system preference ShowFirstIfDifferentThanPreferred to allow a patron's firstname to be shown in search results when different than their preferred name. Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Chip <chip.halvorsen@westlakelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185601|0 |1 is obsolete| | --- Comment #11 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 185603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185603&action=edit Bug 40245: Show firstname in patron search results when different than preferred_name This patch shows the patron's firstname in search results and autosuggestions when thier preferred_name is different than their first name. Requires that sysprep ShowFirstIfDifferentThanPreferred is enabled. When disabled, only the preferred name shows in results. Test plan: 0. Apply patches and login to the staff interface. 1. Edit a patron to give a different preferred name than first. 2. Return to home page and search for the patron in the quick-search bar. 3. Verify patron shows up in autosuggest list, showing preferred name only. 4. Verify patron shows up in regular list (member.pl) with preferred name showing only. 5. Change syspref ShowFirstIfDifferentThanPreferred to "Show" and save. 6. Return to home page and search for the patron in the quick-search bar. 7. Verify patron shows up in autosuggest list, showing preferred name, and firstname in brackets. 8. Verify patron shows up in regular list (member.pl) with preferred name, and firstname in brackets. Sponsored-by: Westlake Porter Public Library <https://westlakelibrary.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Chip <chip.halvorsen@westlakelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185602|0 |1 is obsolete| | --- Comment #12 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 186732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186732&action=edit Bug 40245: Add new system preference ShowFirstIfDifferentThanPreferred Adds a new system preference ShowFirstIfDifferentThanPreferred to allow a patron's firstname to be shown in search results when different than their preferred name. Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Chip <chip.halvorsen@westlakelibrary.org> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185603|0 |1 is obsolete| | --- Comment #13 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 186733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186733&action=edit Bug 40245: Show firstname in patron search results when different than preferred_name This patch shows the patron's firstname in search results and autosuggestions when thier preferred_name is different than their first name. Requires that sysprep ShowFirstIfDifferentThanPreferred is enabled. When disabled, only the preferred name shows in results. Test plan: 0. Apply patches and login to the staff interface. 1. Edit a patron to give a different preferred name than first. 2. Return to home page and search for the patron in the quick-search bar. 3. Verify patron shows up in autosuggest list, showing preferred name only. 4. Verify patron shows up in regular list (member.pl) with preferred name showing only. 5. Change syspref ShowFirstIfDifferentThanPreferred to "Show" and save. 6. Return to home page and search for the patron in the quick-search bar. 7. Verify patron shows up in autosuggest list, showing preferred name, and firstname in brackets. 8. Verify patron shows up in regular list (member.pl) with preferred name, and firstname in brackets. Sponsored-by: Westlake Porter Public Library <https://westlakelibrary.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Chip <chip.halvorsen@westlakelibrary.org> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |A new system preference release notes| |'ShowFirstIfDifferentThanPr | |eferred' toggles the | |ability for a patron's | |documented first name to be | |displayed alongside their | |Preferred name, when | |different, during patron | |search. This allows for | |library staff to easier | |identify and distinguish | |between patron record with | |similar names or when an ID | |does not match the patron's | |preferred name. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|emily.lamancusa@montgomeryc |Laura.escamilla@bywatersolu |ountymd.gov |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Should we add a Cypress test? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- I think we should have "Patron" and "Firstname" in the name of the pref. The current version "ShowFirstIfDifferentThanPreferred" is confusing IMO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- 1. What does "showlegal" mean? 2. var showFirstIfDifferentThanPreferred = [% Koha.Preference('ShowFirstIfDifferentThanPreferred') | html %]; Should be var showFirstIfDifferentThanPreferred = [% Koha.Preference('ShowFirstIfDifferentThanPreferred') ? 1 : 0 | html %]; To prevent a JS error if the pref is not set. 3. js-patron-format.inc is going to be removed on bug 40958, in favor of a js file, and the TT variable won't be accessible. Why don't you pass the "showFirstIfDifferentThanPreferred" flag from the patron search if the pref is set? You won't need to check the pref in the inc file 4. Commit message states that it affects "search results and autosuggestions" but it's actually all patron searches (bug title should also be adjusted) 5. (In reply to Lucas Gass (lukeg) from comment #14)
Should we add a Cypress test?
Yes, that would be great! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- Feel free to ask if you have questions or need help! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 --- Comment #18 from CJ Lynce <cj.lynce@westlakelibrary.org> --- (In reply to Jonathan Druart from comment #16)
1. What does "showlegal" mean? Show legal name (vs nickname or dead name), though in retrospect, 'showfirstname' would be more appropriate and match other language.
2. [...] Thanks for catching, I'll make that change (and remember for next time)
3. [...] Good idea, and thanks for pointing out bug 40958. I'll adjust to incorporate those changes.
4. Commit message states that it affects "search results and autosuggestions" but it's actually all patron searches (bug title should also be adjusted)
Thanks and good point, I will adjust.
5. (In reply to Lucas Gass (lukeg) from comment #14)
Should we add a Cypress test?
I might need some help on this one, I've not written Cypress tests before. Is there a past bug or two that has some good Koha-related examples to look at? Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 --- Comment #19 from CJ Lynce <cj.lynce@westlakelibrary.org> --- (In reply to Jonathan Druart from comment #15)
I think we should have "Patron" and "Firstname" in the name of the pref. The current version "ShowFirstIfDifferentThanPreferred" is confusing IMO.
Is there a limit on how long a system pref name could/should be? ShowPatronFirstnameIfDifferentThanPreferredname is more clear, but long (48 chr) It is shorter than PatronSelfRegistrationExpireTemporaryAccountsDelay (51 chr) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to CJ Lynce from comment #18)
(In reply to Jonathan Druart from comment #16)
5. (In reply to Lucas Gass (lukeg) from comment #14)
Should we add a Cypress test?
I might need some help on this one, I've not written Cypress tests before. Is there a past bug or two that has some good Koha-related examples to look at?
I have spent some time to write some tests for main. And all the bugs in the queue should be based on it. See bug 41003. You will see that your patch breaks it (because of the changes in autocomplete, other_name is now missing) We already have: Bug 40958 - Move patron_to_html (from js-patron-format.inc) to a standalone JS file Bug 40995 - Patron search autocomplete adds extraneous spacing and punctuation when patron lacks surname In this second one I suggested to use patron-format for the autocomplete result. I think it is good for this change (40245) actually: you won't need to adjust much patron_autocomplete, only to pass the "show first if different" flag. (In reply to CJ Lynce from comment #19)
(In reply to Jonathan Druart from comment #15)
I think we should have "Patron" and "Firstname" in the name of the pref. The current version "ShowFirstIfDifferentThanPreferred" is confusing IMO.
Is there a limit on how long a system pref name could/should be? ShowPatronFirstnameIfDifferentThanPreferredname is more clear, but long (48 chr) It is shorter than PatronSelfRegistrationExpireTemporaryAccountsDelay (51 chr)
The max length is 50. And PatronSelfRegistrationExpireTemporaryAccountsDelay is 50 char length ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186732|0 |1 is obsolete| | --- Comment #21 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Created attachment 187891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187891&action=edit Bug 40245: Add new system preference ShowPatronFirstnameIfDifferentThanPreferredname Adds a new system preference ShowPatronFirstnameIfDifferentThanPreferredname to allow a patron's firstname to be shown in search results when different than their preferred name. Sponsored-by: Westlake Porter Public Library <https://westlakelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186733|0 |1 is obsolete| | --- Comment #22 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Created attachment 187892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187892&action=edit Bug 40245: Show firstname in patron search results when different than preferred_name This patch shows the patron's firstname in patron search results and autosuggestions when the patrons preferred_name is different than their first name. Requires that the ShowPatronFirstnameIfDifferentThanPreferredname system preference is enabled. Test plan: 0. Apply patches and login to the staff interface. 1. Edit a patron to give a different preferred name than firstname. 2. Return to home page and search for the patron in the quick-search bar. 3. Verify patron shows up in autosuggest list, showing preferred name only. 4. Verify patron shows up in regular list (member.pl) with preferred name showing only. 5. Change syspref ShowFirstIfDifferentThanPreferred to "Show" and save. 6. Return to home page and search for the patron in the quick-search bar. 7. Verify patron shows up in autosuggest list, showing preferred name, and firstname in brackets. 8. Verify patron shows up in regular list (member.pl) with preferred name, and firstname in brackets. Sponsored-by: Westlake Porter Public Library <https://westlakelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40995 Status|Failed QA |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 [Bug 40995] Patron search autocomplete adds extraneous spacing and punctuation when patron lacks surname -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 --- Comment #23 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Created attachment 187893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187893&action=edit Bug 40245: Update cypress test to handle ShowPatronFirstnameIfDifferentThanPreferredname Updates patron format cypress tests to allow for ShowPatronFirstnameIfDifferentThanPreferredname -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 --- Comment #24 from CJ Lynce <cj.lynce@westlakelibrary.org> --- These new patches incorporate previous suggestions. Additionally, I changed the display behavior of the `Firstname` when the feature is turned on and preferred_name is different for a patron; it now displays in addition to the `othernames`, and not instead of `othernames` as it did originally. It adds slightly to the length of the overall patron name in search results, but will better accommodate organizations that use both `preferred_name` and `othernames`. For the Cypress tests, I adjusted the existing patron displays tests from previous bugs (bug 40995, bug 32176, bug 41003), to accommodate the addition of `preferred_name`. I welcome any feedback! Thanks for the help and suggestions thus far. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Support option to display |Support option to display |firstname in memberresultst |firstname in patron search | |results when different than | |preferred_name -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187893|0 |1 is obsolete| | --- Comment #25 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Created attachment 187943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187943&action=edit Bug 40245: Update cypress tests to handle ShowPatronFirstnameIfDifferentThanPreferredname Updates patron format cypress tests to allow for ShowPatronFirstnameIfDifferentThanPreferredname Test Plan: -Install Patch -On command line, in koha root directory, run `cypress run --spec t/cypress/integration/Patron/Format.ts` -Check to make all tests pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187891|0 |1 is obsolete| | --- Comment #26 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 188112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188112&action=edit Bug 40245: Add new system preference ShowPatronFirstnameIfDifferentThanPreferredname Adds a new system preference ShowPatronFirstnameIfDifferentThanPreferredname to allow a patron's firstname to be shown in search results when different than their preferred name. Sponsored-by: Westlake Porter Public Library <https://westlakelibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187892|0 |1 is obsolete| | --- Comment #27 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 188113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188113&action=edit Bug 40245: Show firstname in patron search results when different than preferred_name This patch shows the patron's firstname in patron search results and autosuggestions when the patrons preferred_name is different than their first name. Requires that the ShowPatronFirstnameIfDifferentThanPreferredname system preference is enabled. Test plan: 0. Apply patches and login to the staff interface. 1. Edit a patron to give a different preferred name than firstname. 2. Return to home page and search for the patron in the quick-search bar. 3. Verify patron shows up in autosuggest list, showing preferred name only. 4. Verify patron shows up in regular list (member.pl) with preferred name showing only. 5. Change syspref ShowFirstIfDifferentThanPreferred to "Show" and save. 6. Return to home page and search for the patron in the quick-search bar. 7. Verify patron shows up in autosuggest list, showing preferred name, and firstname in brackets. 8. Verify patron shows up in regular list (member.pl) with preferred name, and firstname in brackets. Sponsored-by: Westlake Porter Public Library <https://westlakelibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 --- Comment #28 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 188114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188114&action=edit Bug 40245: Update cypress test to handle ShowPatronFirstnameIfDifferentThanPreferredname Updates patron format cypress tests to allow for ShowPatronFirstnameIfDifferentThanPreferredname Test Plan: -Install Patch -On command line, in koha root directory, run `cypress run --spec t/cypress/integration/Patron/Format.ts` -Check to make all tests pass Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187943|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188112|0 |1 is obsolete| | Attachment #188113|0 |1 is obsolete| | Attachment #188114|0 |1 is obsolete| | --- Comment #29 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 188811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188811&action=edit Bug 40245: Add new system preference ShowPatronFirstnameIfDifferentThanPreferredname Adds a new system preference ShowPatronFirstnameIfDifferentThanPreferredname to allow a patron's firstname to be shown in search results when different than their preferred name. Sponsored-by: Westlake Porter Public Library <https://westlakelibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 --- Comment #30 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 188812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188812&action=edit Bug 40245: Show firstname in patron search results when different than preferred_name This patch shows the patron's firstname in patron search results and autosuggestions when the patrons preferred_name is different than their first name. Requires that the ShowPatronFirstnameIfDifferentThanPreferredname system preference is enabled. Test plan: 0. Apply patches and login to the staff interface. 1. Edit a patron to give a different preferred name than firstname. 2. Return to home page and search for the patron in the quick-search bar. 3. Verify patron shows up in autosuggest list, showing preferred name only. 4. Verify patron shows up in regular list (member.pl) with preferred name showing only. 5. Change syspref ShowFirstIfDifferentThanPreferred to "Show" and save. 6. Return to home page and search for the patron in the quick-search bar. 7. Verify patron shows up in autosuggest list, showing preferred name, and firstname in brackets. 8. Verify patron shows up in regular list (member.pl) with preferred name, and firstname in brackets. Sponsored-by: Westlake Porter Public Library <https://westlakelibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 --- Comment #31 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 188813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188813&action=edit Bug 40245: Update cypress test to handle ShowPatronFirstnameIfDifferentThanPreferredname Updates patron format cypress tests to allow for ShowPatronFirstnameIfDifferentThanPreferredname Test Plan: -Install Patch -On command line, in koha root directory, run `cypress run --spec t/cypress/integration/Patron/Format.ts` -Check to make all tests pass Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|Laura.escamilla@bywatersolu |nick@bywatersolutions.com |tions.com | CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 Kristi Krueger <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 --- Comment #32 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1118 CC| |david@davidnind.com Documentation| |David Nind contact| | --- Comment #33 from David Nind <david@davidnind.com> --- I've updated the manual with the new system preference https://koha-community.org/manual/latest/en/html/patronspreferences.html#sho... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42167 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Pushed to main |Needs documenting --- Comment #34 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Not backported to 25.05.x as this is an enhancement but I’m happy to revisit if needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org