[Bug 5741] New: Extra comma causes JavaScript error in Internet Explorer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5741 Summary: Extra comma causes JavaScript error in Internet Explorer Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: ASSIGNED Severity: normal Priority: P5 Component: Circulation AssignedTo: oleonard@myacpl.org ReportedBy: oleonard@myacpl.org QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Estimated Hours: 0.0 A trailing comma on the last item causes an error: Calendar.setup( { inputField : "newduedate", ifFormat : "<!-- TMPL_VAR NAME="DHTMLcalendar_dateformat" -->", button : "newduedate_button", disableFunc : validate1, dateStatusFunc : validate1, } ); See: http://wiki.koha-community.org/wiki/Coding_Guidelines#JavaScript -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5741 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-02-11 17:42:14 UTC --- Created attachment 3130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3130 Proposed fix -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5741 --- Comment #2 from Reed Wade <reed@catalyst.net.nz> 2011-02-15 01:05:04 UTC --- Created attachment 3154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3154 removes stray comma at end of js list in 8 files This one probably obsoletes the earlier proposed fix. It covers more cases. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5741 Reed Wade <reed@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |reed@catalyst.net.nz Patch Status|--- |Needs Signoff Change sponsored?|--- |Sponsored --- Comment #3 from Reed Wade <reed@catalyst.net.nz> 2011-02-15 01:06:28 UTC --- Catalyst work on this item sponsored by Opus. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5741 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-02-15 18:01:20 UTC --- *** Bug 5762 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5741 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Needs Signoff |Patch Pushed --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> 2011-02-20 07:33:20 UTC --- Signed off and pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5741 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |julian.maurice@biblibre.com Resolution| |FIXED --- Comment #6 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-03-07 09:39:39 UTC --- This bug is mentioned in: Fix for Bug 5741 - Extra comma causes JavaScript error in Internet Explorer http://lists.koha-community.org/pipermail/koha-patches/2011-February/013834.... Bug 5741 - Extra comma causes JavaScript error in Internet Explorer http://lists.koha-community.org/pipermail/koha-patches/2011-February/013865.... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org