[Bug 9572] New: Opac info tooltip from branches is not well positioned
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9572 Bug ID: 9572 Summary: Opac info tooltip from branches is not well positioned Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de Created attachment 15160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15160&action=edit screenshot While testing new features in 3.10.2 I added following HTML code (sample opening times in German) to the OPAC info field of one of the branches: <b>Öffnungszeiten</b> <table> <tr> <td>Montag - Donnerstag</td><td>8-20 Uhr</td> </tr> <tr> <td>Freitag</td><td>8-18 Uhr</td> </tr> </table> In OPAC the tooltip shows up when hovering the mouse over the library name, but it's below the footer on the page and for that sometimes outside of view depending on the size of the browser window (see screenshot). It would be nice if the tooltip could be positioned closer to the library name/items table/mouse cursor. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9572 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9420 Severity|trivial |normal --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- This feature broke when we upgraded tabs handling to the latest version of jQueryUI. Something about the way tabs are displayed confuses how the mouse position is reported by JavaScript. This should probably be reworked to use one of the UI libraries we already have (or will have): jQueryUI or Bootstrap. A jQueryUI version will require a jQueryUI upgrade, and of course a Bootstrap version will require approval of the Bootstrap patches on Bug 9420. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9572 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, I noticed 9420 has been pushed, maybe you can take another look at this? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9572 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9572 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15923&action=edit Bug 9572 - Opac info tooltip from branches is not well positioned This patch removes the jQuery plugin previously used to display the library information tooltip on opac-detail.pl and implements the functionality using jQueryUI's tooltip widget. jQueryUI has been upgraded to 1.9.2 in the process, which required some ammendments to jQueryUI-related CSS. To test, make sure at least one of your libraries has "OPAC info" stored as part of its configuration. View a record in the OPAC which is owned by that library. Hover over the library's name in the holdings table and you should see a properly-positioned tooltip showing the "OPAC info." Also test other jQueryUI-related functionality to confirm that the upgrade didn't break anything: Tabs and datepickers should still work correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9572 Pierre Angot <tredok.pierre@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tredok.pierre@gmail.com --- Comment #4 from Pierre Angot <tredok.pierre@gmail.com> --- Handhover is correct. But Opac Info also appears under the library name. Is it normal ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9572 Frederic Durand <frederic.durand@unilim.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic.durand@unilim.fr --- Comment #5 from Frederic Durand <frederic.durand@unilim.fr> --- I've seen it with Fridolyn, it s about sandbox using specific CSS. I ve tested it without it, all is OK. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9572 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain@biblibre.com --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Frederic Durand <frederic.durand@unilim.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9572 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15923|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9572 --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16337 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16337&action=edit Bug 9572 - Opac info tooltip from branches is not well positioned This patch removes the jQuery plugin previously used to display the library information tooltip on opac-detail.pl and implements the functionality using jQueryUI's tooltip widget. jQueryUI has been upgraded to 1.9.2 in the process, which required some ammendments to jQueryUI-related CSS. To test, make sure at least one of your libraries has "OPAC info" stored as part of its configuration. View a record in the OPAC which is owned by that library. Hover over the library's name in the holdings table and you should see a properly-positioned tooltip showing the "OPAC info." Also test other jQueryUI-related functionality to confirm that the upgrade didn't break anything: Tabs and datepickers should still work correctly. Signed-off-by: Frederic Durand <frederic.durand@unilim.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9572 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9572 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16337|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16925&action=edit [PASSED QA] Bug 9572 - Opac info tooltip from branches is not well positioned This patch removes the jQuery plugin previously used to display the library information tooltip on opac-detail.pl and implements the functionality using jQueryUI's tooltip widget. jQueryUI has been upgraded to 1.9.2 in the process, which required some ammendments to jQueryUI-related CSS. To test, make sure at least one of your libraries has "OPAC info" stored as part of its configuration. View a record in the OPAC which is owned by that library. Hover over the library's name in the holdings table and you should see a properly-positioned tooltip showing the "OPAC info." Also test other jQueryUI-related functionality to confirm that the upgrade didn't break anything: Tabs and datepickers should still work correctly. Signed-off-by: Frederic Durand <frederic.durand@unilim.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely in prog theme, feature seems not to be available for ccsr yet. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9572 --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 17123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17123&action=edit Bug 9572 follow-up: duplicate jQueryUI upgrade in CCSR -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9572 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org