https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Inventory: working title 2 |working title -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 69116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69116&action=edit Bug 19585: Inventory: Allow additional separators in a barcode file This patch makes \n, \r, |, comma and semicolon all valid separators between barcodes passed to inventory. An additional grep removes empty barcodes. Test plan: Upload a barcode file that contains various allowed separators. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69116|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 69117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69117&action=edit Bug 19585: Inventory: Allow additional separators in a barcode file This patch makes \n, \r, |, comma and semicolon all valid separators between barcodes passed to inventory. An additional grep removes empty barcodes. (Note: The grep looks for at least one non-whitespace character. We could be more specific, but this allows for more flexibility like testing with alphanumeric barcodes etc.) Test plan: Upload a barcode file that contains various allowed separators. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69118|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 69154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69154&action=edit Bug 19585: Inventory: Allow additional separators in a barcode file This patch makes \n, \r, |, comma, semicolon and hyphen ('-') all valid separators between barcodes passed to inventory. An additional grep removes empty barcodes. (Note: The grep looks for at least one non-whitespace character. We could be more specific, but this allows for more flexibility like testing with alphanumeric barcodes etc.) Test plan: Upload a barcode file that contains various allowed separators. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585 jwayway@hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jwayway@hotmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70535|0 |1 is obsolete| | --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 70625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70625&action=edit Bug 19585: Inventory: Allow additional separators in a barcode file This patch makes \n, \r, |, comma, semicolon and hyphen ('-') all valid separators between barcodes passed to inventory. An additional grep removes empty barcodes. (Note: The grep looks for at least one non-whitespace character. We could be more specific, but this allows for more flexibility like testing with alphanumeric barcodes etc.) Test plan: Upload a barcode file that contains various allowed separators. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jenny Way <jwayway@hotmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #10 from Frédéric Demians <frederic@tamil.fr> --- And if a library has barcodes with hyphens (-)? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585 --- Comment #12 from Frédéric Demians <frederic@tamil.fr> --- When playing with this issue, I was comparing inventory tool with Batch item modification tool. Both tools accept as input a barcodes file. Barcodes with hyphen are OK in Batch item modification. This regex is used to split file lines: /[\r\n]/ Barcodes with hyphen are not OK in Inventory tool. This regex is used: /[\n\r,;|-]/ Wouldn't it make sense to have the same splitting logic in both places? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- But we should move this to a new bug as this has already been pushed. -- You are receiving this mail because: You are watching all bug changes.