[Bug 6913] New: Improving koha-list and koha-create
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6913 Bug #: 6913 Summary: Improving koha-list and koha-create Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Packaging AssignedTo: robin@catalyst.net.nz ReportedBy: robin@catalyst.net.nz QAContact: koha-bugs@lists.koha-community.org A place to track some patches I got sent that add some niceness to these scripts. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6913 --- Comment #1 from Robin Sheat <robin@catalyst.net.nz> 2011-09-25 23:14:10 UTC --- Created attachment 5583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5583 Bug 6913 - change how ports are handled by koha-create This does two things: * Allows OPACPORT to be specified to change the default OPAC port, * removes the port number from the ServerName directive, as it's already handled by the VirtualHost declaration. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6913 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6913 --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2011-10-08 16:04:22 UTC --- Created attachment 5800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5800 Bug 6913 - change how ports are handled by koha-create This does two things: * Allows OPACPORT to be specified to change the default OPAC port, * removes the port number from the ServerName directive, as it's already handled by the VirtualHost declaration. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6913 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcamins@cpbibliography.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6913 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5583|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6913 --- Comment #3 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2011-10-08 19:52:14 UTC --- Created attachment 5803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5803 Follow-up patch This follow-up patch has not been signed off yet! Only the first one. Bug 6913: More options for koha-create and koha-remove This commit makes koha-create more flexible by adding a number of command-line and configuration options. The biggest change is to add support for pre-determined MySQL credentials using a file in /etc/koha/passwd (for security reasons, if you use this feature, make sure the file is not world-readable). The configuration file has the following format: instance:user:password:database The database is optional, but the other two are both required if you want to specify MySQL credentials. If no credentials are specified for a given instance, the standard koha_instance username and an auto-generated password are used. The following additional command line options are now available: * --use-db - use a pre-existing database, see also --database * --database - specify the name of the mysql database (still defaults to koha_instance) * --passwdfile - specify a custom (Koha) passwd file for MySQL credentials The following additional variables are now available (for use in koha-sites.conf or a custom config file): * OPACPORT (previously added but not documented) - port on which the OPAC should be served * OPACPREFIX - prefix for the OPAC's virtual host * OPACSUFFIX - suffix for the OPAC's virtual host This commit also adds the --keep-mysql option to koha-remove, which, if specified, will prevent koha-remove from deleting the database or MySQL user when removing an instance. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6913 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5803|0 |1 is obsolete| | --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2011-10-10 02:40:08 UTC --- Created attachment 5821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5821 Revised follow-up patch This patch corrects an error in the mysql command line arguments that caused problems with some versions of MySQL. This patch still has not been signed off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6913 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no Patch Status|Signed Off |Needs Signoff --- Comment #5 from Magnus Enger <magnus@enger.priv.no> 2011-10-13 14:50:46 UTC --- The last comment from Jared seems to imply that patch status should be Needs Signoff, so I'm setting it that way. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6913 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |Rel_3_8 --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-24 11:38:06 UTC --- Updating Version : This ENH will be for Koha 3.8 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6913 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|Rel_3_8 |master --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-25 15:05:40 UTC --- Bug versionned for master. entries will be made against rel_3_8 once the patch has been applied (see thread about that on koha-devel yesterday) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6913 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5821|0 |1 is obsolete| | --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2011-12-20 18:31:42 UTC --- Created attachment 6890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6890 Bug 6913: More options for koha-create and koha-remove This commit makes koha-create more flexible by adding a number of command-line and configuration options. The biggest change is to add support for pre-determined MySQL credentials using a file in /etc/koha/passwd (for security reasons, if you use this feature, make sure the file is not world-readable). The configuration file has the following format: instance:user:password:database The database is optional, but the other two are both required if you want to specify MySQL credentials. If no credentials are specified for a given instance, the standard koha_instance username and an auto-generated password are used. The following additional command line options are now available: * --use-db - use a pre-existing database, see also --database * --database - specify the name of the mysql database (still defaults to koha_instance) * --passwdfile - specify a custom (Koha) passwd file for MySQL credentials The following additional variables are now available (for use in koha-sites.conf or a custom config file): * OPACPORT (previously added but not documented) - port on which the OPAC should be served * OPACPREFIX - prefix for the OPAC's virtual host * OPACSUFFIX - suffix for the OPAC's virtual host This commit also adds the --keep-mysql option to koha-remove, which, if specified, will prevent koha-remove from deleting the database or MySQL user when removing an instance. Rebased on latest Master as of 20 December 2011 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6913 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5800|0 |1 is obsolete| | --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-20 21:06:46 UTC --- Created attachment 6892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6892 Bug 6913 - change how ports are handled by koha-create This does two things: * Allows OPACPORT to be specified to change the default OPAC port, * removes the port number from the ServerName directive, as it's already handled by the VirtualHost declaration. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6913 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6890|0 |1 is obsolete| | --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-20 21:09:38 UTC --- Created attachment 6893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6893 Bug 6913: More options for koha-create and koha-remove This commit makes koha-create more flexible by adding a number of command-line and configuration options. The biggest change is to add support for pre-determined MySQL credentials using a file in /etc/koha/passwd (for security reasons, if you use this feature, make sure the file is not world-readable). The configuration file has the following format: instance:user:password:database The database is optional, but the other two are both required if you want to specify MySQL credentials. If no credentials are specified for a given instance, the standard koha_instance username and an auto-generated password are used. The following additional command line options are now available: * --use-db - use a pre-existing database, see also --database * --database - specify the name of the mysql database (still defaults to koha_instance) * --passwdfile - specify a custom (Koha) passwd file for MySQL credentials The following additional variables are now available (for use in koha-sites.conf or a custom config file): * OPACPORT (previously added but not documented) - port on which the OPAC should be served * OPACPREFIX - prefix for the OPAC's virtual host * OPACSUFFIX - suffix for the OPAC's virtual host This commit also adds the --keep-mysql option to koha-remove, which, if specified, will prevent koha-remove from deleting the database or MySQL user when removing an instance. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6913 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6913 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-02 08:16:47 UTC --- QA comment * nothing to say about the code, everything consistent and clearly written * haven't tested it myself, but chris_c is a trustable tester passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6913 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-02 08:18:00 UTC --- Patch pushed, versionned for 3.8 as this patch contains improvements that should be announced & explained widely. chris_n, is you disagree, let me know -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org