https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 66897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66897&action=edit Bug 19263: Rancor - Add auto-001 widget WIP code - tied to authorised values for 001 field to set numebrs -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66897|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 76864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76864&action=edit Bug 19263: Rancor - Add auto-001 widget To test: 1 - Define a new authorised valued category "CONTROL_NUM_SEQUENCE" 2 - Add a value/sequence The authorised_value is the starting value - shoudl end in a number that can be incremented e.g. "control_sequence_001" The description field is the name for the seqeuence Opac description is unused 3 - Edit a record in rancor 4 - Note the new widget and option to increment or assign manually -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this is a nice addition, but some small things: - Please add the new authorised value category to the default list and add a database update. - The Plugin will show always now, there is no way to turn it off. I think we shouldn't force it like that. As we can't delete authorised value categories at the moment, maybe the easiest would be to look for existing entries and decide on that if the feature should be active or not. It also wouldn't leave you with an empty/non-working widget so easily. - The buttons are a little huge going over the lines... (not blocker, but having a look would be cool) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 Cori Lynn Arnold` <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nick@bywatersolutions.com |carnold@dgiinc.com Status|Failed QA |ASSIGNED --- Comment #5 from Cori Lynn Arnold` <carnold@dgiinc.com> --- Making changes based on feedback. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 Cori Lynn Arnold` <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #7 from Cori Lynn Arnold` <carnold@dgiinc.com> --- Bug 19263 Rancor - Add auto control number (001) widget In advanced editor mode for cataloging, the 001 widget will automatically assign the next control number if a format is defined in authorised_values table. To test you need access to the database. 1) Verify that a new entry for CONTROL_NUM_SEQUENCE is added to table authorised_value_categories 2) Enter a new value for authorised_values with the authorised_value column ending in a number 3) Edit a record using the advanced editor, specifically the 001 field 4) Note the new widget and option to increment or assign manually. The buttons fit within the widget now, and there's a database update to create the CONTROL_NUM_SEQUENCE. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 --- Comment #9 from Cori Lynn Arnold` <carnold@dgiinc.com> --- Created attachment 80237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80237&action=edit Bug 19263: Rancor - Add auto control number (001) widget To test you need access to the database. 1) Verify that a new entry for CONTROL_NUM_SEQUENCE is added to table authorised_value_categories 2) Edit a record using advanced editor and note that widget does NOT show for 001 field 3) Enter a new value for authorised_values table with: CONTROL_NUM_SEQUENCE in category column authorised_value column has string ending with a number lib column has a short string indicating type of control seq ("FAW") 4) Edit a record using advanced editor and note that the widget does show for 001 field Change inclues database update for new installations. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 Cori Lynn Arnold` <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80237|0 |1 is obsolete| | --- Comment #11 from Cori Lynn Arnold` <carnold@dgiinc.com> --- Created attachment 80240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80240&action=edit Bug 19263: Rancor - Add auto control number (001) widget To test you need access to the database. 1) Verify that a new entry for CONTROL_NUM_SEQUENCE is added to table authorised_value_categories 2) Edit a record using advanced editor and note that widget does NOT show for 001 field 3) Enter a new value for authorised_values table with: CONTROL_NUM_SEQUENCE in category column authorised_value column has string ending with a number lib column has a short string indicating type of control seq ("FAW") 4) Edit a record using advanced editor and note that the widget does show for 001 field Change inclues database update for new installations. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 Cori Lynn Arnold` <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80240|0 |1 is obsolete| | --- Comment #12 from Cori Lynn Arnold` <carnold@dgiinc.com> --- Comment on attachment 80240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80240 Bug 19263: Rancor - Add auto control number (001) widget Killing this patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 --- Comment #13 from Cori Lynn Arnold` <carnold@dgiinc.com> --- Created attachment 80257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80257&action=edit Bug 19263: 001 widget only for configured client Tests: 1) Verify that a new entry for CONTROL_NUM_SEQUENCE is added to table authorised_value_categories 2) Edit a bib record using advanced editor and note that 001 widget isn't there when adding/editing 001 field 3) Add a new row into authorised_values table with: a) CONTROL_NUM_SEQUENCE in category column b) authorised_value column has a string ending with a number i.e. "faw0001" c) lib column has a short string indicating type of control number i.e. "FAW" 4) Edit a bib record using the advanced editor and note that the 001 widget is there when adding / editing 001 field -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78085|0 |1 is obsolete| | Attachment #80231|0 |1 is obsolete| | Attachment #80257|0 |1 is obsolete| | --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 80306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80306&action=edit Bug 19263: Rancor - Add auto-001 widget To test: 1 - Define a new authorised valued category "CONTROL_NUM_SEQUENCE" 2 - Add a value/sequence The authorised_value is the starting value - shoudl end in a number that can be incremented e.g. "control_sequence_001" The description field is the name for the seqeuence Opac description is unused 3 - Edit a record in rancor 4 - Note the new widget and option to increment or assign manually Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 80308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80308&action=edit Bug 19263: 001 widget only for configured client Tests: 1) Verify that a new entry for CONTROL_NUM_SEQUENCE is added to table authorised_value_categories 2) Edit a bib record using advanced editor and note that 001 widget isn't there when adding/editing 001 field 3) Add a new row into authorised_values table with: a) CONTROL_NUM_SEQUENCE in category column b) authorised_value column has a string ending with a number i.e. "faw0001" c) lib column has a short string indicating type of control number i.e. "FAW" 4) Edit a bib record using the advanced editor and note that the 001 widget is there when adding / editing 001 field Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | Status|Signed Off |Failed QA --- Comment #18 from Josef Moravec <josef.moravec@gmail.com> --- And I think it would make more sense to have number in lib and the type of control number in authorised_value - there is a precendence for this in stocknumberAV value builder. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 --- Comment #20 from Cori Lynn Arnold <carnold@dgiinc.com> --- Created attachment 80500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80500&action=edit Bug 19263: Changes to address QA issues Changes were made to address QA issues from Comment 17 Tests: 1) Verify that a new entry for CONTROL_NUM_SEQUENCE is added to table authorised_value_categories 2) Edit a bib record using advanced editor and note that the 001 widget isn't there when adding/editing 001 field 3) Add a new row into authorised_values table with: a) CONTROL_NUM_SEQUENCE in category column b) authorised_value column has a string ending with a number i.e. sprLib0001 c) lib column has a short string indicating the type of control number i.e. "Springfield Library" 4) Edit a bib record using the advanced editor and note that the 001 widget is there when adding / editing 001 field -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 --- Comment #22 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Cori Lynn Arnold from comment #19) > (In reply to Josef Moravec from comment #18) > > And I think it would make more sense to have number in lib and the type of > > control number in authorised_value - there is a precendence for this in > > stocknumberAV value builder. > > > I don't think so. The point of the lib is to hold the string indicating the > type of control number, in our case at DGI, it's intended to hold the client > name, like "Springfield Library." It seems like most of the strings in lib > contain descriptions/types for the authorised_value. I understand your position, just pointed out there is an precedence on taking the seqeunce from authorised values. But I will not block the patches because of this. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 --- Comment #24 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 80509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80509&action=edit Bug 19263: Rancor - 001 widget - db update In advanced editor mode for cataloging, the 001 widget will automatically assign the next control number if a format is defined in authorised_values table. To test you need access to the database. 1) Verify that a new entry for CONTROL_NUM_SEQUENCE is added to table authorised_value_categories 2) Enter a new value for authorised_values with the authorised_value column ending in a number 3) Edit a record using the advanced editor, specifically the 001 field 4) Note the new widget and option to increment or assign manually. The buttons fit within the widget now, and there's a database update to create the CONTROL_NUM_SEQUENCE. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 --- Comment #26 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 80511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80511&action=edit Bug 19263: Rancor - 001 widget - changes to address QA issues Changes were made to address QA issues from Comment 17 Tests: 1) Verify that a new entry for CONTROL_NUM_SEQUENCE is added to table authorised_value_categories 2) Edit a bib record using advanced editor and note that the 001 widget isn't there when adding/editing 001 field 3) Add a new row into authorised_values table with: a) CONTROL_NUM_SEQUENCE in category column b) authorised_value column has a string ending with a number i.e. sprLib0001 c) lib column has a short string indicating the type of control number i.e. "Springfield Library" 4) Edit a bib record using the advanced editor and note that the 001 widget is there when adding / editing 001 field Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.