[Bug 18219] New: "Not checked out." problem message displays twice on local use.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 Bug ID: 18219 Summary: "Not checked out." problem message displays twice on local use. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When checking in an item that is not checked out, the problem message "Not checked out appears twice. This seems to have occured with the last update to the master. I did not see this before my master was updated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #1 from Marc Véron <veron@veron.ch> --- Confirmed. The duplication occurs in returns.tt lines 610 and 645. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16530 --- Comment #2 from Marc Véron <veron@veron.ch> --- Introduced by following Bug? Bug 16530 - Add a circ sidebar navigation menu There seem to be more duplications, e.g. [% IF ( errmsgloo.prevdebarred ) %] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Marc Véron from comment #2)
Introduced by following Bug?
Bug 16530 - Add a circ sidebar navigation menu
There seem to be more duplications, e.g. [% IF ( errmsgloo.prevdebarred ) %]
Marc, Thanks for finding this. Do you mind if I try my hand at writing a patch for this? This will be my first attempt. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 --- Comment #4 from Marc Véron <veron@veron.ch> --- (In reply to Christopher Brannon from comment #3)
(In reply to Marc Véron from comment #2)
Introduced by following Bug?
Bug 16530 - Add a circ sidebar navigation menu
There seem to be more duplications, e.g. [% IF ( errmsgloo.prevdebarred ) %]
Marc, Thanks for finding this. Do you mind if I try my hand at writing a patch for this? This will be my first attempt.
Hi Christopher, That is perfect, go ahead :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 --- Comment #5 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 60907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60907&action=edit Bug 18219: Remove duplicated code in returns.tt Removed lines of code that were duplicated in bug 16530. Fixes alignment of a few lines of code surrounding duplication. Modifies returns.tt To test: 1) Check in items that are not checked out. 2) Note duplicated problem message (i.e. "Not checked out.") 3) Apply patch. 4) Repeat step 1. 5) Note the problem message is no longer duplicated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60907|0 |1 is obsolete| | --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 60908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60908&action=edit Bug 18219: Remove duplicated code in returns.tt Removed lines of code that were duplicated in bug 16530. Fixes alignment of a few lines of code surrounding duplication. Modifies returns.tt To test: 1) Check in items that are not checked out. 2) Note duplicated problem message (i.e. "Not checked out.") 3) Apply patch. 4) Repeat step 1. 5) Note the problem message is no longer duplicated. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |cbrannon@cdalibrary.org |ity.org | Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 --- Comment #7 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 60910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60910&action=edit Bug 18219: Remove extra whitespace from returns.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60908|0 |1 is obsolete| | Attachment #60910|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61037&action=edit Bug 18219: Remove duplicated code in returns.tt Removed lines of code that were duplicated in bug 16530. Fixes alignment of a few lines of code surrounding duplication. Modifies returns.tt To test: 1) Check in items that are not checked out. 2) Note duplicated problem message (i.e. "Not checked out.") 3) Apply patch. 4) Repeat step 1. 5) Note the problem message is no longer duplicated. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61038&action=edit Bug 18219: Remove extra whitespace from returns.tt Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |16530 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530 [Bug 16530] Add a circ sidebar navigation menu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks again Chris! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |katrin.fischer@bsz-bw.de Resolution|--- |FIXED --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Dependency is not in 16.11.x, so this should not be needed there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 --- Comment #12 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Katrin Fischer from comment #11)
Dependency is not in 16.11.x, so this should not be needed there.
I don't know what this means. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This bug is supposed to be caused by bug 16530 (depends on: 16530 above). As this 16530 is not in 16.11.x, we should not need the bugfix for it. If this is wrong, please let me know. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 --- Comment #14 from Christopher Brannon <cbrannon@cdalibrary.org> --- No, but (In reply to Katrin Fischer from comment #13)
This bug is supposed to be caused by bug 16530 (depends on: 16530 above). As this 16530 is not in 16.11.x, we should not need the bugfix for it. If this is wrong, please let me know.
No, but 16530 is pushed to 17.05. So, why wouldn't this be pushed to 17.05 as well? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It is pushed to 17.05 (i.e. master), see comment 10. Katrin was talking about not backporting it to the latest stable version (16.11.x). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 --- Comment #16 from Christopher Brannon <cbrannon@cdalibrary.org> --- Okay, I am confused then by the status of resolved fixed. She said the bug isn't in 16.11.x and we shouldn't need a bug fix. There was nothing mentioned about it being needed for 17.05. Shouldn't it be pushed to master? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 --- Comment #17 from Christopher Brannon <cbrannon@cdalibrary.org> --- Ignore me. I am confused today. I guess I am just confused by the status. I get that it is pushed to master. :/ Sorry. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Release Manager sets the status to 'pushed to master' after pushing - I check all those if they apply to my branch 16.11.x - if not, I change to Resolved Fixed, because there is nothing more to to. If I push them, I change to Pushed to stable, which then is checked by the other Rmaints for backṕorting to their versions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18219 --- Comment #19 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Katrin Fischer from comment #18)
Release Manager sets the status to 'pushed to master' after pushing - I check all those if they apply to my branch 16.11.x - if not, I change to Resolved Fixed, because there is nothing more to to. If I push them, I change to Pushed to stable, which then is checked by the other Rmaints for backṕorting to their versions.
Thank you for the clarification! :) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org