[Bug 17831] New: Item Search fails on custom subject search field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 Bug ID: 17831 Summary: Item Search fails on custom subject search field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org If I add an Item Search Field: Name: Subj Label: Subj Head MARC field: 650 MARC subfield: a Auth values: N/A I get an error when doing the item search: DBD::mysql::st execute failed: Unknown column 'bibliosubject.subject' in 'where clause' [for Statement " SELECT SQL_CALC_FOUND_ROWS items.* FROM items LEFT JOIN biblio ON biblio.biblionumber = items.biblionumber LEFT JOIN biblioitems ON biblioitems.biblioitemnumber = items.biblioitemnumber LEFT JOIN biblio_metadata ON biblio_metadata.biblionumber = biblio.biblionumber WHERE 1 AND (bibliosubject.subject like ?) AND biblio_metadata.format = 'marcxml' AND biblio_metadata.marcflavour = ? ORDER BY title ASC LIMIT ?, ? " with ParamValues: 0="juvnile%", 1='MARC21', 2=0, 3=20] at /home/vagrant/kohaclone/C4/Items.pm line 2798. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We just fixed bug 17743 - could this be it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- No, it appears to be bad data in our sample install files: SELECT * FROM marc_subfield_structure WHERE tagfield=650 AND tagsubfield='a' AND frameworkcode=''\G; The kohafield is set to bibliosubject.subject, I am guessing this is cruft (In reply to Katrin Fischer from comment #1)
We just fixed bug 17743 - could this be it?
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can you detail the problem a bit more? Should we change this bug to be a clean-up bug for bibliosubject.subject in our default files? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 58769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58769&action=edit Bug 17831 - Item Search fails on custom subject search field This patch removes the assignment of non-existent koha field 'bibliosubject.subject' to MARC subject fields in the installer data for koha To test: You'll want a new fresh db 1 - Apply patch 2 - Run websintaller 3 - Ensure that thigns go smoothly 4 - Add/delete/edit some records and ensure that things are working with the installed frameworks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #3)
Can you detail the problem a bit more? Should we change this bug to be a clean-up bug for bibliosubject.subject in our default files?
Yes, I think that is what we need to do, I threw it together quikc but haven't tested - wondering if I need to do '' instead of null - need to test but thought the patch would better illustrate the issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Nick, should this be NSO? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #6)
Hi Nick, should this be NSO?
I think so, I just didn't test it myself, it should be a simple fix -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Item Search fails on custom |Remove non-existing |subject search field |bibliosubject.subject | |mapping from frameworks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 95760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95760&action=edit Bug 17831: Remove non-existig bibliosubject.subject mapping from frameworks This patch removes the assignment of non-existent koha field 'bibliosubject.subject' to MARC subject fields in the installer data for koha To test: You'll want a new fresh db 1 - Apply patch 2 - Run websintaller 3 - Ensure that thigns go smoothly 4 - Add/delete/edit some records and ensure that things are working with the installed frameworks Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 95761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95761&action=edit Bug 17831: Database update - Tidy up frameworks in existing installations The mapped table and column doesn't exist, so we should also remove it from existing installations. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58769|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95760|0 |1 is obsolete| | Attachment #95761|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96011&action=edit Bug 17831: Remove non-existig bibliosubject.subject mapping from frameworks This patch removes the assignment of non-existent koha field 'bibliosubject.subject' to MARC subject fields in the installer data for koha To test: You'll want a new fresh db 1 - Apply patch 2 - Run websintaller 3 - Ensure that thigns go smoothly 4 - Add/delete/edit some records and ensure that things are working with the installed frameworks Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96012&action=edit Bug 17831: Database update - Tidy up frameworks in existing installations The mapped table and column doesn't exist, so we should also remove it from existing installations. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|gmcharlt@gmail.com |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Searching |MARC Bibliographic data | |support -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.05.00 |20.05.00 released in| | CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | Status|Pushed to master |Pushed to stable CC| |joy@bywatersolutions.com --- Comment #13 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org