[Bug 17442] New: Fees and charges warning on the circulation page. Rollback to the original behaviour
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17442 Bug ID: 17442 Summary: Fees and charges warning on the circulation page. Rollback to the original behaviour Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: francois.charbonnier@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Bug 14497 added a warning to patron details page if patron's fines exceed noissuescharge. But it also changes the condition to display the warning on the circulation page. Until 16.05, the staff could see the fees and charges warning on the circulation page when the patron had fines. But, with Bug 14497, the warning appears only when the patron's fines exceed the noissuescharge syspref. I'm sure this change of behaviour wasn't meant to be. Especially, since there is nothing in place to keep the original behaviour. This patch will keep the new warning on he patron detail page. It will rollback the warning to the original behaviour. The fees and charges warning will show up no matter how much the patron owes to the library. Test plan : 1) Apply this patch 2) Find or create a patron who's fines doesn't exceed noissuescharge 3) You should see the fees and charges warning on the circulation page (circulation.pl) 4) Browse to the patron's details page (moremember.pl). The warning doesn't appear 5) Find or create a patron who's fines exceed noissuescharge 5) Browse to that patron's details ( moremember.pl ) 6) You should see a warning near the top of the page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17442 --- Comment #1 from Francois Charbonnier <francois.charbonnier@inlibro.com> --- It will rollback the warning to the original behaviour on the circulation page* -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17442 --- Comment #2 from Blou <philippe.blouin@inlibro.com> --- Created attachment 56439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56439&action=edit Bug 17442 - Reinstate patron's fine warning that was lost with bug 14497 Bug 14497 added a warning to patron details page if patron's fines exceed noissuescharge, but it also changed the condition to display the warning on the circulation page. Until 16.05, the staff could see the fees and charges warning on the circulation page when the patron had fines. But, with Bug 14497, the warning appears only when the patron's fines exceed the noissuescharge syspref. This patch will keep the new warning on he patron detail page. It will rollback the warning to the original behaviour. The fees and charges warning will show up no matter how much the patron owes to the library. Test plan : 1) Apply this patch 2) Find or create a patron who's fines doesn't exceed noissuescharge 3) You should see the fees and charges warning on the circulation page (circulation.pl) 4) Browse to the patron's details page (moremember.pl). The warning doesn't appear 5) Find or create a patron who's fines exceed noissuescharge 5) Browse to that patron's details ( moremember.pl ) 6) You should see a warning near the top of the page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17442 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin@inlibro.com Assignee|koha-bugs@lists.koha-commun |philippe.blouin@inlibro.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17442 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely@hotmail.com --- Comment #3 from Claire Gravely <claire_gravely@hotmail.com> --- Hi, I am a little confused. I am not seeing a change in the behaviour between master and this patch? I see the fines warning displayed on the moremember.pl page and circulation.pl pages both when the patron has fines that exceed noissuescharge and also when they don't. Was the issue already fixed? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17442 Francois Charbonnier <francois.charbonnier@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #4 from Francois Charbonnier <francois.charbonnier@inlibro.com> --- Thanks Claire. I checked again on Bugzilla and found out that it was already fixed by Bug 16810 a couple months ago. *** This bug has been marked as a duplicate of bug 16810 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org