[Bug 8906] New: Improve OAI management interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906 Priority: P5 - low Change sponsored?: --- Bug ID: 8906 CC: gmcharlt@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: Improve OAI management interface Severity: enhancement Classification: Unclassified OS: All Reporter: oleonard@myacpl.org Hardware: All Status: ASSIGNED Version: master Component: System Administration Product: Koha The OAI management interface breaks with existing interface patterns in several way. I propose to correct these differences and improve the handling of clone and delete operations in set descriptions and mappings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 12775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12775&action=edit Bug 8906 - Improve OAI management interface Revising OAI configuration interface to conform to existing interface patterns: - Properly-formatted form rows - "clone" and "clear" links consistent with other forms which use these conventions - Improved title and breadcrumbs - Standard save and cancel markup New to the mappings interface: A "clear" button to remove or empty the contents of a row. This replaces the help text about emptying fields. To test: view, add and edit OAI sets and mappings. Try adding and removing multiple set descriptions and mappings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12775|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 12898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12898&action=edit Bug 8906 - Improve OAI management interface Revising OAI configuration interface to conform to existing interface patterns: - Properly-formatted form rows - "clone" and "clear" links consistent with other forms which use these conventions - Improved title and breadcrumbs - Standard save and cancel markup New to the mappings interface: A "clear" button to remove or empty the contents of a row. This replaces the help text about emptying fields. To test: view, add and edit OAI sets and mappings. Try adding and removing multiple set descriptions and mappings. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 13561 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13561&action=edit Bug 8906: Followup FIX hardcoded localhost url -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | QA Contact| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net --- Comment #4 from Mirko Tietgen <mirko@abunchofthings.net> --- Jonathan, I can't find any reference to localhost in that file. Maybe this was fixed with some other patch already? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906 --- Comment #5 from Mirko Tietgen <mirko@abunchofthings.net> --- Ah, my bad. I had applied both patches already :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13561|0 |1 is obsolete| | --- Comment #6 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 14107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14107&action=edit Bug 8906: Followup FIX hardcoded localhost url Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906 --- Comment #7 from Mirko Tietgen <mirko@abunchofthings.net> --- Hey Owen, now that I had a look at it again, wouldn't it be more straightforward to replace the 'clear' button with a 'replace' button that clears, saves and thus deletes the row? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9201 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #7)
now that I had a look at it again, wouldn't it be more straightforward to replace the 'clear' button with a 'replace' button that clears, saves and thus deletes the row?
I don't understand. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906 --- Comment #9 from Mirko Tietgen <mirko@abunchofthings.net> --- Oh, sorry, I meant to write 'delete', not 'replace'. The 'clear' button now clears the fields and I was wondering if it would make sense to clear and save, which would result in a deletion. I hope i worded it better this time. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906 --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Owen, What do you think about Mirko's proposition? I think he is right, but I let you give you opinion. I will submit a patch with this modification, please signoff or mark it as obsolete if you want. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14262&action=edit Bug 8906: Followup replace 'Clear' with 'Delete' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14262|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14299&action=edit [SIGNED-OFF] Bug 8906: Followup replace 'Clear' with 'Delete' Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|jonathan.druart@biblibre.co |m.de.rooy@rijksmuseum.nl |m | --- Comment #13 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking at this one now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12898|0 |1 is obsolete| | Attachment #14107|0 |1 is obsolete| | Attachment #14299|0 |1 is obsolete| | --- Comment #14 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 15338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15338&action=edit Bug 8906 - Improve OAI management interface Revising OAI configuration interface to conform to existing interface patterns: - Properly-formatted form rows - "clone" and "clear" links consistent with other forms which use these conventions - Improved title and breadcrumbs - Standard save and cancel markup New to the mappings interface: A "clear" button to remove or empty the contents of a row. This replaces the help text about emptying fields. To test: view, add and edit OAI sets and mappings. Try adding and removing multiple set descriptions and mappings. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906 --- Comment #15 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 15339 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15339&action=edit Bug 8906: Followup FIX hardcoded localhost url Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906 --- Comment #16 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 15340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15340&action=edit Bug 8906: Followup replace 'Clear' with 'Delete' Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Looks good to me. Improving interface. Just wondering ("somewhat" outside the scope): Deleting a set is without confirmation? I agree that clearing one line in a set does not need a confirm, but before deleting possibly lots of lines..? Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8906 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org