[Bug 5338] New: Serials in guided reports
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Summary: Serials in guided reports Change sponsored?: Sponsored Product: Koha Version: rel_3_4 Platform: All URL: http://wiki.koha-community.org/wiki/Guided_reports_ser ials_RFC OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Serials AssignedTo: henridamien@koha-fr.org ReportedBy: paul.poulain@biblibre.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 Deadline: 2011-05-01 We will add needed tables & help to be able to build a guided report for subscriptions & serials -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger@foundations.ed | |u --- Comment #1 from Chris Nighswonger <cnighswonger@foundations.edu> 2010-11-10 20:21:10 UTC --- I'm wondering if a little more detail might be good here. For example: 1. What sort of tables need to be added? 2. What is the proposed structure of these tables? 3. What modules/scripts need to be touched upon or added? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #2 from Colin Campbell <colin.campbell@ptfs-europe.com> 2010-11-11 15:31:42 UTC --- Experience has shown that the main obstacle to setting up comprehendable reports on serials is the fact that the serial schema is not that well thought out and the interface to it is not very clear. There is a definite requirement for some refactoring here. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Depends on| |7688 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|henridamien@koha-fr.org |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 11601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11601&action=edit Bug 5338: Serials Report Blocked by Bug 7688 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11601|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22908&action=edit Bug 5338: Serials Report -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Test plan: Build some guided reports for subscriptions and serials. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #6 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- (In reply to Jonathan Druart from comment #5)
Test plan: Build some guided reports for subscriptions and serials.
Hi Could you make a more detailed plan please? There is already a guided report for serials (serials_stats.pl). So, I would like to know exactly the changes made by this patch. Mathieu -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to mathieu saby from comment #6)
Could you make a more detailed plan please?
No, there are many ways to test serial reports, so I don't think I should let a detailed test plan. If you want to test it, try to generate reports you would like to have for your library.
There is already a guided report for serials (serials_stats.pl). So, I would like to know exactly the changes made by this patch.
The existing one only generates one table with hard coded column. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 --- Comment #8 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Mmm I realized I was confusing guided reports and statistic wizard! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Test made In Guided Reports, I selected the new 'Serial' value in modules list then I selected all the fields of the following tables: serial, serialitems, subscription, subscriptionhistory, subscriptionroutinglist I did not choose sorting, grouping or counting option The resulting report is: SELECT serial.serialid,serial.biblionumber,serial.subscriptionid,serial.serialseq,serial.status,serial.planneddate,serial.notes,serial.publisheddate,serial.claimdate,serial.routingnotes, serialitems.itemnumber,serialitems.serialid, subscription.biblionumber,subscription.subscriptionid,subscription.librarian,subscription.startdate,subscription.aqbooksellerid,subscription.cost,subscription.aqbudgetid,subscription.weeklength,subscription.monthlength,subscription.numberlength,subscription.periodicity,subscription.countissuesperunit,subscription.notes,subscription.status,subscription.lastvalue1,subscription.lastvalue2,subscription.innerloop1,subscription.innerloop2,subscription.innerloop3,subscription.lastvalue3,subscription.firstacquidate,subscription.manualhistory,subscription.irregularity,subscription.skip_serialseq,subscription.letter,subscription.numberpattern,subscription.locale,subscription.distributedto,subscription.internalnotes,subscription.callnumber,subscription.location,subscription.branchcode,subscription.lastbranch,subscription.serialsadditems,subscription.staffdisplaycount,subscription.opacdisplaycount,subscription.graceperiod,subscription.enddate,subscription.closed,subscription.reneweddate, subscrip tionhistory.biblionumber, subscriptionhistory.subscriptionid,subscriptionhistory.histstartdate,subscriptionhistory.histenddate,subscriptionhistory.missinglist,subscriptionhistory.recievedlist,subscriptionhistory.opacnote,subscriptionhistory.librariannote, subscriptionroutinglist.routingid,subscriptionroutinglist.borrowernumber,subscriptionroutinglist.ranking,subscriptionroutinglist.subscriptionid FROM biblio LEFT JOIN biblioitems on (biblio.biblionumber=biblioitems.biblionumber) LEFT JOIN serial on (biblioitems.biblionumber=serial.biblionumber) LEFT JOIN serialitems on (serial.serialid=serialitems.serialid) LEFT JOIN subscription on (serial.subscriptionid=subscription.subscriptionid) LEFT JOIN subscriptionhistory on (serial.subscriptionid=subscriptionhistory.subscriptionid) LEFT JOIN subscriptionroutinglist on (serial.subscriptionid=subscriptionroutinglist.subscriptionid) LEFT JOIN aqbooksellers on (subscription.aqbooksellerid=aqbooksellers.id) Koha accepted to run it and get 1311 results I only have 35 serials in my db. In fact the reports gets 1 line for each of my records :( So I fail QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22908|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23299&action=edit Bug 5338: Serials Report -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Mathieu, the table order was wrong. The results look better now. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 --- Comment #12 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- (In reply to Jonathan Druart from comment #11)
Mathieu, the table order was wrong. The results look better now.
Thank you. You see, it was not so trivial to test ;-) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Bug 5338 depends on bug 7688, which changed state. Bug 7688 Summary: Change subscriptions numbering pattern and frequencies http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- perl -c C4/Reports/Guided.pm C4/Reports/Guided.pm syntax OK apply patch perl -c C4/Reports/Guided.pm when is experimental at C4/Reports/Guided.pm line 341. when is experimental at C4/Reports/Guided.pm line 350. when is experimental at C4/Reports/Guided.pm line 357. when is experimental at C4/Reports/Guided.pm line 1032. C4/Reports/Guided.pm syntax OK Given we are trying to remove given/when from our code (as well as smartmatch) I am failing this patch because it introduces new instances of them -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23299|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29271&action=edit Bug 5338: Serials Report -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paola.rossi@cineca.it Status|Needs Signoff |Patch doesn't apply --- Comment #15 from Paola Rossi <paola.rossi@cineca.it> --- I've applied the patch against master 3.19.00.005 Applying: Bug 5338: Serials Report Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/columns.def Auto-merging C4/Reports/Guided.pm CONFLICT (content): Merge conflict in C4/Reports/Guided.pm Failed to merge in the changes. Patch failed at 0001 Bug 5338: Serials Report I pass the patch to "Patch doesn't apply" status. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29271|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35148&action=edit Bug 5338: Serials Report -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35148|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35149&action=edit Bug 5338: Serials Report -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #18 from Paola Rossi <paola.rossi@cineca.it> --- Thanks, Jonathan. I've applied the patch against master 3.19.00.005 Then, on Home › Reports › Guided reports wizard › , I've tried to create a "New report" for serials: a "New guided report". 1) Before saving the new report, in the "Save your custom report" form, "Serials" was not in the "Report group" drop down list. So I could not select the "Serials" Report group [I had to create it as a new report-group]. I think that this can be an error (a lack) because the "Serials" option was available in the modules' drop down list on the "1 of 6" step. And because all the other 5 modules names (+ "none") were listed in the "Report group" drop down list. So I pass the patch to "Failed QA" status. NB1. I've selected a periodicity. In the report I saw the right periodicity, but there was the code (id 7), not the description ('1/month'). Was it right? NB2. I've chosen to create a "public" report, but the new report was not created as "public" (ERROR), as I've seen afterwards in the "Public" column of the "Saved reports" table: Home › Reports › Guided reports wizard › Saved reports On the contrary (RIGHT), I could change the report to public on editing it. [I can't recognize if this error is related to this bug or not.] -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35149|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35179&action=edit Bug 5338: Serials Report -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35180&action=edit Bug 5338: Add "Serials" to the report group list -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Paola Rossi from comment #18)
Thanks, Jonathan.
1) Before saving the new report, in the "Save your custom report" form, "Serials" was not in the "Report group" drop down list. So I could not select the "Serials" Report group [I had to create it as a new report-group].
The last patch adds a new "Serials" group to the list.
NB1. I've selected a periodicity. In the report I saw the right periodicity, but there was the code (id 7), not the description ('1/month'). Was it right?
I don't plan to do that on this bug report.
NB2. I've chosen to create a "public" report, but the new report was not created as "public" (ERROR), as I've seen afterwards in the "Public" column of the "Saved reports" table: Home › Reports › Guided reports wizard › Saved reports
On the contrary (RIGHT), I could change the report to public on editing it.
[I can't recognize if this error is related to this bug or not.]
It's not, I reproduce the problem on master, I will try to submit a patch on another bug report. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 --- Comment #22 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Jonathan Druart from comment #21)
It's not, I reproduce the problem on master, I will try to submit a patch on another bug report.
See bug 13578 for a patch. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #23 from Paola Rossi <paola.rossi@cineca.it> --- (In reply to Jonathan Druart from comment #21)
(In reply to Paola Rossi from comment #18)
Thanks, Jonathan.
1) Before saving the new report, in the "Save your custom report" form, "Serials" was not in the "Report group" drop down list. So I could not select the "Serials" Report group [I had to create it as a new report-group].
The last patch adds a new "Serials" group to the list.
I've applied the patch against master 3.19.00.006 Thanks, Jonathan: now the "Report group" list is OK! Now on the 2-nd step: Step 2 of 6: Pick a report type 3 values were listed [Tabular,Summary,Matrix], but only the first one was available. So I pass the patch to "Failed QA" status. NB. About the Mathieu's problem in Comment 9, now the report got 1 line for each serial's record in the DB (RIGHT imo). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #24 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Paola Rossi from comment #23)
Now on the 2-nd step: Step 2 of 6: Pick a report type
3 values were listed [Tabular,Summary,Matrix], but only the first one was available.
Hello Paola, Yes, it's expected. It's the same for all reports you will create. If you look at the code, the other options are disabled: 460 <select id="types" name="types"> 461 <option value="1">Tabular</option> 462 <option value="2" disabled="disabled">Summary</option> 463 <option value="3" disabled="disabled">Matrix</option> 464 </select> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35179|0 |1 is obsolete| | --- Comment #25 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 35300 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35300&action=edit [SIGNED OFF] Bug 5338: Serials Report Thanks, Jonathan! So I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35180|0 |1 is obsolete| | --- Comment #26 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 35301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35301&action=edit [SIGNED OFF] Bug 5338: Add "Serials" to the report group list -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Starting to work on this today, I'd like to suggest a change: - Remove the database update and don't force the new report group into existing installatoins. My reasoning is that when they have serials reports, they will already have created the REPORT_GROUPS to match their needs and it might be annoying or even create a duplicate warning if they have used SER as well. And adding a report group is optional on the saving step. - Add the new REPORT_GROUP values to the sample data for new installations instead. Otherwise this works pretty well and I am almost ready to pass QA :) Setting to "FQA" to gt Jonathan's attention. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35301|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36457&action=edit Bug 5338: Add "Serials" to the report group list Signed-off-by: Paola Rossi <paola.rossi@cineca.it> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 --- Comment #29 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36458&action=edit Bug 5338: Use insert ignore to avoid a warning if 'SER' already exists -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 --- Comment #30 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36459&action=edit Bug 5338: Add the "SER" report group for all languages. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 --- Comment #31 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #27)
- Remove the database update and don't force the new report group into existing installatoins. My reasoning is that when they have serials reports, they will already have created the REPORT_GROUPS to match their needs and it might be annoying or even create a duplicate warning if they have used SER as well. And adding a report group is optional on the saving step.
Compromise found using insert ignore :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36457|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36458|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36459|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35300|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 36621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36621&action=edit [PASSED QA] Bug 5338: Serials Report Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 36622 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36622&action=edit [PASSED QA] Bug 5338: Add "Serials" to the report group list Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 36623 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36623&action=edit [PASSED QA] Bug 5338: Use insert ignore to avoid a warning if 'SER' already exists Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 36624 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36624&action=edit [PASSED QA] Bug 5338: Add the "SER" report group for all languages. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #36 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 --- Comment #37 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 39302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39302&action=edit Bug 5338: (QA followup) update the tests for the new reports This patch fixes the unit tests related to guided reports. It is needed now that there are more options available. It also fixes a wrong 'savedsql' key (should be 'sql') that caused the tests to print warnings. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Serials in guided reports |Add serials module to | |guided reports -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org