[Bug 17179] New: Add keyboard shortcuts to repeat (duplicate) a field, and cut text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Bug ID: 17179 Summary: Add keyboard shortcuts to repeat (duplicate) a field, and cut text Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl add two more keyboard shortcut commands to the list already available: Ctrl-R : Repeat or duplicate a field Ctrl-C : cut command (to be used with paste - Ctrl-V) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|gmcharlt@gmail.com |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65090&action=edit Bug 17179 - Add keyboard shortcuts to repeat (duplicate) a field, and cut text This patchset introduces an internal clipboard to the advanced editor and provides some new functionality to make use of this: Ctrl-X: Now cuts a line into the clipboard area Ctrl-Shift-X: Now cuts current subfield into clipboard area Ctrl-C: Copies a line into the clipboard area Ctrl-Shift-C: Copies current subfield into clipboard area Ctrl-P: Pastes the selected item from the clipboard at cursor Ctrl-I: Copies the current line and inserts onto a new line below Ctrl-Z: Functions as undo - this was supported but now in the dropdown help To test: Verify all functionality above and confirm it behaves as expected Note: Ctrl-v pastes from the system clipboard - codemirror does not have access and this is why we use our "Clipboard" For browser cut/paste please use mouse right click or context menus Ctrl-P can be accessed as print by focusing outside the editor window -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ldjamison@marywood.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add keyboard shortcuts to |Advanced editor: Add |repeat (duplicate) a field, |keyboard shortcuts to |and cut text |repeat (duplicate) a field, | |and cut text CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65090|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 67817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67817&action=edit Bug 17179 - Add keyboard shortcuts to repeat (duplicate) a field, and cut text This patchset introduces an internal clipboard to the advanced editor and provides some new functionality to make use of this: Ctrl-X: Now cuts a line into the clipboard area Ctrl-Shift-X: Now cuts current subfield into clipboard area Ctrl-C: Copies a line into the clipboard area Ctrl-Shift-C: Copies current subfield into clipboard area Ctrl-P: Pastes the selected item from the clipboard at cursor Ctrl-I: Copies the current line and inserts onto a new line below Ctrl-Z: Functions as undo - this was supported but now in the dropdown help To test: Verify all functionality above and confirm it behaves as expected Note: Ctrl-v pastes from the system clipboard - codemirror does not have access and this is why we use our "Clipboard" For browser cut/paste please use mouse right click or context menus Ctrl-P can be accessed as print by focusing outside the editor window Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=17191 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is a cool feature. Maybe the clipboard could be mentioned in the bug title for the release notes? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Please sort the shortcut list for the Ctrls. Ctrl + P seems a bad choice. Sometimes I could paste. But another time in the editor (not outside) it still goes to Print (in Firefox). Another key ? Shortcut list: It would be nice imo if I could get rid of that list on my screen with Esc (yes with the keyboard please :) For another report probably.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 68675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68675&action=edit Bug 17179: Followup - Use Ctrl-Shift-V instead of Ctrl-P and fix error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Thanks for your follow-up, Nick. But Ctrl+Shift+V does not work. Most other keys seem to work such as Ctrl+I. Ctrl+C worked most of the time, but not always? Tested with Firefox under Windows. (Since Ctrl+letter combinations are widely used already, they seem bad candidates.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21411 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 85396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85396&action=edit Bug 17179: Add keyboard shortcuts to repeat (duplicate) a field, and cut text This patchset introduces an internal clipboard to the advanced editor and provides some new functionality to make use of this, default shortcuts are provided but can be edited per bug 21411 The default shortcuts for new/changed functions are: Changed: Ctrl-X: Now cuts a line into the clipboard area Ctrl-Shift-X: Now cuts current subfield into clipboard area Added: Ctrl-C: Copies a line into the clipboard area Ctrl-Shift-C: Copies current subfield into clipboard area Ctrl-P: Pastes the selected item from the clipboard at cursor Ctrl-I: Copies the current line and inserts onto a new line below To test: Verify all functionality above and confirm it behaves as expected Note: Ctrl-v pastes from the system clipboard - codemirror does not have access and this is why we use our "Clipboard" For browser cut/paste please use mouse right click or context menus Ctrl-P can be accessed as print by focusing outside the editor window -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21411 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 [Bug 21411] Advanced cataloging editor - rancor - Allow configuration of Keyboard shortcuts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67817|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68675|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85396|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 86025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86025&action=edit Bug 17179: Add keyboard shortcuts to repeat (duplicate) a field, and cut text This patchset introduces an internal clipboard to the advanced editor and provides some new functionality to make use of this, default shortcuts are provided but can be edited per bug 21411 The default shortcuts for new/changed functions are: Changed: Ctrl-X: Now cuts a line into the clipboard area Shift-Ctrl-X: Now cuts current subfield into clipboard area Added: Ctrl-C: Copies a line into the clipboard area Shift-Ctrl-C: Copies current subfield into clipboard area Ctrl-P: Pastes the selected item from the clipboard at cursor Ctrl-I: Copies the current line and inserts onto a new line below To test: Verify all functionality above and confirm it behaves as expected Note: Ctrl-v pastes from the system clipboard - codemirror does not have access and this is why we use our "Clipboard" For browser cut/paste please use mouse right click or context menus Ctrl-P can be accessed as print by focusing outside the editor window -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86025|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 86041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86041&action=edit Bug 17179: Add keyboard shortcuts to repeat (duplicate) a field, and cut text This patchset introduces an internal clipboard to the advanced editor and provides some new functionality to make use of this, default shortcuts are provided but can be edited per bug 21411 The default shortcuts for new/changed functions are: Changed: Ctrl-X: Now cuts a line into the clipboard area Shift-Ctrl-X: Now cuts current subfield into clipboard area Added: Ctrl-C: Copies a line into the clipboard area Shift-Ctrl-C: Copies current subfield into clipboard area Ctrl-P: Pastes the selected item from the clipboard at cursor Ctrl-I: Copies the current line and inserts onto a new line below To test: Verify all functionality above and confirm it behaves as expected Note: Ctrl-v pastes from the system clipboard - codemirror does not have access and this is why we use our "Clipboard" For browser cut/paste please use mouse right click or context menus Ctrl-P can be accessed as print by focusing outside the editor window -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Cori Lynn Arnold <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carnold@dgiinc.com Status|Needs Signoff |Failed QA --- Comment #10 from Cori Lynn Arnold <carnold@dgiinc.com> --- I got these to work okay: Changed: Ctrl-X: Now cuts a line into the clipboard area Added: Ctrl-C: Copies a line into the clipboard area Ctrl-P: Pastes the selected item from the clipboard at cursor Ctrl-I: Copies the current line and inserts onto a new line below (and I really like Ctrl-I!!, but Control-P if you don't have the cursor in just the right place will pop the print menu) These did not work: Expected: Shift-Ctrl-C: Copies current subfield into clipboard area Result (in firefox and chrome): Pops up the "Inspector" / Development tools Expected: Nothing happens. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #11 from Liz Rea <wizzyrea@gmail.com> --- Firefox claims so many key combinations :( I had trouble with ctrl-p (print menu every single time - usability nightmare if it's intermittent), ctrl-l (selects address bar text), ctrl-i (page info, another you have to have the cursor in just the right spot), shift-ctrl-c (inspector). The one good thing is that with the 21411 bug, you can remap all of the keys to whatever you want. The bad thing is that at least in Firefox, there aren't many key combos left to use that don't have a Firefox feature associated, and often you have to be really careful about where the cursor is when you use them. It could be really, really frustrating for users. Much more frustrating than say, using MARCEdit or some other tool to write your record and then importing the record. I'm not sure what to do here, none of the options seem perfect. I suppose you could get the cataloguers who use this to install something like https://www.ghacks.net/2016/12/24/disable-keyboard-shortcuts-in-firefox/ so as to unbind and free up a few, but I hate to make people have Firefox addons for what ought to be core features. The use case outlineed in the article there seems very similar to what we are dealing with: an editor window that uses a key binding that also is one that Firefox claims. If we are going to say "yes, use this plugin for firefox with the advanced editor" then I think I'm ok to let this through basically as is after a bit of retesting with the plugin. But we also need to be aware that not every IT department will allow the usage of Firefox plugins, and that those users will have a sub optimal experience. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Bug 17179 depends on bug 21411, which changed state. Bug 21411 Summary: Advanced cataloging editor - rancor - Allow configuration of Keyboard shortcuts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86041|0 |1 is obsolete| | --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 92406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92406&action=edit Bug 17179: Add keyboard shortcuts to repeat (duplicate) a field, and cut text This patchset introduces an internal clipboard to the advanced editor and provides some new functionality to make use of this, default shortcuts are provided but can be edited per bug 21411 The default shortcuts for new/changed functions are: Changed: Ctrl-X: Now cuts a line into the clipboard area Shift-Ctrl-X: Now cuts current subfield into clipboard area Added: Ctrl-C: Copies a line into the clipboard area Shift-Ctrl-C: Copies current subfield into clipboard area Ctrl-P: Pastes the selected item from the clipboard at cursor Ctrl-I: Copies the current line and inserts onto a new line below To test: Verify all functionality above and confirm it behaves as expected Note: Ctrl-v pastes from the system clipboard - codemirror does not have access and this is why we use our "Clipboard" For browser cut/paste please use mouse right click or context menus Ctrl-P can be accessed as print by focusing outside the editor window -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- I would really like to move this one along, the keyboard combos seem to work for me, they may not work on all machines, however, one can now remap these keys to combinations that may work. I will gladly take suggestions on different default mappings, but I don't think we should consider this a blocker - being web based means we are going to have to make some browser concessions and I don't know that we have a perfect default to provide -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Alex Sassmannshausen <alex@komputilo.eu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex@komputilo.eu Status|Needs Signoff |Failed QA --- Comment #14 from Alex Sassmannshausen <alex@komputilo.eu> --- Hi Nick, As discussed, I'm failing this because of an error on the Shift-Ctrl-{C,X} keyboard shortcuts. When they are used, console logs errors that curCursor is not a function. Also, as a suggested improvement, possibly addressing some of the useability issues raised, it'd be amazing if any cut or copy operation resulted in the latest item in the clipboard being selected immediately. This would allow users to cut/copy & paste fields and subfields quickly without having to switch to the mouse to select the last copied/cut content and then focusing on the right location in the editor again. Hth, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Alex Sassmannshausen <alex@komputilo.eu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Alex Sassmannshausen <alex@komputilo.eu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92406|0 |1 is obsolete| | --- Comment #15 from Alex Sassmannshausen <alex@komputilo.eu> --- Created attachment 93601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93601&action=edit Bug 17179: Add keyboard shortcuts to repeat (duplicate) a field, and cut text This patchset introduces an internal clipboard to the advanced editor and provides some new functionality to make use of this, default shortcuts are provided but can be edited per bug 21411 The default shortcuts for new/changed functions are: Changed: Ctrl-X: Now cuts a line into the clipboard area Shift-Ctrl-X: Now cuts current subfield into clipboard area Added: Ctrl-C: Copies a line into the clipboard area Shift-Ctrl-C: Copies current subfield into clipboard area Ctrl-P: Pastes the selected item from the clipboard at cursor Ctrl-I: Copies the current line and inserts onto a new line below To test: Verify all functionality above and confirm it behaves as expected Note: Ctrl-v pastes from the system clipboard - codemirror does not have access and this is why we use our "Clipboard" For browser cut/paste please use mouse right click or context menus Ctrl-P can be accessed as print by focusing outside the editor window Signed-off-by: Alex Sassmannshausen <alex@komputilo.eu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 --- Comment #16 from Alex Sassmannshausen <alex@komputilo.eu> --- Created attachment 93602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93602&action=edit Bug 17179: (follow-up) Correct typos, add default select. Correct error whereby object curCursor was invoked as a function. Added action whereby the most recent entry in the clipboard is selected after all copy and cut operations. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93601|0 |1 is obsolete| | Attachment #93602|0 |1 is obsolete| | --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 93676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93676&action=edit Bug 17179: Add keyboard shortcuts to repeat (duplicate) a field, and cut text This patchset introduces an internal clipboard to the advanced editor and provides some new functionality to make use of this, default shortcuts are provided but can be edited per bug 21411 The default shortcuts for new/changed functions are: Changed: Ctrl-X: Now cuts a line into the clipboard area Shift-Ctrl-X: Now cuts current subfield into clipboard area Added: Ctrl-C: Copies a line into the clipboard area Shift-Ctrl-C: Copies current subfield into clipboard area Ctrl-P: Pastes the selected item from the clipboard at cursor Ctrl-I: Copies the current line and inserts onto a new line below To test: Verify all functionality above and confirm it behaves as expected Note: Ctrl-v pastes from the system clipboard - codemirror does not have access and this is why we use our "Clipboard" For browser cut/paste please use mouse right click or context menus Ctrl-P can be accessed as print by focusing outside the editor window Signed-off-by: Alex Sassmannshausen <alex@komputilo.eu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 93677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93677&action=edit Bug 17179: (follow-up) Correct typos, add default select. Correct error whereby object curCursor was invoked as a function. Added action whereby the most recent entry in the clipboard is selected after all copy and cut operations. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93676|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 93857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93857&action=edit Bug 17179: Add keyboard shortcuts to repeat (duplicate) a field, and cut text This patchset introduces an internal clipboard to the advanced editor and provides some new functionality to make use of this, default shortcuts are provided but can be edited per bug 21411 The default shortcuts for new/changed functions are: Changed: Ctrl-X: Now cuts a line into the clipboard area Shift-Ctrl-X: Now cuts current subfield into clipboard area Added: Ctrl-C: Copies a line into the clipboard area Shift-Ctrl-C: Copies current subfield into clipboard area Ctrl-P: Pastes the selected item from the clipboard at cursor Ctrl-I: Copies the current line and inserts onto a new line below To test: Verify all functionality above and confirm it behaves as expected Note: Ctrl-v pastes from the system clipboard - codemirror does not have access and this is why we use our "Clipboard" For browser cut/paste please use mouse right click or context menus Ctrl-P can be accessed as print by focusing outside the editor window Signed-off-by: Alex Sassmannshausen <alex@komputilo.eu> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93677|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 93858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93858&action=edit Bug 17179: (follow-up) Correct typos, add default select. Correct error whereby object curCursor was invoked as a function. Added action whereby the most recent entry in the clipboard is selected after all copy and cut operations. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, going back to failed - just realized changes to installer/data/mysql/mandatory/keyboard_shortcuts.sql are missing :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 93861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93861&action=edit Bug 17179: (follow-up) Add to kyeboard_shortcuts.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93857|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 93897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93897&action=edit Bug 17179: Add keyboard shortcuts to repeat (duplicate) a field, and cut text This patchset introduces an internal clipboard to the advanced editor and provides some new functionality to make use of this, default shortcuts are provided but can be edited per bug 21411 The default shortcuts for new/changed functions are: Changed: Ctrl-X: Now cuts a line into the clipboard area Shift-Ctrl-X: Now cuts current subfield into clipboard area Added: Ctrl-C: Copies a line into the clipboard area Shift-Ctrl-C: Copies current subfield into clipboard area Ctrl-P: Pastes the selected item from the clipboard at cursor Ctrl-I: Copies the current line and inserts onto a new line below To test: Verify all functionality above and confirm it behaves as expected Note: Ctrl-v pastes from the system clipboard - codemirror does not have access and this is why we use our "Clipboard" For browser cut/paste please use mouse right click or context menus Ctrl-P can be accessed as print by focusing outside the editor window Signed-off-by: Alex Sassmannshausen <alex@komputilo.eu> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93858|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 93898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93898&action=edit Bug 17179: (follow-up) Correct typos, add default select. Correct error whereby object curCursor was invoked as a function. Added action whereby the most recent entry in the clipboard is selected after all copy and cut operations. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 93899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93899&action=edit Bug 17179: (follow-up) Add to keyboard_shortcuts.sql Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93861|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Sponsored by: Round Rock release notes| |Public Library CC| |joy@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Text to go in the|Sponsored by: Round Rock |This patchset introduces an release notes|Public Library |internal clipboard to the | |advanced editor and | |provides some new | |functionality to make use | |of it; The following | |default shortcuts are | |provided but can be edited | |as per bug 21411. | | | |Changed: | |* `Ctrl-X`: Now cuts a line | |into the clipboard area | |* | |`Shift-Ctrl-X`: Now cuts | |current subfield into | |clipboard area | | | |Added: | |* | |`Ctrl-C`: Copies a line | |into the clipboard area | |* | |`Shift-Ctrl-C`: Copies | |current subfield into | |clipboard area | |* `Ctrl-P`: | |Pastes the selected item | |from the clipboard at | |cursor | |* `Ctrl-I`: Copies | |the current line and | |inserts onto a new line | |below -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Added text for the release notes and moved the sponsored by details into a follow-up commit which has been pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Margaret <margaret@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |margaret@bywatersolutions.c | |om Text to go in the|This patchset introduces an |This patchset introduces an release notes|internal clipboard to the |internal clipboard to the |advanced editor and |advanced editor and |provides some new |provides some new |functionality to make use |functionality to make use |of it; The following |of it; The following |default shortcuts are |default shortcuts are |provided but can be edited |provided but can be edited |as per bug 21411. |as per bug 21411. | | |Changed: |Changed: |* `Ctrl-X`: Now cuts a line |* `Ctrl-X`: Now cuts a line |into the clipboard area |into the clipboard area |* |* |`Shift-Ctrl-X`: Now cuts |`Shift-Ctrl-X`: Now cuts |current subfield into |current subfield into |clipboard area |clipboard area | | |Added: |Added: |* |* |`Ctrl-C`: Copies a line |`Ctrl-C`: Copies a line |into the clipboard area |into the clipboard area |* |* |`Shift-Ctrl-C`: Copies |`Shift-Ctrl-C`: Copies |current subfield into |current subfield into |clipboard area |clipboard area |* `Ctrl-P`: |* `Ctrl-P`: |Pastes the selected item |Pastes the selected item |from the clipboard at |from the clipboard at |cursor |cursor |* `Ctrl-I`: Copies |* `Ctrl-I`: Copies |the current line and |the current line and |inserts onto a new line |inserts onto a new line |below |below | | | |Sponsored by: Round | |Rock Public Library | |<https://www.roundrocktexas | |.gov/departments/library/> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patchset introduces an |This patchset introduces an release notes|internal clipboard to the |internal clipboard to the |advanced editor and |advanced editor and |provides some new |provides some new |functionality to make use |functionality to make use |of it; The following |of it; The following |default shortcuts are |default shortcuts are |provided but can be edited |provided but can be edited |as per bug 21411. |as per bug 21411. | | |Changed: |Changed: |* `Ctrl-X`: Now cuts a line |* `Ctrl-X`: Now cuts a line |into the clipboard area |into the clipboard area |* |* |`Shift-Ctrl-X`: Now cuts |`Shift-Ctrl-X`: Now cuts |current subfield into |current subfield into |clipboard area |clipboard area | | |Added: |Added: |* |* |`Ctrl-C`: Copies a line |`Ctrl-C`: Copies a line |into the clipboard area |into the clipboard area |* |* |`Shift-Ctrl-C`: Copies |`Shift-Ctrl-C`: Copies |current subfield into |current subfield into |clipboard area |clipboard area |* `Ctrl-P`: |* `Ctrl-P`: |Pastes the selected item |Pastes the selected item |from the clipboard at |from the clipboard at |cursor |cursor |* `Ctrl-I`: Copies |* `Ctrl-I`: Copies |the current line and |the current line and |inserts onto a new line |inserts onto a new line |below |below | | |Sponsored by: Round | |Rock Public Library | |<https://www.roundrocktexas | |.gov/departments/library/> | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #28 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- I feel that this feature has caused some usability issues. I find it odd that Ctrl-C has been remapped to copy the whole field to the clipboard. I like the feature, but the default should be a different key combination. I encountered this because I was trying to copy an ISBN as part of testing for bug 21665 and noticed that after selecting the text nothing was happening when I pressed Ctrl-C, no copying to the new clipboard, no copying to my computer's clipboard, nothing. It took me a while to figure out what was going on and how the new shortcut was supposed to be used, and I imagine a lot of users will encounter similar difficulties. I am aware that the shortcut can be remapped, but I feel that using Ctrl-C as the default is confusing and frustrating, especially when it functions the same way in basically every other software program. I propose that for new installations we change the mapping to be Ctrl-E or something similar. Thoughts? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27769 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27769 [Bug 27769] Advanced editor shouldn't break copying selected text with Ctrl+C -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #29 from Phil Ringnalda <phil@chetcolibrary.org> --- I filed bug 27769 for that. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org