[Bug 26429] New: If a waiting hold has expired (date has passed)- looking at the request.pl page, the expiration date is for tomorrow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26429 Bug ID: 26429 Summary: If a waiting hold has expired (date has passed)- looking at the request.pl page, the expiration date is for tomorrow Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com To recreate: 1. Have a waiting hold - the expiration date of 9/9/2020. 2. Reserve table shows 9/9, request.pl shows 9/9 3. Fast forward to 9/10 4. If library is not expiring holds, this hold expiration date will now show the expiration date of 9/11 on the request.pl page. 5. The reserve table still shows the 9/9 date. It would appear that since the date picker (from the reserves.pl page) can not show dates in the past or even for the current date, it will show the next available date. This is confusing! This bug seems very relevant to the bug I am filing: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21147 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26429 Chris Slone <cslone@camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone@camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26429 --- Comment #1 from Chris Slone <cslone@camdencountylibrary.org> --- I can also confirm that we are seeing this and finding it confusing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26429 Emmi Takkinen <emmi.takkinen@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen@outlook.com --- Comment #2 from Emmi Takkinen <emmi.takkinen@outlook.com> --- My bad. I used "datepickerto" class (which is actually used when e.g filtering between dates) instead of adding "futuredate" class to this specific field in bug 25789. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26429 Emmi Takkinen <emmi.takkinen@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |emmi.takkinen@outlook.com |ity.org | Status|NEW |Needs Signoff --- Comment #3 from Emmi Takkinen <emmi.takkinen@outlook.com> --- Created attachment 110748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110748&action=edit Bug 26429: Show correct expiration date at the request.pl Bug 25789 changed holds tables expriration input class as "datepickerto". This results to past expiration date to be displayed as tomorrows date. Class "futuredate" should have been used instead. To test: 1. Have waiting hold with expiration date in past (e.g 24.9) 2. Observe that waiting reserves table displays correct expiration date 3. At the request.pl page expiration date is however displayed as 26.9 => Apply patch 4. Confirm that expiration date at the request.pl is now 24. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26429 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26429 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110748|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 111312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111312&action=edit Bug 26429: Show correct expiration date at the request.pl Bug 25789 changed holds tables expriration input class as "datepickerto". This results to past expiration date to be displayed as tomorrows date. Class "futuredate" should have been used instead. To test: 1. Have waiting hold with expiration date in past (e.g 24.9) 2. Observe that waiting reserves table displays correct expiration date 3. At the request.pl page expiration date is however displayed as 26.9 => Apply patch 4. Confirm that expiration date at the request.pl is now 24.9 Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26429 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|If a waiting hold has |If a waiting hold has |expired (date has passed)- |expired the expiration date |looking at the request.pl |on the holds page shows for |page, the expiration date |tomorrow |is for tomorrow | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26429 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26429 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111312|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111564&action=edit Bug 26429: Show correct expiration date at the request.pl Bug 25789 changed holds tables expriration input class as "datepickerto". This results to past expiration date to be displayed as tomorrows date. Class "futuredate" should have been used instead. To test: 1. Have waiting hold with expiration date in past (e.g 24.9) 2. Observe that waiting reserves table displays correct expiration date 3. At the request.pl page expiration date is however displayed as 26.9 => Apply patch 4. Confirm that expiration date at the request.pl is now 24.9 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26429 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25789 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25789 [Bug 25789] New expiration date on placing a hold in staff interface can be set to a date in the past -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26429 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26429 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz, | |hayleymapley@catalyst.net.n | |z, | |lucas@bywatersolutions.com --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- @RMaints, you will need this one for the next stable releases. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26429 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Emmy, I confirm that it fixes the problem, but I don't really understand something: I've tried to find out other wrong occurrences in our code and found one in serials/serials-search.tt. We have datepickerto without datepickerfrom. However the date in the past is kept correctly there. Why that? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26429 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26429 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26429 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.06 released in| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26429 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 20.05.06 |20.11.00, 20.05.06, released in| |19.11.12 Status|Pushed to stable |Pushed to oldstable --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26429 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Missing dependencies for 19.05.x, can't backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26429 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |didier.gautheron@biblibre.c | |om --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 28124 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org