[Bug 9147] New: OPAC hidden fields are not hidden in ISBD view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9147 Bug ID: 9147 Summary: OPAC hidden fields are not hidden in ISBD view Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: fridolyn.somers@biblibre.com When in framework a subfield has a number > 0 in hidden, it his hidden in MARCview. It should be hidden also in ISBD view. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9147 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |fridolyn.somers@biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 13680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13680&action=edit Proposed patch Small proposed patch. Test hidding a subfield into a field and into a field+subfield in ISBD syspref. For example : Syspref ISBD : #200 ... #200y ... Try to hide 200$y at OPAC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9147 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13680|0 |1 is obsolete| | --- Comment #2 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 13681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13681&action=edit Proposed patch (rebased master) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9147 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7933 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9147 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13681|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 13961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13961&action=edit Bug 9147: OPAC hidden fields are not hidden in ISBD view Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Does what it says, hides hidden fields on the OPAC -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9147 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9147 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9147 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13961|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 14619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14619&action=edit [SIGNED-OFF] Bug 9147: OPAC hidden fields are not hidden in ISBD view When in framework a subfield has a number > 0 in hidden, it his hidden in MARCview. It should be hidden also in ISBD view. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Does what it says, hides hidden fields on the OPAC Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass. To test: 1) Hide 245$b or another field from ISBD view in your MARC framework by assigning a hidden value greater 0 2) Check the different views in OPAC, the field should be hidden now from - Labelled MARC view (as it was before this patch) - ISBD view It will still show up for plain MARC and XSLT views. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9147 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9147 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9147 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9147 --- Comment #6 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Can it be pushed to stable versions ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9147 --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Yes it can be, however it changed templates when we were in string freeze so couldn't be pushed before 3.10.2 and 3.8.9 were released. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9147 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x will be in 3.10.3 and 3.8.10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9147 --- Comment #9 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to comment #8)
Pushed to 3.10.x and 3.8.x will be in 3.10.3 and 3.8.10
Perfect, thanks a lot. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org