[Bug 34262] New: Merging duplicate patrons in succession is adding previously merged duplicate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34262 Bug ID: 34262 Summary: Merging duplicate patrons in succession is adding previously merged duplicate Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: esther.melander@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Merging duplicate patrons in succession is adding previously merged duplicates into the merge options. To Recreate: 1. Self-register Patron A multiple times through the OPAC. 2. Self-register Patron B multiple times through the OPAC. 3. Search for Patron A and merge some of the duplicates. 4. Search for Patron B and select some of the duplicates. On the next screen selected Patron B duplicates will be shown as well as the previously merged account of Patron A. 5. Select a Patron B account as the surviving record and proceed to merge. Patron B accounts are merged to the surviving record as well as Patron A's account, causing Patron A to no longer exist. The current work around is to log out of the staff account and log back in. This seems to clear the session data and allow the proper selections to appear, minus the previously merged account. However, this is not practical when needing to merge a lot of accounts. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34262 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #1 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Hi Esther, this is a new feature that was added in bug 29971 to make it possible to merge patrons that don't show up on the same page of the search. To the right of the "merge selected patrons" button, there should be another button that says "Patrons selected: N x Clear" (where N is the number of patrons that are currently selected/remembered). Clicking that button after performing a patron merge should clear the previous selection and ensure that only patrons selected after that are merged. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34262 --- Comment #2 from Esther Melander <esther.melander@bywatersolutions.com> --- Thank you, that was not on my radar. I wonder if some improvements can be made with this though. With all of the testing I did, I did not see that button. Perhaps better contrast. Bolding, changing the font color to red, etc. Right now the coloring of that button is reading as nothing unless pointed out. This is especially true for aging eyes and accessibility. If the user doesn't see that button, then it causes no end of difficulty. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34262 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Merging duplicate patrons |Add styling to emphasize |in succession is adding |the "clear selected |previously merged duplicate |patrons" button -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34262 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- If you'd like to customize the style of the message you could add some custom CSS. By default it has this style: #patron_search_selected { background-color: #fafdfa; border: 1px solid #408540; border-color: #93cb93 #d8ecd8 #d8ecd8 #93cb93; border-radius: 3px; color: #333; display: inline-block; font-size: 11px; line-height: 1.5; padding: 5px 10px; text-align: center; vertical-align: middle; white-space: nowrap; } For a more highlighted version you could put this (for example) in the IntranetUserCSS system preference: #patron_search_selected { background-color: #fffbc2; border: 1px solid #ff0c00; border-color: #ff0c00 #ecafaf #ecafaf #ff0c00; font-size: 13px; font-weight: bold; } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34262 --- Comment #4 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34262 Chris Slone <cslone@camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone@camdencountylibrary. | |org --- Comment #5 from Chris Slone <cslone@camdencountylibrary.org> --- I don't think that emphasizing the button is the total fix here, this is retaining selected patrons past the point that it makes logical sense; if you merge 14 records then do a totally new search it still considers those 14 records to be selected. And it's not just for merging patrons, it's any previous selection, so adding patrons to a list, selecting for batch edit... Besides the fact that considering 13 records that have been deleted as still being selected, something like merging patrons is a destructive change (to the old records) and so that function at least should clear it out. I think this is just setting people up for errors. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34262 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34262 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Chris Slone from comment #5)
I don't think that emphasizing the button is the total fix here, this is retaining selected patrons past the point that it makes logical sense; if you merge 14 records then do a totally new search it still considers those 14 records to be selected. And it's not just for merging patrons, it's any previous selection, so adding patrons to a list, selecting for batch edit...
Besides the fact that considering 13 records that have been deleted as still being selected, something like merging patrons is a destructive change (to the old records) and so that function at least should clear it out.
I think this is just setting people up for errors.
Perhaps the "remember patrons" feature implemented in Bug 29971 should be optional. Maybe a sys pref on/off switch? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34262 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34479 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34262 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.11 |Main -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org