[Bug 8981] New: Remove Nonpublic General Note from OPAC authorities display
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8981 Priority: P5 - low Change sponsored?: --- Bug ID: 8981 Assignee: oleonard@myacpl.org Summary: Remove Nonpublic General Note from OPAC authorities display Severity: minor Classification: Unclassified OS: All Reporter: dcook@prosentient.com.au Hardware: All Status: NEW Version: master Component: OPAC Product: Koha Currently, the MARC21 667 Nonpublic General Note field is appearing on the opac-authoritiesdetail.pl page. Since it is a nonpublic note, it makes sense to remove it from this view. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8981 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 13105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13105&action=edit Remove Nonpublic General Note from OPAC authorities display To test: 1) Find authority records in your database that have a 667 field by using the following SQL: SELECT authid,ExtractValue(marcxml,'//datafield[@tag="667"]/*') AS info FROM auth_header HAVING info <> ''; 2) Go to the page using the following query string: /cgi-bin/koha/opac-authoritiesdetail.pl?authid=<<authid from above>> 3) Note that the nonpublic general note appears on the screen 4) Apply patch 5) Reload page, and notice the 667 disappear without affecting any of the other fields -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8981 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13105|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 13239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13239&action=edit Bug 8981 - Remove Nonpublic General Note from OPAC authorities display Currently, the MARC21 667 Nonpublic General Note field is appearing on the opac-authoritiesdetail.pl page. Since it is a nonpublic note, it makes sense to remove it from this view. This patch adds in an extra condition that checks authority records for MARC21 667 fields before displaying them in this opac screen. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Does what it says, with no side effects -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8981 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8981 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13239|0 |1 is obsolete| | --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 13776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13776&action=edit Bug 8981 - Remove Nonpublic General Note from OPAC authorities display Currently, the MARC21 667 Nonpublic General Note field is appearing on the opac-authoritiesdetail.pl page. Since it is a nonpublic note, it makes sense to remove it from this view. This patch adds in an extra condition that checks authority records for MARC21 667 fields before displaying them in this opac screen. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Does what it says, with no side effects Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8981 --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 13777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13777&action=edit Bug 8981 follow-up: case While QAing your patch, I saw you were writting "MarcFlavour", it should have been "marcflavour" Will work with the UC, but let's be consistent. This patch fixes another MarcFlavour just a few lines before I spotted by chance -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8981 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com Patch complexity|--- |Trivial patch QA Contact| |paul.poulain@biblibre.com --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * passes koha-qa.pl * won't say anything about the feature itself because i'm not a MARC21 specialist, but do what it announce * you wrote "MarcFlavour" instead of "marcflavour" for the system preference, it works, but it's better to use the syspref form, so I've uploaded a follow-up that just fixes the wording. passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8981 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jcamins@cpbibliography.com --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8981 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x, will be in 3.10.1 and 3.8.8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8981 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |liz@catalyst.net.nz Resolution|--- |FIXED --- Comment #8 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Does not apply on 3.6.x, please submit a 3.6 patch if necessary. Thanks! Liz -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org