[Bug 40816] New: Upgrade DataTables from 2.1.8 to >2.3.4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Bug ID: 40816 Summary: Upgrade DataTables from 2.1.8 to >2.3.4 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 36640 Blocks: 38259 eg. bug 38259 needs DataTables 2.3+ for lengthLabels Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 [Bug 36640] Upgrade DataTables from 1.13.6 to 2.x https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38259 [Bug 38259] Adjust DT's lengthMenu option -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186448&action=edit Bug 40816: DT - Update css and js files -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186449&action=edit Bug 40816: Cherry-pick previous manual changes after update This is a cherry-pick of commit e0193051e173557351d3da6697cb5f9c3e801185 Bug 36640: (follow-up) CSS fixes for DataTables controls I have only kept the changes to datatables.css -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186450&action=edit Bug 40816: [DO NOT PUSH] Use .css instead of .min.css What the clean way to generate the min version? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186451&action=edit Bug 40816: Fix sort icons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org Status|NEW |In Discussion --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Why do we have a lot of duplicated CSS rules between _tables.scss and _common.scss? Shouldn't all the .dataTable rules from _common be moved to _tables? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41137 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 188979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188979&action=edit Bug 40816: Remove !important from the min version -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186450|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #5)
Why do we have a lot of duplicated CSS rules between _tables.scss and _common.scss?
Shouldn't all the .dataTable rules from _common be moved to _tables?
Let's do that on a separate bug report if needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186448|0 |1 is obsolete| | Attachment #186449|0 |1 is obsolete| | Attachment #186451|0 |1 is obsolete| | Attachment #188979|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 188991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188991&action=edit Bug 40816: DT - Update css and js files Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 188992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188992&action=edit Bug 40816: Cherry-pick previous manual changes after update This is a cherry-pick of commit e0193051e173557351d3da6697cb5f9c3e801185 Bug 36640: (follow-up) CSS fixes for DataTables controls I have only kept the changes to datatables.css Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 188993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188993&action=edit Bug 40816: Fix sort icons Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 188994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188994&action=edit Bug 40816: Remove !important from the min version Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- We should do the same for the OPAC shouldn't we? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Owen Leonard from comment #12)
We should do the same for the OPAC shouldn't we?
Yes! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37024 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #14 from David Nind <david@davidnind.com> --- The license details in the about page also needs updating. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 189599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189599&action=edit Bug 40816: DT - Update css and js files - OPAC Patch from commit 372bfb4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 189600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189600&action=edit Bug 40816: Remove !important from css files - OPAC Patch from commit 20bdf8f -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 189601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189601&action=edit Bug 40816: Adjust about page Patch from commit 42a5269 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- It's still missing a "Fix sort icons" patch for the OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 189605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189605&action=edit Bug 40816: (follow-up) CSS updates for table sorting icons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 189606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189606&action=edit Bug 40816: (follow-up) CSS updates for table sorting icons Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189605|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #21 from Jonathan Druart <jonathan.druart@gmail.com> --- OPAC is ready for testing! :) Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |victor@tuxayo.net --- Comment #22 from Victor Grousset/tuxayo <victor@tuxayo.net> --- This test fails with the patches: t/db_dependent/selenium/patrons_search.t # at t/db_dependent/selenium/patrons_search.t line 660. Error while executing command: no such element: Unable to locate element: //table[@id="memberresultst"]//th[@aria-label="Date of birth: Activate to sort"]/input at /usr/share/perl5/Selenium/Remote/Driver.pm line 411. (I'm sorting out Cypress issues also check them) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #23 from Jonathan Druart <jonathan.druart@gmail.com> --- Ha, I think it's where I left this bug and why I was asking comment 5. There is the sorting arrows not correctly displayed in the headers, and the class is no longer on the the but in a span child. https://snipboard.io/olhaYc.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #24 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 190614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190614&action=edit Bug 40816: (follow-up) Standardize sort icon alignment DataTables wants to change the alignment of the sorting icons when it detects the column contents as numeric or date. This patch overrides that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #25 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 190615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190615&action=edit Bug 40816: Fix a failing Selenium test Patch from commit 3040a99 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #26 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Thanks for the fix :) (In reply to Victor Grousset/tuxayo from comment #22)
(I'm sorting out Cypress issues also check them)
Finally! Unfortunately there are 3 tests that fails with the patches: cypress run --config video=false --spec "t/cypress/integration/Tools/ManageMarcImport_spec.ts,t/cypress/integration/Auth/csrf.ts,t/cypress/integration/ERM/Agreements_spec.ts" ------------- 1) loads the manage MARC import page upload a MARC record: AssertionError: Timed out retrying after 10000ms: Expected to find content: 'View batch' but never did. at Context.eval (webpack://koha/./t/cypress/integration/Tools/ManageMarcImport_spec.ts:75:11) ---------------- 1) CSRF Add: AssertionError: Timed out retrying after 10000ms: Expected to find element: `select[name='libraries_length']`, but never found it. at Context.eval (webpack://koha/./t/cypress/integration/Auth/csrf.ts:112:11) -------------------- 1) Agreement CRUD operations Delete agreement: Error: The following error originated from your application code, not from Cypress.
ResizeObserver loop limit exceeded
When Cypress detects uncaught errors originating from your application it will automatically fail the current test. This behavior is configurable, and you can choose to turn this off by listening to the `uncaught:exception` event. https://on.cypress.io/uncaught-exception-from-application at <unknown> (http://koha:8081/cgi-bin/koha/erm/agreements:0:0) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #27 from Victor Grousset/tuxayo <victor@tuxayo.net> --- QA script complains about koha-tmpl/opac-tmpl/lib/datatables/datatables.min.js but it shouldn't be checked so it's a false positive. Since it's only checked when being touched by a commit, that doesn't seem to an issue even if left as is. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #28 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 190937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190937&action=edit Bug 40816: Fix Auth/csrf.ts Patch from commit b69cdec -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #29 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 190938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190938&action=edit Bug 40816: Ignore 'ResizeObserver loop limit exceeded' I have NO idea how to fix this error. I don't see it on the Koha UI, neither using Cypress UI. It seems safe for now to ignore this error (The internet says so). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #30 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Victor Grousset/tuxayo from comment #26)
cypress run --config video=false --spec "t/cypress/integration/Tools/ManageMarcImport_spec.ts,t/cypress/integration/ Auth/csrf.ts,t/cypress/integration/ERM/Agreements_spec.ts"
------------- 1) loads the manage MARC import page upload a MARC record: AssertionError: Timed out retrying after 10000ms: Expected to find content: 'View batch' but never did. at Context.eval (webpack://koha/./t/cypress/integration/Tools/ManageMarcImport_spec.ts:75:11)
Known random failure, see bug 41368.
1) CSRF Add: AssertionError: Timed out retrying after 10000ms: Expected to find element: `select[name='libraries_length']`, but never found it. at Context.eval (webpack://koha/./t/cypress/integration/Auth/csrf.ts:112:11)
Should be fixed.
1) Agreement CRUD operations Delete agreement:
Error: The following error originated from your application code, not from Cypress.
ResizeObserver loop limit exceeded
When Cypress detects uncaught errors originating from your application it will automatically fail the current test.
This behavior is configurable, and you can choose to turn this off by listening to the `uncaught:exception` event.
https://on.cypress.io/uncaught-exception-from-application at <unknown> (http://koha:8081/cgi-bin/koha/erm/agreements:0:0)
I am stuck on this one, I've decided to ignore the error for now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #31 from David Cook <dcook@prosentient.com.au> --- So what do we need to do to move this one forward? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #32 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Cook from comment #31)
So what do we need to do to move this one forward?
It's ready for QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #33 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #32)
(In reply to David Cook from comment #31)
So what do we need to do to move this one forward?
It's ready for QA.
Ok, I'll take a look... Little merge conflict but easy enough to fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |dcook@prosentient.com.au |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188991|0 |1 is obsolete| | --- Comment #34 from David Cook <dcook@prosentient.com.au> --- Created attachment 193272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193272&action=edit Bug 40816: DT - Update css and js files Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188992|0 |1 is obsolete| | --- Comment #35 from David Cook <dcook@prosentient.com.au> --- Created attachment 193273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193273&action=edit Bug 40816: Cherry-pick previous manual changes after update This is a cherry-pick of commit e0193051e173557351d3da6697cb5f9c3e801185 Bug 36640: (follow-up) CSS fixes for DataTables controls I have only kept the changes to datatables.css Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188993|0 |1 is obsolete| | --- Comment #36 from David Cook <dcook@prosentient.com.au> --- Created attachment 193274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193274&action=edit Bug 40816: Fix sort icons Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188994|0 |1 is obsolete| | --- Comment #37 from David Cook <dcook@prosentient.com.au> --- Created attachment 193275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193275&action=edit Bug 40816: Remove !important from the min version Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189599|0 |1 is obsolete| | --- Comment #38 from David Cook <dcook@prosentient.com.au> --- Created attachment 193276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193276&action=edit Bug 40816: DT - Update css and js files - OPAC Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189600|0 |1 is obsolete| | --- Comment #39 from David Cook <dcook@prosentient.com.au> --- Created attachment 193277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193277&action=edit Bug 40816: Remove !important from css files - OPAC Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189601|0 |1 is obsolete| | --- Comment #40 from David Cook <dcook@prosentient.com.au> --- Created attachment 193278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193278&action=edit Bug 40816: Adjust about page Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189606|0 |1 is obsolete| | --- Comment #41 from David Cook <dcook@prosentient.com.au> --- Created attachment 193279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193279&action=edit Bug 40816: (follow-up) CSS updates for table sorting icons Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190614|0 |1 is obsolete| | --- Comment #42 from David Cook <dcook@prosentient.com.au> --- Created attachment 193280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193280&action=edit Bug 40816: (follow-up) Standardize sort icon alignment DataTables wants to change the alignment of the sorting icons when it detects the column contents as numeric or date. This patch overrides that. Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190615|0 |1 is obsolete| | --- Comment #43 from David Cook <dcook@prosentient.com.au> --- Created attachment 193281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193281&action=edit Bug 40816: Fix a failing Selenium test Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190937|0 |1 is obsolete| | --- Comment #44 from David Cook <dcook@prosentient.com.au> --- Created attachment 193282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193282&action=edit Bug 40816: Fix Auth/csrf.ts Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190938|0 |1 is obsolete| | --- Comment #45 from David Cook <dcook@prosentient.com.au> --- Created attachment 193283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193283&action=edit Bug 40816: Ignore 'ResizeObserver loop limit exceeded' I have NO idea how to fix this error. I don't see it on the Koha UI, neither using Cypress UI. It seems safe for now to ignore this error (The internet says so). Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37024 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37024 [Bug 37024] Scrolling "glitch" for some tables with sticky headers (that use DataTables) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #46 from David Cook <dcook@prosentient.com.au> --- Looks good and works for me. False positives on the QA tools and tests pass. I'll be glad to get DT updated so we can update it again soon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Upgrade the DataTables release notes| |JavaScript library from | |version 2.1.8 to 2.3.4. | | | |This brings in upstream | |fixes and improvements | |released since 2.1.8, | |including bug fixes and | |general stability updates. | | | |No functional changes are | |expected in Koha beyond | |those provided by the | |updated DataTables library. Keywords|release-notes-needed | Summary|Upgrade DataTables from |Upgrade DataTables from |2.1.8 to >2.3.4 |2.1.8 to 2.3.4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42003 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42003 [Bug 42003] Upgrade DataTables from 2.3.4 to 2.3.7 (and FixedHeader to 4.0.6) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Upgrade the DataTables |This enhancement upgrades release notes|JavaScript library from |the DataTables JavaScript |version 2.1.8 to 2.3.4. |library from version 2.1.8 | |to 2.3.4. |This brings in upstream | |fixes and improvements |This brings in upstream |released since 2.1.8, |fixes and improvements |including bug fixes and |released since 2.1.8, |general stability updates. |including bug fixes and | |general stability updates. |No functional changes are | |expected in Koha beyond |No functional changes are |those provided by the |expected in Koha beyond |updated DataTables library. |those provided by the | |updated DataTables library. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #47 from David Cook <dcook@prosentient.com.au> --- Jonathan pointed out on bug 42003 that in patron search the following happens when using filters: Before: Patrons found for: Library=Institut Protestant de Théologie, Category=Inter-Library Loan After: Patrons found for: Library =Institut Protestant de Théologie, Category =Inter-Library Loan It's because the Datatable header used to just be two span elements but now they're wrapper in a <div> which has a default "display: block" CSS property. In koha-tmpl/intranet-tmpl/prog/js/datatables.js you can see the following: 1363 column_searches.push( 1364 "%s=%s".format( 1365 table_dt.column(i).header().innerHTML, 1366 search 1367 ) 1368 ); That's what's setting up this %s=%s text... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #48 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #47)
Jonathan pointed out on bug 42003 that in patron search the following happens when using filters:
Before: Patrons found for: Library=Institut Protestant de Théologie, Category=Inter-Library Loan
After: Patrons found for: Library =Institut Protestant de Théologie, Category =Inter-Library Loan
It's because the Datatable header used to just be two span elements but now they're wrapper in a <div> which has a default "display: block" CSS property.
In koha-tmpl/intranet-tmpl/prog/js/datatables.js you can see the following:
1363 column_searches.push( 1364 "%s=%s".format( 1365 table_dt.column(i).header().innerHTML, 1366 search 1367 ) 1368 );
That's what's setting up this %s=%s text...
I don't know if anywhere but koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc actually uses the "show_search_descriptions" option of $.fn.kohaTable... I am struggling to find somewhere else. As a positional argument, it's pretty tough to grep for this one... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #49 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #48)
I don't know if anywhere but koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc actually uses the "show_search_descriptions" option of $.fn.kohaTable... I am struggling to find somewhere else. As a positional argument, it's pretty tough to grep for this one...
So I've got two ideas for this one... One is to update the CSS just for the patron search page to change the div in question to an inline display. The other is to change datatables.js to use ".textContent" rather than ".innerHTML". I actually think I like this one better, because we don't actually need the HTML. We just need the text content. My only reservation about the latter is that I don't know where all these search descriptions end up. I've only noticed patron search so far but it could be elsewhere, since kohaTable is used in a lot of places. Anyway, I'll add both and people can pick and choose... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #50 from David Cook <dcook@prosentient.com.au> --- Created attachment 194613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194613&action=edit Bug 40816: (follow-up) make search description inline for patron search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #51 from David Cook <dcook@prosentient.com.au> --- Created attachment 194614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194614&action=edit Bug 40816: (follow-up) change DataTables search descriptions to use text rather than HTML We shouldn't really be picking the HTML from the header when all we really need is the text content of the header cell. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194613|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194614|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #52 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 194621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194621&action=edit Bug 40816: (follow-up) change DataTables search descriptions to use text rather than HTML We shouldn't really be picking the HTML from the header when all we really need is the text content of the header cell. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #53 from Jonathan Druart <jonathan.druart@gmail.com> --- Excellent, thanks David! The second patch is definitely better. I am not aware of other places where we use the search description. Yes I do agree that the list of parameters we pass to kohaTable is too long and we should use named parameters instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #54 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #53)
Yes I do agree that the list of parameters we pass to kohaTable is too long and we should use named parameters instead.
Opened bug 42009. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED Depends on| |42048 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #58 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Sorry guys, this no longer applies.. I'll work through the QA of the other dependant bug too once this applies (and it applies too). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193272|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193273|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193274|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193275|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193276|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193277|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193278|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193279|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193280|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193281|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193282|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193283|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #59 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195812&action=edit Bug 40816: DT - Update css and js files Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #60 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195813&action=edit Bug 40816: Cherry-pick previous manual changes after update This is a cherry-pick of commit e0193051e173557351d3da6697cb5f9c3e801185 Bug 36640: (follow-up) CSS fixes for DataTables controls I have only kept the changes to datatables.css Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #61 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195814&action=edit Bug 40816: Fix sort icons Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #62 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195815&action=edit Bug 40816: Remove !important from the min version Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #63 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195816&action=edit Bug 40816: DT - Update css and js files - OPAC Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #64 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195817&action=edit Bug 40816: Remove !important from css files - OPAC Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #65 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195818&action=edit Bug 40816: Adjust about page Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #66 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195819&action=edit Bug 40816: (follow-up) CSS updates for table sorting icons Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #67 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195820&action=edit Bug 40816: (follow-up) Standardize sort icon alignment DataTables wants to change the alignment of the sorting icons when it detects the column contents as numeric or date. This patch overrides that. Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #68 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195821&action=edit Bug 40816: Fix a failing Selenium test Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #69 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195822&action=edit Bug 40816: Fix Auth/csrf.ts Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #70 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195823&action=edit Bug 40816: Ignore 'ResizeObserver loop limit exceeded' I have NO idea how to fix this error. I don't see it on the Koha UI, neither using Cypress UI. It seems safe for now to ignore this error (The internet says so). Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #71 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Martin Renvoize (ashimema) from comment #58)
Sorry guys, this no longer applies.. I'll work through the QA of the other dependant bug too once this applies (and it applies too).
Reuploaded, but they applied for me. Did you see that they depend on a security bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #72 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Do we care about this QA tool complaints? [FAIL] koha-tmpl/opac-tmpl/lib/datatables/datatables.js FAIL forbidden_patterns forbidden pattern: console.log (line 13225) WARN spelling get's ==> gets accessability ==> accessibility accessability ==> accessibility Statics ==> Statistics [PASS] koha-tmpl/opac-tmpl/lib/datatables/datatables.min.css [FAIL] koha-tmpl/opac-tmpl/lib/datatables/datatables.min.js FAIL forbidden_patterns forbidden pattern: console.log (line 16) forbidden pattern: Use __("") instead of _("") (line 16) WARN spelling Ue ==> Use, Due ue ==> use, due ue ==> use, due ue ==> use, due Ue ==> Use, Due Ue ==> Use, Due -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #73 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Lucas Gass (lukeg) from comment #72)
Do we care about this QA tool complaints?
I wouldn't think so. Those are all issues with DataTables official file distributions and it wouldn't make sense for us to make changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #74 from David Cook <dcook@prosentient.com.au> --- (In reply to Owen Leonard from comment #73)
(In reply to Lucas Gass (lukeg) from comment #72)
Do we care about this QA tool complaints?
I wouldn't think so. Those are all issues with DataTables official file distributions and it wouldn't make sense for us to make changes.
Agreed. We can ignore these since they're from upstream. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194621|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 --- Comment #75 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #76 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #77 from David Nind <david@davidnind.com> --- Underlying library update, no changes required to the manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Unsponsored Strategic theme|--- |Developer Experience Target Milestone|--- |26.05 Initiative type|--- |Epic -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Initiative type|Epic |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42836 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42836 [Bug 42836] Improve our use of DataTables across the codebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40816 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Initiative type|--- |Epic -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org