https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 --- Comment #1 from Lisette Scheer <lisetteslatah@gmail.com> --- Created attachment 95448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95448&action=edit Bug 24033 : Fix column labelling on basket summary page (ecost) When viewing a basket, some of the column names are unclear and are different than the terms used for the same field on the order form. This patch edits the column titles to match -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95448|0 |1 is obsolete| | --- Comment #2 from Lisette Scheer <lisetteslatah@gmail.com> --- Created attachment 95449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95449&action=edit Bug 24033 : Fix column labelling on basket summary page (ecost) When viewing a basket, some of the column names are unclear and are different than the terms used for the same field on the order form. This patch edits the column titles to match To test: 1)In acquisitions, create a budget. 2)In acquisitions, create a fund. 3)In acquisitions, create a vendor. 4)In acquisitions, create a basket and add a test item to the basket. 5)Observe the column titles ecost tax inc. and ecost tax exc. Check the column visibility settings if you don't see the columns. 6)Apply the patch. 7)Observe the column titles have been updated. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 95741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95741&action=edit k -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95449|0 |1 is obsolete| | Attachment #95710|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 95742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95742&action=edit Bug 24033: Fix column labelling on basket summary page (ecost) When viewing a basket, some of the column names are unclear and are different than the terms used for the same field on the order form. This patch edits the column titles to match the order form. To test: 1) In acquisitions, create a budget. 2) In acquisitions, create a fund. 3) In acquisitions, create a vendor. 4) In acquisitions, create a basket and add a test item to the basket. 5) Observe the column titles ecost tax inc. and ecost tax exc. Check the column visibility settings if you don't see the columns. 6) Apply the patch. 7) Observe the column titles have been updated. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Lisette, nice patch! Just some small things for your next one: - The first line always needs to start with 'Bug xxxx:'. - Something seems to happen to the breaks in your patches - no problem, I've fixed it. How do you write the commit message? Maybe try to add an extra empty line after the first. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lisette Scheer from comment #7)

(In reply to Katrin Fischer from comment #6)

...

Hi Lisette, nice patch!

Just some small things for your next one:

- The first line always needs to start with 'Bug xxxx:'. - Something seems to happen to the breaks in your patches - no problem, I've fixed it. How do you write the commit message? Maybe try to add an extra empty line after the first.

Katrin, Thanks for fixing it. I'm using the devbox. I'll do: 1) git commit basket.tt 2) Write the commit notes, following the instructions on the wiki that I found here: https://wiki.koha-community.org/wiki/Commit_messages 3) :wq! to write and quit. 4) git bz attach -e 24403 HEAD 5) Put all the line breaks back in and change the status.

I did think it was quirky that I had to put the line breaks in again. That was also why I had 2 patches on this one. The first time I forgot to -e so I re-attached it after editing.

Hm something is odd there, you shouldn't have to do anything on bugzilla and it doesn't really work well this way. It sounds like you are using vi in the devbox. One can change the default editor for git via the config files for the devbox, maybe this could improve things... but it SHOULD work with vi too :( -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | CC| |joy@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #10 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes.