[Bug 11409] New: ungrouped baskets are not being displayed when creating a new basket group
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11409 Bug ID: 11409 Summary: ungrouped baskets are not being displayed when creating a new basket group Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: gmcharlt@gmail.com QA Contact: testopia@bugs.koha-community.org When creating a new basket group for a vendor, the open, ungrouped baskets are not being displayed in the right-hand text area. Without this, it is impossible to add baskets to a basket group without using the option to close a basket and add it to a new group. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11409 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11409 --- Comment #1 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 23605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23605&action=edit Bug 11409: display ungrouped baskets when create new basket group This patch fixes a problem where, when creating a new basket group for a vendor, no open baskets were displayed in the ungrouped baskets control, thereby making it impossible to add baskets to the group from that interface. This patch fixes that. To test ------- [1] Create some order baskets for a vendor. Make sure that at least one of them gets closed. [2] From the vendor details page, click the basket groups link and create a new basket group. [3] Observe that none of the open baskets are available to be selected. [4] Apply the patch and refresh. [5] This time, the open baskets should be listed in the ungrouped baskets widget. [6] Verify that you can move some baskets into the group and save the group. [7] Verify that no closed baskets show up in the ungrouped baskets widget. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11409 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> --- Having looked into this more, I've now noticed the help text for the basket groups page: A basket group is a group of closed baskets that you can perform actions on. In other words, if this is the case, this patch is invalid. However, I'm leaving this bug open for discussion for the moment -- since both Tomas and I ended up with the same misconception that it should be possible to put open baskets into a group, others might have the same view. This suggests to me that there might be a use case for being able to put baskets in a group before they get closed. Even if that's not the case, it also suggests that the heading for the ungrouped baskets widget might be better as "Ungrouped closed baskets". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11409 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #3 from Nicole C. Engard <nengard@gmail.com> --- Galen, I have to admit that I am clueless about the point of a basket group in the first place. That said, you are correct (and the manual is correct) basket groups are only for closed baskets. You add them to the basket group when you close the basket - it's a question you're asked upon closing. If someone can explain to me why I'd want/need a basket group in the first place I might be able to say if we should have groups created before closing as well ... but right now I can come up with no reason. Nicole -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11409 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Nicole C. Engard from comment #3)
Galen,
I have to admit that I am clueless about the point of a basket group in the first place. That said, you are correct (and the manual is correct) basket groups are only for closed baskets. You add them to the basket group when you close the basket - it's a question you're asked upon closing.
If someone can explain to me why I'd want/need a basket group in the first place I might be able to say if we should have groups created before closing as well ... but right now I can come up with no reason.
I guess it has to be related to printing. It looks like the only thing you can do with closed basket groups is print them. Regards To+ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11409 --- Comment #5 from Nicole C. Engard <nengard@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #4)
I guess it has to be related to printing. It looks like the only thing you can do with closed basket groups is print them.
Regards To+
Which is why I've never seen a US library use groups because printing means a PDF with 'Frenchisms' hard coded in. Nicole -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11409 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think currently the point of basket groups is indeed printing and exporting of data. You can print a 3 page layout that include a kind of 'table of contents' of the basket group and then each basket on the following pages. Or you can have a 2 page layout that, which leaves out the toc and maks sense if you only want to print 1 order per PDF.I think it's now also possible to export CSV data, that will include the basket group information. I found this post form Paul explaining some about the workflow: http://lists.katipo.co.nz/public/koha/2013-September/037276.html My feeling is that if we allow adding non-closed baskets to the basket group, they should probably be closed in the process. You can ungroup a basket from its basket group. So ungrouped closed baskets should probably show up, but not totally sure about the open baskets. Some of our libraries have expressed interest in PDF printing, but the PDF will have to be translated and maybe reformatted, which is currently not an easy task. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org