[Bug 43246] New: Entering dates with a keyboard creates due dates with time set to 00:00
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43246 Bug ID: 43246 Summary: Entering dates with a keyboard creates due dates with time set to 00:00 Initiative type: --- Sponsorship --- status: Product: Koha Version: 25.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: janne.seppanen@lahti.fi QA Contact: testopia@bugs.koha-community.org Target Milestone: --- One can enter due dates manually with the current datepicker in Koha. When picking dates from the calendar widget, Koha creates due dates with 23:59 as the latest return time on that date. However, when entering the date with a keyboard the time sets to 00:00, meaning that if the patron returns their loans on the due date, they're already late. There seems to have been a similar bug with the old date widget, maybe this bug has returned with the release of the new datepicker widget? https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34939 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43246 Lari Strand <lmstrand@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lmstrand@gmail.com --- Comment #1 from Lari Strand <lmstrand@gmail.com> --- Created attachment 203452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203452&action=edit Bug 43246 - append 23:59 to datetime type flatpickr elements without time typed in on blur Test plan: 1. Apply patch 2. Navigate to circulation renewal screen or batch checkout page. 3. Test time-enabled datepicker fields (data-flatpickr-enable-time="true"): - Navigate to any circulation page with due date fields (e.g., circulation.tt, renew.tt, batch checkouts) - Type a date without time (e.g., "8.8.2026") - Leave the field (Tab or click elsewhere) - Verify time auto-fills with "23:59" Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43246 Lari Strand <lmstrand@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43246 Bastien Chauvet <bastien.chauvet@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43246 --- Comment #2 from Bastien Chauvet <bastien.chauvet@inlibro.com> --- Created attachment 205090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205090&action=edit Bug 43246 - append 23:59 to datetime type flatpickr elements without time typed in on blur Test plan: 1. Apply patch 2. Navigate to circulation renewal screen or batch checkout page. 3. Test time-enabled datepicker fields (data-flatpickr-enable-time="true"): - Navigate to any circulation page with due date fields (e.g., circulation.tt, renew.tt, batch checkouts) - Type a date without time (e.g., "8.8.2026") - Leave the field (Tab or click elsewhere) - Verify time auto-fills with "23:59" Signed-off-by: Bastien CHAUVET <bastien.chauvet@inlibro.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43246 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lmstrand@gmail.com |ity.org | CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Added assignee. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43246 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203452|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43246 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 205094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205094&action=edit Bug 43246: Append 23:59 to datetime type flatpickr elements without time typed in on blur Test plan: 1. Apply patch 2. Navigate to circulation renewal screen or batch checkout page. 3. Test time-enabled datepicker fields (data-flatpickr-enable-time="true"): - Navigate to any circulation page with due date fields (e.g., circulation.tt, renew.tt, batch checkouts) - Type a date without time (e.g., "8.8.2026") - Leave the field (Tab or click elsewhere) - Verify time auto-fills with "23:59" Signed-off-by: Bastien CHAUVET <bastien.chauvet@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43246 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes entering dates release notes| |using the keyboard instead | |of using the date picker, | |for example when checking | |an item out to a patron. It | |now adds the time as ", | |23:59" to the end of the | |date, instead of ", 00:00". Version|25.05 |Main Severity|enhancement |normal Patch complexity|--- |Small patch --- Comment #5 from David Nind <david@davidnind.com> --- Changed importance from an enhancement to a normal bug, added patch complexity, and added a release note. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43246 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #205090|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Comment on attachment 205090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205090 Bug 43246 - append 23:59 to datetime type flatpickr elements without time typed in on blur I amended the commit message to fix the patch subject line - see commit message guidelines https://wiki.koha-community.org/wiki/Commit_messages#Subject_line_.28summary... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43246 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |aleisha@catalyst.net.nz |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43246 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|aleisha@catalyst.net.nz |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43246 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #205094|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43246 --- Comment #7 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 207023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207023&action=edit Bug 43246: Append 23:59 to datetime type flatpickr elements without time typed in on blur Test plan: 1. Apply patch 2. Navigate to circulation renewal screen or batch checkout page. 3. Test time-enabled datepicker fields (data-flatpickr-enable-time="true"): - Navigate to any circulation page with due date fields (e.g., circulation.tt, renew.tt, batch checkouts) - Type a date without time (e.g., "8.8.2026") - Leave the field (Tab or click elsewhere) - Verify time auto-fills with "23:59" Signed-off-by: Bastien CHAUVET <bastien.chauvet@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43246 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k Status|Passed QA |Failed QA --- Comment #8 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Any due date with a time of 00:00 is now changed to 23:59 when the field loses focus, is this intended? Test plan 1, typed midnight: 1) Go to circulation.pl and pick a patron 2) Open 'Checkout settings', type 12/12/2026 00:00 as the due date and tab away 3) Notice the time changes to 23:59 Test plan 2, midnight picked in the date picker: 1) Same screen, pick a due date in the date picker and set the time to 00:00 2) Click outside to close the picker 3) Click into the due date field, then click outside it again 4) Notice the time changes to 23:59 Should we only append 23:59 when the typed text has no time part, instead of checking for the hour being 0? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org