[Bug 27864] New: Pickup locations while placing a hold on the staff client should respect hold fulfillment policies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Bug ID: 27864 Summary: Pickup locations while placing a hold on the staff client should respect hold fulfillment policies Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When adjusting pickup locations for existing holds the dropdown populates only with allowed libraries. The dropdown while placing holds should use the same logic. This should be fixed after addressing bug 27863 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Depends on| |27863 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27863 [Bug 27863] Holds API route for pickup_libraries should return all branches if 'AllowHoldPolicyOverride' is enabled -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Bug 27864 depends on bug 27863, which changed state. Bug 27863 Summary: Add a way to override constraints on pickup_libraries route if 'AllowHoldPolicyOverride' is enabled https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27863 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Bug 27864 depends on bug 27863, which changed state. Bug 27863 Summary: Cannot select different pickup locations even with AllowHoldsPolicyOverride on request.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27863 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WONTFIX |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Nick Clemens from comment #0)
When adjusting pickup locations for existing holds the dropdown populates only with allowed libraries.
The dropdown while placing holds should use the same logic.
This should be fixed after addressing bug 27863
I think this description is exactly what 27863 does, and this bug is (as the title says) about placing holds on request.pl. Going forward with that, but wanted to note this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27894 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27894 [Bug 27894] Add visual feedback on overridden pickup locations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27931 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27931 [Bug 27931] Add GET /items/:item_id/pickup_locations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27932 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27932 [Bug 27932] Add GET /biblios/:biblio_id/pickup_locations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 118232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118232&action=edit Bug 27864: Visual feedback on overridden pickup locations when placing hold This patch makes the form for placing a hold, use the API to retrieve the valid pickup locations for a biblio. To test: 1. Try placing a hold on a biblio with several items. => SUCCESS: You get a list of valid pickup locations => FAIL: There's no sign they are overrides to rules 2. Apply this patch 3. Repeat 1 => SUCCESS: Same behavior as before, but there's a sign +tooltip for overridden ones. 4. Sign off :-D Note: styling follow-up coming -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 118236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118236&action=edit Bug 27864: Correct dropdown size This patch makes the dropdown width inherit the existing style. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Pickup locations while |Visual feedback on |placing a hold on the staff |overridden pickup locations |client should respect hold |when placing hold (staff) |fulfillment policies | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Visual feedback on |Visual feedback on |overridden pickup locations |overridden pickup locations |when placing hold (staff) |when placing biblio-level | |hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #4 from David Nind <david@davidnind.com> --- Patch no longer applies 8-(.. 118232 - Bug 27864: Visual feedback on overridden pickup locations when placing hold 118236 - Bug 27864: Correct dropdown size Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27864: Visual feedback on overridden pickup locations when placing hold error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt). error: could not build fake ancestor Patch failed at 0001 Bug 27864: Visual feedback on overridden pickup locations when placing hold Testing notes: - To setup for testing follow the test plan as for bug 27863: . In Circulation and fines rules > Default checkout, hold and return policy, change 'Hold pickup library match' to 'item's home library' . Set AllowHoldPolicyOverride system preference to Allow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118232|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 119722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119722&action=edit Bug 27864: Visual feedback on overridden pickup locations when placing hold This patch makes the form for placing a hold, use the API to retrieve the valid pickup locations for a biblio. To test: 1. Try placing a hold on a biblio with several items. => SUCCESS: You get a list of valid pickup locations => FAIL: There's no sign they are overrides to rules 2. Apply this patch 3. Repeat 1 => SUCCESS: Same behavior as before, but there's a sign +tooltip for overridden ones. 4. Sign off :-D Note: styling follow-up coming Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118236|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 119723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119723&action=edit Bug 27864: Correct dropdown size This patch makes the dropdown width inherit the existing style. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Patch doesn't apply |Signed Off --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Looks great, Signing off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Nick, could you QA this one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- The biblio_id and patron_id fields are not populated and the GET request is failing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118232|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118236|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118232|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119722|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119723|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118236|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 120012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120012&action=edit Bug 27864: Visual feedback on overridden pickup locations when placing hold This patch makes the form for placing a hold, use the API to retrieve the valid pickup locations for a biblio. To test: 1. Try placing a hold on a biblio with several items. => SUCCESS: You get a list of valid pickup locations => FAIL: There's no sign they are overrides to rules 2. Apply this patch 3. Repeat 1 => SUCCESS: Same behavior as before, but there's a sign +tooltip for overridden ones. 4. Sign off :-D Note: styling follow-up coming Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 120013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120013&action=edit Bug 27864: Correct dropdown size This patch makes the dropdown width inherit the existing style. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Re-submitted due to some rebase problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120012|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120014&action=edit Bug 27864: Visual feedback on overridden pickup locations when placing hold This patch makes the form for placing a hold, use the API to retrieve the valid pickup locations for a biblio. To test: 1. Try placing a hold on a biblio with several items. => SUCCESS: You get a list of valid pickup locations => FAIL: There's no sign they are overrides to rules 2. Apply this patch 3. Repeat 1 => SUCCESS: Same behavior as before, but there's a sign +tooltip for overridden ones. 4. Sign off :-D Note: styling follow-up coming Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120013|0 |1 is obsolete| | --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120015&action=edit Bug 27864: Correct dropdown size This patch makes the dropdown width inherit the existing style. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt FAIL forbidden patterns forbidden pattern: Don't use select tag's size attribute where it is 1 (bug 28066) (line 445) forbidden pattern: Don't use select tag's size attribute where it is 1 (bug 28066) (line 448) Do you people forget to run the QA script? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #15)
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt FAIL forbidden patterns forbidden pattern: Don't use select tag's size attribute where it is 1 (bug 28066) (line 445) forbidden pattern: Don't use select tag's size attribute where it is 1 (bug 28066) (line 448)
Do you people forget to run the QA script?
I don't get that. I'm pulling the latest qa tools... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 120170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120170&action=edit Bug 27864: (QA follow-up) Remove size=1 on selects (28066 follow-up) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Please provide a full test plan, I don't see the visual feedback.
=> FAIL: There's no sign they are overrides to rules
I don't understand what this means. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #18)
Please provide a full test plan, I don't see the visual feedback.
=> FAIL: There's no sign they are overrides to rules
I don't understand what this means.
Without the patch, you have a dropdown with the pickup_location=1 branches. With the patch, you have the same [1], but there's a visual sign indicating that choosing some of the pickup locations implies an override to rules. This is affected by circulation rules, so you need to make sure the item homebranch, the patron branch, and the rules make some of the pickup locations invalid (and thus require AllowHoldsPolicyOverride to be picked). [1] The same, but using Select2 and API routes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch changes the release notes| |pickup location dropdown, | |when placing biblio-level | |holds, so it renders a | |sign, alerting that | |circulation rules would be | |overridden if the pickup | |location is chosen. | | | |It | |relies on new API routes. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120014|0 |1 is obsolete| | Attachment #120015|0 |1 is obsolete| | Attachment #120170|0 |1 is obsolete| | --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120243&action=edit Bug 27864: Visual feedback on overridden pickup locations when placing hold This patch makes the form for placing a hold, use the API to retrieve the valid pickup locations for a biblio. To test: 1 - In Circulation and fines rules > Default checkout, hold and return policy, change 'Hold pickup library match' to 'item's home library' 2 - Set AllowHoldPolicyOverride system preference to Allow 3 - Try placing a hold on a biblio with several items. Ensure that there is one item with homebranch of the patrons branch and one at another branch 4 - Note the pickup location dropdown lists all branches, even those not matching the policy (Item's home library) 5 - FAIL: There's no sign they are overrides to rules 6 - Apply the patch 7 - Repeat 3 8 - SUCCESS: Same behavior as before all libraires listed, but there's a sign + tooltip for overridden ones. 9 - Sign off :-D Note: styling follow-up coming Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120244&action=edit Bug 27864: Correct dropdown size This patch makes the dropdown width inherit the existing style. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120245&action=edit Bug 27864: (QA follow-up) Remove size=1 on selects (28066 follow-up) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Thank you, Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 --- Comment #24 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Thanks, Nick. There is a tiny ergonomic issue with the visual feedback: https://snipboard.io/5Wk9IQ.jpg Did you try to fix it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|27931 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27931 [Bug 27931] Add GET /items/:item_id/pickup_locations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #24)
Thanks, Nick.
There is a tiny ergonomic issue with the visual feedback: https://snipboard.io/5Wk9IQ.jpg Did you try to fix it?
Hi, how did you get that? I've tried this patches now, on Firefox, Chrome and Safari and couldn't reproduce the visual glitch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28261 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28261 [Bug 28261] Add visual feedback on overridden pickup locations on patron's page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 --- Comment #26 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #25)
(In reply to Jonathan Druart from comment #24)
Thanks, Nick.
There is a tiny ergonomic issue with the visual feedback: https://snipboard.io/5Wk9IQ.jpg Did you try to fix it?
Hi, how did you get that? I've tried this patches now, on Firefox, Chrome and Safari and couldn't reproduce the visual glitch.
Can be reproduced on FF with zoom at 133% -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 --- Comment #27 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Something else (not directly related to this?): 1 - In Circulation and fines rules > Default checkout, hold and return policy, change 'Hold pickup library match' to 'item's home library' 2 - Set AllowHoldPolicyOverride system preference to "*NOT ALLOWED*" 3 - /cgi-bin/koha/reserve/request.pl?biblionumber=233 4 - Search "edna" => https://snipboard.io/F8oLIN.jpg Only Fairview and Midway are available but Centerville is preselected (and not in the dropdown list). Save anyway => Centerville is saved (shouldn't be rejected?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #28 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I confirm it's directly related to this patch set. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 120341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120341&action=edit Bug 27864: (QA follow-up) Hide logged-in option if invalid pickup location Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 --- Comment #30 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 120342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120342&action=edit Bug 27864: (QA follow-up) Select2 style on multi-holds Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28273 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27864 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #32 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org