[Bug 5838] New: Don't show sql statement on guided reports result page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5838 Bug #: 5838 Summary: Don't show sql statement on guided reports result page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All URL: /cgi-bin/koha/reports/guided_reports.pl?reports=1&phas e=Run this report OS/Version: All Status: ASSIGNED Severity: enhancement Priority: P5 Component: Reports AssignedTo: katrin.fischer@bsz-bw.de ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha-bugs@lists.koha-community.org The sql statement is shown unformatted under the notes and result numbers of a guided report. As we have a page dedicated to show the sql of a guided report, I don't think this is necessary. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5838 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-03-07 07:08:13 UTC --- Created attachment 3258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3258 proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5838 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5838 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #2 from Paul Poulain <paul.poulain@biblibre.com> 2011-03-07 08:19:38 UTC --- Not sure I agree with this idea. I find handfull to have the details of the report in case of printing it. (won't argue for hours if others say "yes it's a good idea" though) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5838 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-03-07 08:27:59 UTC --- Hi Paul, I disagree :) I especially don't like it on printouts. My librarians have no idea about the sql behind the reporst and are more confused by it than that it is helpful for them. Also you might want to hang up some of your printed reports in the library. The sql output currently is not formatted in any way, not wrapped into a html tag even and flowing together with the pagination. Making the pagination hard to be seen. And longer sql statements quite unreadable. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5838 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #4 from Nicole C. Engard <nengard@gmail.com> 2011-03-07 19:29:30 UTC --- Can I have a link to a page that shows the way this used to appear? I'm confused about how to test this because I'm not sure what page to look at. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5838 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-03-07 21:22:12 UTC --- Hi Nicole, thx for testing :) 1) Create a new report from sql 2) Run it 3) Look at the top of the results page URL will be something like '/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Run this report'. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5838 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5838 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-03-27 17:05:43 UTC --- Created attachment 3442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3442 screenshot New suggestion: wrapping the sql output in <pre> with unique id. - sql can be formatted - sql can be hidden using css and the unique id - pagination is pushed to its own line and better visible -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5838 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3258|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-03-27 17:09:03 UTC --- Created attachment 3443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3443 New patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5838 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5838 --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2011-03-27 17:31:53 UTC --- Created attachment 3445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3445 Signed-off patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5838 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcamins@cpbibliography.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5838 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Signed Off |Patch Pushed --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-28 20:56:37 UTC --- I like this new patch much better, pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5838 Mark Gavillet <mark.gavillet@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |mark.gavillet@ptfs-europe.c | |om Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5838 --- Comment #10 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-04-10 11:25:00 UTC --- This bug is mentioned in: Bug 5838: Don't show sql statement on guided reports result page http://lists.koha-community.org/pipermail/koha-patches/2011-March/013998.htm... Bug 5838: Don't show sql statement on guided reports result page http://lists.koha-community.org/pipermail/koha-patches/2011-March/014007.htm... Bug 5838: Format sql outout on guided reports http://lists.koha-community.org/pipermail/koha-patches/2011-March/014240.htm... Bug 5838: Format sql outout on guided reports http://lists.koha-community.org/pipermail/koha-patches/2011-March/014241.htm... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org